From: Josh Poimboeuf <jpoimboe@kernel.org>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: linux-hyperv@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org, decui@microsoft.com,
haiyangz@microsoft.com, kys@microsoft.com, wei.liu@kernel.org,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, hpa@zytor.com,
thomas.lendacky@amd.com, peterz@infradead.org,
kernel-dev@igalia.com, kernel@gpiccoli.net,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] x86/hyperv: Mark hv_ghcb_terminate() as noreturn
Date: Fri, 10 Mar 2023 07:24:42 -0800 [thread overview]
Message-ID: <20230310152442.cbrjise6uex4ak4x@treble> (raw)
In-Reply-To: <20230310140251.1159036-1-gpiccoli@igalia.com>
On Fri, Mar 10, 2023 at 11:02:52AM -0300, Guilherme G. Piccoli wrote:
> Hey folks, after getting the warning myself a quick search led me to Arnd's
> thorough report - investigating a bit, this seems to be the proper solution.
>
> Notice I didn't add the function to objtool's static list, seems this is
> unnecessary in this case - lemme know otherwise!
> Thanks in advance for reviews,
I'd recommend also adding it to the objtool global_noreturns list,
otherwise this patch will probably trigger warnings with other non-IBT
configs, in cases where the function is called from another translation
unit, where GCC knows the function is noreturn but objtool doesn't.
We're looking at ways of eliminating global_noreturns, but it's
unfortunately still a necessary evil at this point.
Also, FWIW, I have a change coming soon which make these warnings much
easier to diagnose.
--
Josh
next prev parent reply other threads:[~2023-03-10 15:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 14:02 [PATCH] x86/hyperv: Mark hv_ghcb_terminate() as noreturn Guilherme G. Piccoli
2023-03-10 15:24 ` Josh Poimboeuf [this message]
2023-03-10 15:41 ` Guilherme G. Piccoli
2023-03-10 15:44 ` [PATCH v2] " Guilherme G. Piccoli
2023-03-10 21:17 ` Michael Kelley (LINUX)
2023-03-11 0:17 ` Guilherme G. Piccoli
2023-03-16 21:24 ` Guilherme G. Piccoli
2023-03-17 13:40 ` Michael Kelley (LINUX)
2023-03-17 14:53 ` Josh Poimboeuf
2023-03-17 16:04 ` Guilherme G. Piccoli
2023-03-17 16:05 ` [PATCH v3] " Guilherme G. Piccoli
2023-03-17 16:24 ` Josh Poimboeuf
2023-03-17 19:27 ` Guilherme G. Piccoli
2023-03-17 16:46 ` Michael Kelley (LINUX)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230310152442.cbrjise6uex4ak4x@treble \
--to=jpoimboe@kernel.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=gpiccoli@igalia.com \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=kernel-dev@igalia.com \
--cc=kernel@gpiccoli.net \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=wei.liu@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox