From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: "Michael Kelley (LINUX)" <mikelley@microsoft.com>,
"x86@kernel.org" <x86@kernel.org>,
"jpoimboe@kernel.org" <jpoimboe@kernel.org>
Cc: "linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Dexuan Cui <decui@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
KY Srinivasan <kys@microsoft.com>,
"wei.liu@kernel.org" <wei.liu@kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"bp@alien8.de" <bp@alien8.de>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"thomas.lendacky@amd.com" <thomas.lendacky@amd.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"kernel-dev@igalia.com" <kernel-dev@igalia.com>,
"kernel@gpiccoli.net" <kernel@gpiccoli.net>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2] x86/hyperv: Mark hv_ghcb_terminate() as noreturn
Date: Thu, 16 Mar 2023 18:24:21 -0300 [thread overview]
Message-ID: <a1f40654-b3cf-5c77-561e-056f47cbff61@igalia.com> (raw)
In-Reply-To: <BYAPR21MB16888EBB51D1597F9B9C212FD7BA9@BYAPR21MB1688.namprd21.prod.outlook.com>
On 10/03/2023 18:17, Michael Kelley (LINUX) wrote:
> [...]
> Just curious: Should the actual function also be updated with
> __noreturn? In similar situations, such as snp_abort(), the
> __noreturn attribute is both places. I don't know what the
> guidance is on this question.
>
Hi Michael / Josh (and all), lemme know if you want me to submit a V3
doing that. The function is not called inside this own definition file
nor exported, so I'm not sure that'd be necessary, but glad to do so if
you prefer.
Thanks,
Guilherme
next prev parent reply other threads:[~2023-03-16 21:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 14:02 [PATCH] x86/hyperv: Mark hv_ghcb_terminate() as noreturn Guilherme G. Piccoli
2023-03-10 15:24 ` Josh Poimboeuf
2023-03-10 15:41 ` Guilherme G. Piccoli
2023-03-10 15:44 ` [PATCH v2] " Guilherme G. Piccoli
2023-03-10 21:17 ` Michael Kelley (LINUX)
2023-03-11 0:17 ` Guilherme G. Piccoli
2023-03-16 21:24 ` Guilherme G. Piccoli [this message]
2023-03-17 13:40 ` Michael Kelley (LINUX)
2023-03-17 14:53 ` Josh Poimboeuf
2023-03-17 16:04 ` Guilherme G. Piccoli
2023-03-17 16:05 ` [PATCH v3] " Guilherme G. Piccoli
2023-03-17 16:24 ` Josh Poimboeuf
2023-03-17 19:27 ` Guilherme G. Piccoli
2023-03-17 16:46 ` Michael Kelley (LINUX)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1f40654-b3cf-5c77-561e-056f47cbff61@igalia.com \
--to=gpiccoli@igalia.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@kernel.org \
--cc=kernel-dev@igalia.com \
--cc=kernel@gpiccoli.net \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=thomas.lendacky@amd.com \
--cc=wei.liu@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox