[PATCH] hyperv: Clean up and fix the guest ID comment in hvgdk.h

[PATCH] hyperv: Clean up and fix the guest ID comment in hvgdk.h

[Dexuan Cui]

Change the "64 bit" to "64-bit", and the "Os" to "OS".

Remove the obsolete paragraph since the guideline has been
published in the Hypervisor Top Level Functional Specification
for many years.

The "OS Type" is 0x1 for Linux, not 0x100.

No functional change.

Fixes: 83ba0c4f3f31 ("Drivers: hv: Cleanup the guest ID computation")
Signed-off-by: Dexuan Cui <decui@microsoft.com>
---
 include/hyperv/hvgdk.h | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/include/hyperv/hvgdk.h b/include/hyperv/hvgdk.h
index 384c3f3ff4a5..f538144280ca 100644
--- a/include/hyperv/hvgdk.h
+++ b/include/hyperv/hvgdk.h
@@ -10,18 +10,12 @@
 
 /*
  * The guest OS needs to register the guest ID with the hypervisor.
- * The guest ID is a 64 bit entity and the structure of this ID is
+ * The guest ID is a 64-bit entity and the structure of this ID is
  * specified in the Hyper-V TLFS specification.
  *
- * While the current guideline does not specify how Linux guest ID(s)
- * need to be generated, our plan is to publish the guidelines for
- * Linux and other guest operating systems that currently are hosted
- * on Hyper-V. The implementation here conforms to this yet
- * unpublished guidelines.
- *
  * Bit(s)
  * 63 - Indicates if the OS is Open Source or not; 1 is Open Source
- * 62:56 - Os Type; Linux is 0x100
+ * 62:56 - OS Type; Linux is 0x1
  * 55:48 - Distro specific identification
  * 47:16 - Linux kernel version number
  * 15:0  - Distro specific identification
-- 
2.34.1

Re: [PATCH] hyperv: Clean up and fix the guest ID comment in hvgdk.h

[Hamza Mahfooz]

On Wed, May 27, 2026 at 12:21:01PM -0700, Dexuan Cui wrote:
> Change the "64 bit" to "64-bit", and the "Os" to "OS".
> 
> Remove the obsolete paragraph since the guideline has been
> published in the Hypervisor Top Level Functional Specification
> for many years.
> 
> The "OS Type" is 0x1 for Linux, not 0x100.
> 
> No functional change.
> 
> Fixes: 83ba0c4f3f31 ("Drivers: hv: Cleanup the guest ID computation")
> Signed-off-by: Dexuan Cui <decui@microsoft.com>

Reviewed-by: Hamza Mahfooz <hamzamahfooz@linux.microsoft.com>

> ---
>  include/hyperv/hvgdk.h | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/include/hyperv/hvgdk.h b/include/hyperv/hvgdk.h
> index 384c3f3ff4a5..f538144280ca 100644
> --- a/include/hyperv/hvgdk.h
> +++ b/include/hyperv/hvgdk.h
> @@ -10,18 +10,12 @@
>  
>  /*
>   * The guest OS needs to register the guest ID with the hypervisor.
> - * The guest ID is a 64 bit entity and the structure of this ID is
> + * The guest ID is a 64-bit entity and the structure of this ID is
>   * specified in the Hyper-V TLFS specification.
>   *
> - * While the current guideline does not specify how Linux guest ID(s)
> - * need to be generated, our plan is to publish the guidelines for
> - * Linux and other guest operating systems that currently are hosted
> - * on Hyper-V. The implementation here conforms to this yet
> - * unpublished guidelines.
> - *
>   * Bit(s)
>   * 63 - Indicates if the OS is Open Source or not; 1 is Open Source
> - * 62:56 - Os Type; Linux is 0x100
> + * 62:56 - OS Type; Linux is 0x1
>   * 55:48 - Distro specific identification
>   * 47:16 - Linux kernel version number
>   * 15:0  - Distro specific identification
> -- 
> 2.34.1
> 

Re: [PATCH] hyperv: Clean up and fix the guest ID comment in hvgdk.h

[Wei Liu]

On Wed, May 27, 2026 at 04:00:20PM -0400, Hamza Mahfooz wrote:
> On Wed, May 27, 2026 at 12:21:01PM -0700, Dexuan Cui wrote:
> > Change the "64 bit" to "64-bit", and the "Os" to "OS".
> > 
> > Remove the obsolete paragraph since the guideline has been
> > published in the Hypervisor Top Level Functional Specification
> > for many years.
> > 
> > The "OS Type" is 0x1 for Linux, not 0x100.
> > 
> > No functional change.
> > 
> > Fixes: 83ba0c4f3f31 ("Drivers: hv: Cleanup the guest ID computation")
> > Signed-off-by: Dexuan Cui <decui@microsoft.com>
> 
> Reviewed-by: Hamza Mahfooz <hamzamahfooz@linux.microsoft.com>

Applied. Thanks.