* [PATCH] mshv: fix hv_input_get_system_property struct
@ 2026-06-30 21:57 wei.liu
2026-06-30 22:50 ` Hamza Mahfooz
0 siblings, 1 reply; 3+ messages in thread
From: wei.liu @ 2026-06-30 21:57 UTC (permalink / raw)
To: Linux on Hyper-V List
Cc: Wei Liu, stable, K. Y. Srinivasan, Haiyang Zhang, Dexuan Cui,
Long Li, open list
From: Wei Liu <wei.liu@kernel.org>
Keep it in sync with the correct definition.
The old code worked by chance.
Cc: stable@kernel.org
Signed-off-by: Wei Liu <wei.liu@kernel.org>
---
include/hyperv/hvhdk_mini.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/hyperv/hvhdk_mini.h b/include/hyperv/hvhdk_mini.h
index b4cb2fa26e9b..035ba20870f7 100644
--- a/include/hyperv/hvhdk_mini.h
+++ b/include/hyperv/hvhdk_mini.h
@@ -184,8 +184,9 @@ enum hv_dynamic_processor_feature_property {
struct hv_input_get_system_property {
u32 property_id; /* enum hv_system_property */
+ u32 reserved;
union {
- u32 as_uint32;
+ u64 as_uint64;
#if IS_ENABLED(CONFIG_X86)
/* enum hv_dynamic_processor_feature_property */
u32 hv_processor_feature;
--
2.53.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mshv: fix hv_input_get_system_property struct
2026-06-30 21:57 [PATCH] mshv: fix hv_input_get_system_property struct wei.liu
@ 2026-06-30 22:50 ` Hamza Mahfooz
2026-07-01 16:11 ` Wei Liu
0 siblings, 1 reply; 3+ messages in thread
From: Hamza Mahfooz @ 2026-06-30 22:50 UTC (permalink / raw)
To: wei.liu
Cc: Linux on Hyper-V List, stable, K. Y. Srinivasan, Haiyang Zhang,
Dexuan Cui, Long Li, open list
On Tue, Jun 30, 2026 at 02:57:54PM -0700, wei.liu@kernel.org wrote:
> From: Wei Liu <wei.liu@kernel.org>
>
> Keep it in sync with the correct definition.
>
> The old code worked by chance.
>
> Cc: stable@kernel.org
Any idea how far back this goes? Also, does it require a check on the
hypervisor version, or was it always wrong?
> Signed-off-by: Wei Liu <wei.liu@kernel.org>
> ---
> include/hyperv/hvhdk_mini.h | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/hyperv/hvhdk_mini.h b/include/hyperv/hvhdk_mini.h
> index b4cb2fa26e9b..035ba20870f7 100644
> --- a/include/hyperv/hvhdk_mini.h
> +++ b/include/hyperv/hvhdk_mini.h
> @@ -184,8 +184,9 @@ enum hv_dynamic_processor_feature_property {
>
> struct hv_input_get_system_property {
> u32 property_id; /* enum hv_system_property */
> + u32 reserved;
> union {
> - u32 as_uint32;
> + u64 as_uint64;
> #if IS_ENABLED(CONFIG_X86)
> /* enum hv_dynamic_processor_feature_property */
> u32 hv_processor_feature;
> --
> 2.53.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mshv: fix hv_input_get_system_property struct
2026-06-30 22:50 ` Hamza Mahfooz
@ 2026-07-01 16:11 ` Wei Liu
0 siblings, 0 replies; 3+ messages in thread
From: Wei Liu @ 2026-07-01 16:11 UTC (permalink / raw)
To: Hamza Mahfooz
Cc: wei.liu, Linux on Hyper-V List, stable, K. Y. Srinivasan,
Haiyang Zhang, Dexuan Cui, Long Li, open list
On Tue, Jun 30, 2026 at 06:50:18PM -0400, Hamza Mahfooz wrote:
> On Tue, Jun 30, 2026 at 02:57:54PM -0700, wei.liu@kernel.org wrote:
> > From: Wei Liu <wei.liu@kernel.org>
> >
> > Keep it in sync with the correct definition.
> >
> > The old code worked by chance.
> >
> > Cc: stable@kernel.org
>
> Any idea how far back this goes? Also, does it require a check on the
> hypervisor version, or was it always wrong?
This should go as far as possible. The upstream version has always been
wrong.
We cannot check versions. Version numbers are not reliable indicators.
Wei
>
> > Signed-off-by: Wei Liu <wei.liu@kernel.org>
> > ---
> > include/hyperv/hvhdk_mini.h | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/hyperv/hvhdk_mini.h b/include/hyperv/hvhdk_mini.h
> > index b4cb2fa26e9b..035ba20870f7 100644
> > --- a/include/hyperv/hvhdk_mini.h
> > +++ b/include/hyperv/hvhdk_mini.h
> > @@ -184,8 +184,9 @@ enum hv_dynamic_processor_feature_property {
> >
> > struct hv_input_get_system_property {
> > u32 property_id; /* enum hv_system_property */
> > + u32 reserved;
> > union {
> > - u32 as_uint32;
> > + u64 as_uint64;
> > #if IS_ENABLED(CONFIG_X86)
> > /* enum hv_dynamic_processor_feature_property */
> > u32 hv_processor_feature;
> > --
> > 2.53.0
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-07-01 16:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-30 21:57 [PATCH] mshv: fix hv_input_get_system_property struct wei.liu
2026-06-30 22:50 ` Hamza Mahfooz
2026-07-01 16:11 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox