Re: [PATCH v5 7/9] mshv: detect and report SEV-SNP support at init

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch uses the compiler-defined `__x86_64__` macro instead of the kernel standard `CONFIG_X86_64`.
--

commit 25a294afba0df1fc3823f90fe382591fefe4ae1f
Author: Wei Liu <wei.liu@kernel.org>

mshv: detect and report SEV-SNP support at init

This commit queries MSHV dynamic processor features during parent
initialization to report SEV-SNP availability and the maximum number
of encrypted partitions. It also ensures the misc device rejects opens
until the partition hash table and interrupt handling are fully ready.

> diff --git a/drivers/hv/mshv_root_main.c b/drivers/hv/mshv_root_main.c
> index 42eb81b257092..bf43f1f1e6da5 100644
> --- a/drivers/hv/mshv_root_main.c
> +++ b/drivers/hv/mshv_root_main.c
[ ... ]
> @@ -3232,6 +3235,104 @@ static int mshv_root_scheduler_cleanup(unsigned int cpu)
>  }
>  
>  /* Must be called after retrieving the scheduler type */
> +#if defined(__x86_64__)

[Severity: Low]
Should this use the kernel standard CONFIG_X86_64 instead of the
compiler-defined __x86_64__ macro? Using the compiler macro circumvents
kernel configuration management and creates an inconsistency with the rest
of the file which relies on standard Kconfig macros.

> +static const char *hv_snp_status_to_string(enum hv_snp_status status)
> +{
> +	switch (status) {
> +	case HV_SNP_STATUS_NONE:
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260908121403.1160280-1-weh@linux.microsoft.com?part=7