* [PATCH v5 03/17] x86/msr: Minimize usage of native_*() msr access functions
2026-09-11 8:41 [PATCH v5 00/17] x86/msr: Inline rdmsr/wrmsr instructions Juergen Gross
@ 2026-09-11 8:41 ` Juergen Gross
2026-09-11 8:41 ` [PATCH v5 05/17] x86/hyperv: Switch from __rdmsr() to native_rdmsrq() Juergen Gross
2026-09-23 19:36 ` [PATCH v5 00/17] x86/msr: Inline rdmsr/wrmsr instructions Shreshth Srivastava
2 siblings, 0 replies; 6+ messages in thread
From: Juergen Gross @ 2026-09-11 8:41 UTC (permalink / raw)
To: linux-kernel, x86, linux-hyperv, kvm
Cc: Juergen Gross, K. Y. Srinivasan, Haiyang Zhang, Wei Liu,
Dexuan Cui, Long Li, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, Dave Hansen, H. Peter Anvin, Paolo Bonzini,
Vitaly Kuznetsov, Sean Christopherson, Boris Ostrovsky, xen-devel
In order to prepare for some MSR access function reorg work, switch
most users of native_{read|write}_msr[_safe]() to the more generic
rdmsr*()/wrmsr*() variants.
For now this will have some intermediate performance impact with
paravirtualization configured when running on bare metal, but this
is a prereq change for the planned direct inlining of the rdmsr/wrmsr
instructions with this configuration.
The main reason for this switch is the planned move of the MSR trace
function invocation from the native_*() functions to the generic
rdmsr*()/wrmsr*() variants. Without this switch the users of the
native_*() functions would lose the related tracing entries.
Note that the Xen related MSR access functions will not be switched,
as these will be handled after the move of the trace hooks.
Signed-off-by: Juergen Gross <jgross@suse.com>
Acked-by: Sean Christopherson <seanjc@google.com>
Acked-by: Wei Liu <wei.liu@kernel.org>
Reviewed-by: H. Peter Anvin (Intel) <hpa@zytor.com>
---
arch/x86/hyperv/ivm.c | 2 +-
arch/x86/kernel/cpu/mshyperv.c | 4 ++--
arch/x86/kernel/kvmclock.c | 2 +-
arch/x86/kvm/svm/svm.c | 16 ++++++++--------
arch/x86/xen/pmu.c | 4 ++--
5 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/arch/x86/hyperv/ivm.c b/arch/x86/hyperv/ivm.c
index 2ce4dfe53472..a74f121f2a02 100644
--- a/arch/x86/hyperv/ivm.c
+++ b/arch/x86/hyperv/ivm.c
@@ -328,7 +328,7 @@ int hv_snp_boot_ap(u32 apic_id, unsigned long start_ip, unsigned int cpu)
savesegment(ds, vmsa->ds.selector);
hv_populate_vmcb_seg(vmsa->ds, vmsa->gdtr.base);
- vmsa->efer = native_read_msr(MSR_EFER);
+ vmsa->efer = rdmsrq(MSR_EFER);
vmsa->cr4 = native_read_cr4();
vmsa->cr3 = __native_read_cr3();
diff --git a/arch/x86/kernel/cpu/mshyperv.c b/arch/x86/kernel/cpu/mshyperv.c
index e1388ed27384..53ac4ef53929 100644
--- a/arch/x86/kernel/cpu/mshyperv.c
+++ b/arch/x86/kernel/cpu/mshyperv.c
@@ -114,7 +114,7 @@ u64 hv_para_get_synic_register(unsigned int reg)
{
if (WARN_ON(!ms_hyperv.paravisor_present || !hv_is_synic_msr(reg)))
return ~0ULL;
- return native_read_msr(reg);
+ return rdmsrq(reg);
}
/*
@@ -124,7 +124,7 @@ void hv_para_set_synic_register(unsigned int reg, u64 val)
{
if (WARN_ON(!ms_hyperv.paravisor_present || !hv_is_synic_msr(reg)))
return;
- native_write_msr(reg, val);
+ wrmsrq(reg, val);
}
u64 hv_get_msr(unsigned int reg)
diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c
index cb3d0ca1fa22..6ddef8b5426a 100644
--- a/arch/x86/kernel/kvmclock.c
+++ b/arch/x86/kernel/kvmclock.c
@@ -219,7 +219,7 @@ static void kvm_setup_secondary_clock(void)
void kvmclock_disable(void)
{
if (msr_kvm_system_time)
- native_write_msr(msr_kvm_system_time, 0);
+ wrmsrq(msr_kvm_system_time, 0);
}
static void __init kvmclock_init_mem(void)
diff --git a/arch/x86/kvm/svm/svm.c b/arch/x86/kvm/svm/svm.c
index 91f5a5344529..5e5bbecb8020 100644
--- a/arch/x86/kvm/svm/svm.c
+++ b/arch/x86/kvm/svm/svm.c
@@ -412,12 +412,12 @@ static void svm_init_erratum_383(void)
return;
/* Use _safe variants to not break nested virtualization */
- if (native_read_msr_safe(MSR_AMD64_DC_CFG, &val))
+ if (rdmsrq_safe(MSR_AMD64_DC_CFG, &val))
return;
val |= (1ULL << 47);
- native_write_msr_safe(MSR_AMD64_DC_CFG, val);
+ wrmsrq_safe(MSR_AMD64_DC_CFG, val);
erratum_383_found = true;
}
@@ -470,8 +470,8 @@ static void svm_init_os_visible_workarounds(void)
return;
if (!this_cpu_has(X86_FEATURE_OSVW) ||
- native_read_msr_safe(MSR_AMD64_OSVW_ID_LENGTH, &len) ||
- native_read_msr_safe(MSR_AMD64_OSVW_STATUS, &status))
+ rdmsrq_safe(MSR_AMD64_OSVW_ID_LENGTH, &len) ||
+ rdmsrq_safe(MSR_AMD64_OSVW_STATUS, &status))
len = status = 0;
if (status == READ_ONCE(osvw_status) && len >= READ_ONCE(osvw_len))
@@ -2112,7 +2112,7 @@ static bool is_erratum_383(void)
if (!erratum_383_found)
return false;
- if (native_read_msr_safe(MSR_IA32_MC0_STATUS, &value))
+ if (rdmsrq_safe(MSR_IA32_MC0_STATUS, &value))
return false;
/* Bit 62 may or may not be set for this mce */
@@ -2123,11 +2123,11 @@ static bool is_erratum_383(void)
/* Clear MCi_STATUS registers */
for (i = 0; i < 6; ++i)
- native_write_msr_safe(MSR_IA32_MCx_STATUS(i), 0);
+ wrmsrq_safe(MSR_IA32_MCx_STATUS(i), 0);
- if (!native_read_msr_safe(MSR_IA32_MCG_STATUS, &value)) {
+ if (!rdmsrq_safe(MSR_IA32_MCG_STATUS, &value)) {
value &= ~(1ULL << 2);
- native_write_msr_safe(MSR_IA32_MCG_STATUS, value);
+ wrmsrq_safe(MSR_IA32_MCG_STATUS, value);
}
/* Flush tlb to evict multi-match entries */
diff --git a/arch/x86/xen/pmu.c b/arch/x86/xen/pmu.c
index 5f50a3ee08f5..37512df8b8f2 100644
--- a/arch/x86/xen/pmu.c
+++ b/arch/x86/xen/pmu.c
@@ -324,7 +324,7 @@ static u64 xen_amd_read_pmc(int counter)
u64 val;
msr = amd_counters_base + (counter * amd_msr_step);
- native_read_msr_safe(msr, &val);
+ rdmsrq_safe(msr, &val);
return val;
}
@@ -350,7 +350,7 @@ static u64 xen_intel_read_pmc(int counter)
else
msr = MSR_IA32_PERFCTR0 + counter;
- native_read_msr_safe(msr, &val);
+ rdmsrq_safe(msr, &val);
return val;
}
--
2.55.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v5 05/17] x86/hyperv: Switch from __rdmsr() to native_rdmsrq()
2026-09-11 8:41 [PATCH v5 00/17] x86/msr: Inline rdmsr/wrmsr instructions Juergen Gross
2026-09-11 8:41 ` [PATCH v5 03/17] x86/msr: Minimize usage of native_*() msr access functions Juergen Gross
@ 2026-09-11 8:41 ` Juergen Gross
2026-09-23 19:36 ` [PATCH v5 00/17] x86/msr: Inline rdmsr/wrmsr instructions Shreshth Srivastava
2 siblings, 0 replies; 6+ messages in thread
From: Juergen Gross @ 2026-09-11 8:41 UTC (permalink / raw)
To: linux-kernel, x86, linux-hyperv
Cc: Juergen Gross, K. Y. Srinivasan, Haiyang Zhang, Wei Liu,
Dexuan Cui, Long Li, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, Dave Hansen, H. Peter Anvin, kernel test robot
The __rdmsr() helper will be changed soon, so don't use it directly
outside of msr.h. Switch to native_rdmsrq() in HyperV related code.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202602182222.WEBLSQRj-lkp@intel.com/
Signed-off-by: Juergen Gross <jgross@suse.com>
---
V4:
- new patch (kernel test robot)
---
arch/x86/hyperv/hv_crash.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/x86/hyperv/hv_crash.c b/arch/x86/hyperv/hv_crash.c
index 5ffcc23255de..28ee76e18d9b 100644
--- a/arch/x86/hyperv/hv_crash.c
+++ b/arch/x86/hyperv/hv_crash.c
@@ -217,9 +217,9 @@ static void hv_hvcrash_ctxt_save(void)
native_store_gdt(&ctxt->gdtr);
store_idt(&ctxt->idtr);
- ctxt->gsbase = __rdmsr(MSR_GS_BASE);
- ctxt->efer = __rdmsr(MSR_EFER);
- ctxt->pat = __rdmsr(MSR_IA32_CR_PAT);
+ ctxt->gsbase = native_rdmsrq(MSR_GS_BASE);
+ ctxt->efer = native_rdmsrq(MSR_EFER);
+ ctxt->pat = native_rdmsrq(MSR_IA32_CR_PAT);
}
/* Add trampoline page to the kernel pagetable for transition to kernel PT */
--
2.55.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v5 00/17] x86/msr: Inline rdmsr/wrmsr instructions
2026-09-11 8:41 [PATCH v5 00/17] x86/msr: Inline rdmsr/wrmsr instructions Juergen Gross
2026-09-11 8:41 ` [PATCH v5 03/17] x86/msr: Minimize usage of native_*() msr access functions Juergen Gross
2026-09-11 8:41 ` [PATCH v5 05/17] x86/hyperv: Switch from __rdmsr() to native_rdmsrq() Juergen Gross
@ 2026-09-23 19:36 ` Shreshth Srivastava
2026-09-23 20:15 ` Nick Desaulniers
2026-09-25 10:25 ` Jürgen Groß
2 siblings, 2 replies; 6+ messages in thread
From: Shreshth Srivastava @ 2026-09-23 19:36 UTC (permalink / raw)
To: Juergen Gross, linux-kernel, x86, linux-coco, kvm, linux-hyperv,
virtualization, llvm
Cc: tglx, mingo, bp, dave.hansen, hpa, xin, nathan, ndesaulniers,
jpoimboe, peterz, boris.ostrovsky, xen-devel
On 11.09.26 10:41, Juergen Gross wrote:
> When building a kernel with CONFIG_PARAVIRT_XXL the paravirt
> infrastructure will always use functions for reading or writing MSRs,
> even when running on bare metal.
Hi Juergen,
This doesn't build with CONFIG_PARAVIRT_XXL=y. 16/17 and 17/17 are where
it breaks, but the cause is the .byte fallbacks: ASM_WRMSRNS_IMM from
08/17 and ASM_RDMSR_IMM from 10/17 don't end in a separator, unlike the
.insn variants above them.
#define ASM_RDMSR_IMM \
" .byte 0xc4,0xe7,0x7b,0xf6,0xc0; .long %c[msr]"
That worked while they were only ever the last argument of an
ALTERNATIVE(), which appends its own newline. 16/17 concatenates them
with ASM_CLRERR:
ASM_RDMSR_IMM ASM_CLRERR, X86_FEATURE_MSR_IMM, \
so the .long operand runs into the xor. From
make arch/x86/kernel/cpu/common.s:
.byte 0xc4,0xe7,0x7b,0xf6,0xc0; .long 266xor %rdx,%rdx
paravirt-msr.h:165: Error: junk at end of line, first unrecognized character is `x'
clang reports "error: unexpected token" in the same place. 71 objects
fail, the same 71 either way, no vmlinux.
msr.h chooses between the .insn form and the .byte fallback with:
#if defined(CONFIG_AS_IS_GNU) && CONFIG_AS_VERSION >= 24100
Two kinds of toolchain end up on the .byte side of that test:
- GNU as older than 2.41. RHEL 9 and CentOS Stream 9 ship 2.35, and
Documentation/process/changes.rst sets the minimum at 2.30, so this
is a supported configuration rather than an old outlier.
- clang, any version. CONFIG_AS_IS_GNU is never set for clang, so the
&& short-circuits and the version comparison is never reached. Your
08/17 comment already notes that clang has no .insn support.
gcc with binutils 2.41 or newer takes the .insn path, where both macros
do end in a separator, and is unaffected.
Reproduced on v7.3-rc2 with your v3 00/13, v2 0/5 and v5 00/17 applied in
that order, x86_64 defconfig plus HYPERVISOR_GUEST, PARAVIRT, XEN and
XEN_PV. gcc 11.5.0 with GNU as 2.35.2, and clang 21.1.7.
Terminating both fallbacks fixes it, and both toolchains then build
vmlinux with no errors or warnings:
diff --git a/arch/x86/include/asm/msr.h b/arch/x86/include/asm/msr.h
index eba325ecfe4c..529c13553c63 100644
--- a/arch/x86/include/asm/msr.h
+++ b/arch/x86/include/asm/msr.h
@@ -78,9 +78,9 @@ static inline void do_trace_rdpmc(u32 msr, u64 val, int failed) {}
* form MSR access instructions reference %rax as the register operand.
*/
#define ASM_RDMSR_IMM \
- " .byte 0xc4,0xe7,0x7b,0xf6,0xc0; .long %c[msr]"
+ " .byte 0xc4,0xe7,0x7b,0xf6,0xc0; .long %c[msr]\n\t"
#define ASM_WRMSRNS_IMM \
- " .byte 0xc4,0xe7,0x7a,0xf6,0xc0; .long %c[msr]"
+ " .byte 0xc4,0xe7,0x7a,0xf6,0xc0; .long %c[msr]\n\t"
#endif
#define RDMSR_AND_SAVE_RESULT \
ASM_WRMSRNS needs no change, _ASM_BYTES() already emits a semicolon.
The WRMSRNS line belongs in 08/17 and the RDMSR line in 10/17.
Thanks,
Shreshth
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v5 00/17] x86/msr: Inline rdmsr/wrmsr instructions
2026-09-23 19:36 ` [PATCH v5 00/17] x86/msr: Inline rdmsr/wrmsr instructions Shreshth Srivastava
@ 2026-09-23 20:15 ` Nick Desaulniers
2026-09-25 10:25 ` Jürgen Groß
1 sibling, 0 replies; 6+ messages in thread
From: Nick Desaulniers @ 2026-09-23 20:15 UTC (permalink / raw)
To: Shreshth Srivastava, Juergen Gross
Cc: linux-kernel, x86, linux-coco, kvm, linux-hyperv, virtualization,
llvm, tglx, mingo, bp, dave.hansen, hpa, xin, nathan, jpoimboe,
peterz, boris.ostrovsky, xen-devel
On Wed, Sep 23, 2026 at 12:36 PM Shreshth Srivastava
<shreshth.srivastava@intel.com> wrote:
>
> On 11.09.26 10:41, Juergen Gross wrote:
> > When building a kernel with CONFIG_PARAVIRT_XXL the paravirt
> > infrastructure will always use functions for reading or writing MSRs,
> > even when running on bare metal.
>
> Hi Juergen,
>
> This doesn't build with CONFIG_PARAVIRT_XXL=y. 16/17 and 17/17 are where
> it breaks, but the cause is the .byte fallbacks: ASM_WRMSRNS_IMM from
> 08/17 and ASM_RDMSR_IMM from 10/17 don't end in a separator, unlike the
> .insn variants above them.
>
> #define ASM_RDMSR_IMM \
> " .byte 0xc4,0xe7,0x7b,0xf6,0xc0; .long %c[msr]"
>
> That worked while they were only ever the last argument of an
> ALTERNATIVE(), which appends its own newline. 16/17 concatenates them
> with ASM_CLRERR:
>
> ASM_RDMSR_IMM ASM_CLRERR, X86_FEATURE_MSR_IMM, \
>
> so the .long operand runs into the xor. From
> make arch/x86/kernel/cpu/common.s:
>
> .byte 0xc4,0xe7,0x7b,0xf6,0xc0; .long 266xor %rdx,%rdx
>
> paravirt-msr.h:165: Error: junk at end of line, first unrecognized character is `x'
>
> clang reports "error: unexpected token" in the same place. 71 objects
> fail, the same 71 either way, no vmlinux.
>
> msr.h chooses between the .insn form and the .byte fallback with:
>
> #if defined(CONFIG_AS_IS_GNU) && CONFIG_AS_VERSION >= 24100
>
> Two kinds of toolchain end up on the .byte side of that test:
>
> - GNU as older than 2.41. RHEL 9 and CentOS Stream 9 ship 2.35, and
> Documentation/process/changes.rst sets the minimum at 2.30, so this
> is a supported configuration rather than an old outlier.
> - clang, any version. CONFIG_AS_IS_GNU is never set for clang, so the
> && short-circuits and the version comparison is never reached. Your
> 08/17 comment already notes that clang has no .insn support.
Indeed, looks like we're missing support for .insn for x86.
Filed https://github.com/llvm/llvm-project/issues/225916.
(Please do file bugs against the toolchain when you encounter issues
like this, and cc someone from kernel development).
>
> gcc with binutils 2.41 or newer takes the .insn path, where both macros
> do end in a separator, and is unaffected.
>
> Reproduced on v7.3-rc2 with your v3 00/13, v2 0/5 and v5 00/17 applied in
> that order, x86_64 defconfig plus HYPERVISOR_GUEST, PARAVIRT, XEN and
> XEN_PV. gcc 11.5.0 with GNU as 2.35.2, and clang 21.1.7.
>
> Terminating both fallbacks fixes it, and both toolchains then build
> vmlinux with no errors or warnings:
>
> diff --git a/arch/x86/include/asm/msr.h b/arch/x86/include/asm/msr.h
> index eba325ecfe4c..529c13553c63 100644
> --- a/arch/x86/include/asm/msr.h
> +++ b/arch/x86/include/asm/msr.h
> @@ -78,9 +78,9 @@ static inline void do_trace_rdpmc(u32 msr, u64 val, int failed) {}
> * form MSR access instructions reference %rax as the register operand.
> */
> #define ASM_RDMSR_IMM \
> - " .byte 0xc4,0xe7,0x7b,0xf6,0xc0; .long %c[msr]"
> + " .byte 0xc4,0xe7,0x7b,0xf6,0xc0; .long %c[msr]\n\t"
> #define ASM_WRMSRNS_IMM \
> - " .byte 0xc4,0xe7,0x7a,0xf6,0xc0; .long %c[msr]"
> + " .byte 0xc4,0xe7,0x7a,0xf6,0xc0; .long %c[msr]\n\t"
> #endif
>
> #define RDMSR_AND_SAVE_RESULT \
>
> ASM_WRMSRNS needs no change, _ASM_BYTES() already emits a semicolon.
>
> The WRMSRNS line belongs in 08/17 and the RDMSR line in 10/17.
>
> Thanks,
> Shreshth
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v5 00/17] x86/msr: Inline rdmsr/wrmsr instructions
2026-09-23 19:36 ` [PATCH v5 00/17] x86/msr: Inline rdmsr/wrmsr instructions Shreshth Srivastava
2026-09-23 20:15 ` Nick Desaulniers
@ 2026-09-25 10:25 ` Jürgen Groß
1 sibling, 0 replies; 6+ messages in thread
From: Jürgen Groß @ 2026-09-25 10:25 UTC (permalink / raw)
To: Shreshth Srivastava, linux-kernel, x86, linux-coco, kvm,
linux-hyperv, virtualization, llvm
Cc: tglx, mingo, bp, dave.hansen, hpa, xin, nathan, ndesaulniers,
jpoimboe, peterz, boris.ostrovsky, xen-devel
[-- Attachment #1.1.1: Type: text/plain, Size: 3224 bytes --]
On 23.09.26 21:36, Shreshth Srivastava wrote:
> On 11.09.26 10:41, Juergen Gross wrote:
>> When building a kernel with CONFIG_PARAVIRT_XXL the paravirt
>> infrastructure will always use functions for reading or writing MSRs,
>> even when running on bare metal.
>
> Hi Juergen,
>
> This doesn't build with CONFIG_PARAVIRT_XXL=y. 16/17 and 17/17 are where
> it breaks, but the cause is the .byte fallbacks: ASM_WRMSRNS_IMM from
> 08/17 and ASM_RDMSR_IMM from 10/17 don't end in a separator, unlike the
> .insn variants above them.
>
> #define ASM_RDMSR_IMM \
> " .byte 0xc4,0xe7,0x7b,0xf6,0xc0; .long %c[msr]"
>
> That worked while they were only ever the last argument of an
> ALTERNATIVE(), which appends its own newline. 16/17 concatenates them
> with ASM_CLRERR:
>
> ASM_RDMSR_IMM ASM_CLRERR, X86_FEATURE_MSR_IMM, \
>
> so the .long operand runs into the xor. From
> make arch/x86/kernel/cpu/common.s:
>
> .byte 0xc4,0xe7,0x7b,0xf6,0xc0; .long 266xor %rdx,%rdx
>
> paravirt-msr.h:165: Error: junk at end of line, first unrecognized character is `x'
>
> clang reports "error: unexpected token" in the same place. 71 objects
> fail, the same 71 either way, no vmlinux.
>
> msr.h chooses between the .insn form and the .byte fallback with:
>
> #if defined(CONFIG_AS_IS_GNU) && CONFIG_AS_VERSION >= 24100
>
> Two kinds of toolchain end up on the .byte side of that test:
>
> - GNU as older than 2.41. RHEL 9 and CentOS Stream 9 ship 2.35, and
> Documentation/process/changes.rst sets the minimum at 2.30, so this
> is a supported configuration rather than an old outlier.
> - clang, any version. CONFIG_AS_IS_GNU is never set for clang, so the
> && short-circuits and the version comparison is never reached. Your
> 08/17 comment already notes that clang has no .insn support.
>
> gcc with binutils 2.41 or newer takes the .insn path, where both macros
> do end in a separator, and is unaffected.
>
> Reproduced on v7.3-rc2 with your v3 00/13, v2 0/5 and v5 00/17 applied in
> that order, x86_64 defconfig plus HYPERVISOR_GUEST, PARAVIRT, XEN and
> XEN_PV. gcc 11.5.0 with GNU as 2.35.2, and clang 21.1.7.
>
> Terminating both fallbacks fixes it, and both toolchains then build
> vmlinux with no errors or warnings:
>
> diff --git a/arch/x86/include/asm/msr.h b/arch/x86/include/asm/msr.h
> index eba325ecfe4c..529c13553c63 100644
> --- a/arch/x86/include/asm/msr.h
> +++ b/arch/x86/include/asm/msr.h
> @@ -78,9 +78,9 @@ static inline void do_trace_rdpmc(u32 msr, u64 val, int failed) {}
> * form MSR access instructions reference %rax as the register operand.
> */
> #define ASM_RDMSR_IMM \
> - " .byte 0xc4,0xe7,0x7b,0xf6,0xc0; .long %c[msr]"
> + " .byte 0xc4,0xe7,0x7b,0xf6,0xc0; .long %c[msr]\n\t"
> #define ASM_WRMSRNS_IMM \
> - " .byte 0xc4,0xe7,0x7a,0xf6,0xc0; .long %c[msr]"
> + " .byte 0xc4,0xe7,0x7a,0xf6,0xc0; .long %c[msr]\n\t"
> #endif
>
> #define RDMSR_AND_SAVE_RESULT \
>
> ASM_WRMSRNS needs no change, _ASM_BYTES() already emits a semicolon.
>
> The WRMSRNS line belongs in 08/17 and the RDMSR line in 10/17.
Thanks, will be fixed in V6.
Juergen
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3743 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread