From: Javier Martinez Canillas <javierm@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
louis.chauvet@bootlin.com, drawat.floss@gmail.com,
hamohammed.sa@gmail.com, melissa.srw@gmail.com,
mhklinux@outlook.com, simona@ffwll.ch, airlied@gmail.com,
maarten.lankhorst@linux.intel.com
Cc: dri-devel@lists.freedesktop.org, linux-hyperv@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [PATCH v2 2/4] drm/vblank: Add CRTC helpers for simple use cases
Date: Tue, 02 Sep 2025 10:14:22 +0200 [thread overview]
Message-ID: <87frd5fezl.fsf@minerva.mail-host-address-is-not-set> (raw)
In-Reply-To: <20250901111241.233875-3-tzimmermann@suse.de>
Thomas Zimmermann <tzimmermann@suse.de> writes:
> Implement atomic_flush, atomic_enable and atomic_disable of struct
> drm_crtc_helper_funcs for vblank handling. Driver with no further
> requirements can use these functions instead of adding their own.
> Also simplifies the use of vblank timers.
>
> v2:
> - fix docs
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
You could mention (as you do for the first patch) that the helpers' code
have been adopted from vkms. Since the CRTC enable/disable callbacks are
the same and the flush is mostly the same (minus the vkms specific bits
that touches the struct vkms_output).
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
next prev parent reply other threads:[~2025-09-02 8:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-01 11:06 [PATCH v2 0/4] drm: Add vblank timers for devices without interrupts Thomas Zimmermann
2025-09-01 11:06 ` [PATCH v2 1/4] drm/vblank: Add vblank timer Thomas Zimmermann
2025-09-02 8:09 ` Javier Martinez Canillas
2025-09-02 13:27 ` Ville Syrjälä
2025-09-02 14:16 ` Thomas Zimmermann
2025-09-02 15:58 ` Lyude Paul
2025-09-04 14:21 ` Thomas Zimmermann
2025-09-01 11:06 ` [PATCH v2 2/4] drm/vblank: Add CRTC helpers for simple use cases Thomas Zimmermann
2025-09-02 8:14 ` Javier Martinez Canillas [this message]
2025-09-01 11:07 ` [PATCH v2 3/4] drm/vkms: Convert to DRM's vblank timer Thomas Zimmermann
2025-09-02 8:15 ` Javier Martinez Canillas
2025-09-01 11:07 ` [PATCH v2 4/4] drm/hypervdrm: Use " Thomas Zimmermann
2025-09-02 8:30 ` Javier Martinez Canillas
2025-09-02 12:58 ` Thomas Zimmermann
2025-09-02 15:41 ` Javier Martinez Canillas
2025-09-04 3:38 ` Michael Kelley
2025-09-04 5:50 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87frd5fezl.fsf@minerva.mail-host-address-is-not-set \
--to=javierm@redhat.com \
--cc=airlied@gmail.com \
--cc=drawat.floss@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamohammed.sa@gmail.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=louis.chauvet@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=melissa.srw@gmail.com \
--cc=mhklinux@outlook.com \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox