* [PATCH] Drivers: hv: vmbus: Remove unnecessary (void*) conversions
@ 2023-04-19 8:03 Suhui
2023-04-20 21:59 ` Wei Liu
0 siblings, 1 reply; 2+ messages in thread
From: Suhui @ 2023-04-19 8:03 UTC (permalink / raw)
To: K . Y . Srinivasa, Haiyang Zhang, Wei Liu, Dexuan Cui
Cc: linux-hyperv, linux-kernel, Suhui
No need cast (void*) to (struct hv_ring_buffer *).
Signed-off-by: Suhui <suhui@nfschina.com>
---
drivers/hv/ring_buffer.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/hv/ring_buffer.c b/drivers/hv/ring_buffer.c
index c6692fd5ab15..5471321169e9 100644
--- a/drivers/hv/ring_buffer.c
+++ b/drivers/hv/ring_buffer.c
@@ -209,9 +209,8 @@ int hv_ringbuffer_init(struct hv_ring_buffer_info *ring_info,
for (i = 0; i < 2 * (page_cnt - 1); i++)
pfns_wraparound[i + 1] = pfn + i % (page_cnt - 1) + 1;
- ring_info->ring_buffer = (struct hv_ring_buffer *)
- vmap_pfn(pfns_wraparound, page_cnt * 2 - 1,
- PAGE_KERNEL);
+ ring_info->ring_buffer = vmap_pfn(pfns_wraparound, page_cnt * 2 - 1,
+ PAGE_KERNEL);
kfree(pfns_wraparound);
if (!ring_info->ring_buffer)
@@ -231,9 +230,8 @@ int hv_ringbuffer_init(struct hv_ring_buffer_info *ring_info,
pages_wraparound[i + 1] =
&pages[i % (page_cnt - 1) + 1];
- ring_info->ring_buffer = (struct hv_ring_buffer *)
- vmap(pages_wraparound, page_cnt * 2 - 1, VM_MAP,
- PAGE_KERNEL);
+ ring_info->ring_buffer = vmap(pages_wraparound, page_cnt * 2 - 1, VM_MAP,
+ PAGE_KERNEL);
kfree(pages_wraparound);
if (!ring_info->ring_buffer)
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Drivers: hv: vmbus: Remove unnecessary (void*) conversions
2023-04-19 8:03 [PATCH] Drivers: hv: vmbus: Remove unnecessary (void*) conversions Suhui
@ 2023-04-20 21:59 ` Wei Liu
0 siblings, 0 replies; 2+ messages in thread
From: Wei Liu @ 2023-04-20 21:59 UTC (permalink / raw)
To: Suhui
Cc: K . Y . Srinivasa, Haiyang Zhang, Wei Liu, Dexuan Cui,
linux-hyperv, linux-kernel
On Wed, Apr 19, 2023 at 04:03:31PM +0800, Suhui wrote:
> No need cast (void*) to (struct hv_ring_buffer *).
>
> Signed-off-by: Suhui <suhui@nfschina.com>
Unfortunately due to recent changes this patch no longer applies to
hyperv-next.
> ---
> drivers/hv/ring_buffer.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/hv/ring_buffer.c b/drivers/hv/ring_buffer.c
> index c6692fd5ab15..5471321169e9 100644
> --- a/drivers/hv/ring_buffer.c
> +++ b/drivers/hv/ring_buffer.c
> @@ -209,9 +209,8 @@ int hv_ringbuffer_init(struct hv_ring_buffer_info *ring_info,
> for (i = 0; i < 2 * (page_cnt - 1); i++)
> pfns_wraparound[i + 1] = pfn + i % (page_cnt - 1) + 1;
>
> - ring_info->ring_buffer = (struct hv_ring_buffer *)
> - vmap_pfn(pfns_wraparound, page_cnt * 2 - 1,
> - PAGE_KERNEL);
> + ring_info->ring_buffer = vmap_pfn(pfns_wraparound, page_cnt * 2 - 1,
> + PAGE_KERNEL);
> kfree(pfns_wraparound);
>
> if (!ring_info->ring_buffer)
> @@ -231,9 +230,8 @@ int hv_ringbuffer_init(struct hv_ring_buffer_info *ring_info,
> pages_wraparound[i + 1] =
> &pages[i % (page_cnt - 1) + 1];
>
> - ring_info->ring_buffer = (struct hv_ring_buffer *)
> - vmap(pages_wraparound, page_cnt * 2 - 1, VM_MAP,
> - PAGE_KERNEL);
> + ring_info->ring_buffer = vmap(pages_wraparound, page_cnt * 2 - 1, VM_MAP,
> + PAGE_KERNEL);
>
> kfree(pages_wraparound);
> if (!ring_info->ring_buffer)
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-04-20 21:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-19 8:03 [PATCH] Drivers: hv: vmbus: Remove unnecessary (void*) conversions Suhui
2023-04-20 21:59 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox