* [PATCH] clocksource: Fix warnings in mshyperv.h [not found] <tencent_7A4BAF2CDEE6AC56AB5ABBCE9CA1C2FE5205@qq.com> @ 2023-07-12 11:23 ` huzhi001 2023-07-12 21:06 ` Michael Kelley (LINUX) 0 siblings, 1 reply; 3+ messages in thread From: huzhi001 @ 2023-07-12 11:23 UTC (permalink / raw) To: mingo, bp, dave.hansen, x86, tglx, kys, haiyangz, wei.liu, decui Cc: hpa, linux-hyperv, linux-kernel The following checkpatch warnings are removed: WARNING: Use #include <linux/io.h> instead of <asm/io.h> Signed-off-by: ZhiHu <huzhi001@208suo.com> --- arch/x86/include/asm/mshyperv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h index 88d9ef98e087..fa83d88e4c99 100644 --- a/arch/x86/include/asm/mshyperv.h +++ b/arch/x86/include/asm/mshyperv.h @@ -5,7 +5,7 @@ #include <linux/types.h> #include <linux/nmi.h> #include <linux/msi.h> -#include <asm/io.h> +#include <linux/io.h> #include <asm/hyperv-tlfs.h> #include <asm/nospec-branch.h> #include <asm/paravirt.h> ^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] clocksource: Fix warnings in mshyperv.h 2023-07-12 11:23 ` [PATCH] clocksource: Fix warnings in mshyperv.h huzhi001 @ 2023-07-12 21:06 ` Michael Kelley (LINUX) 2023-07-23 23:15 ` Wei Liu 0 siblings, 1 reply; 3+ messages in thread From: Michael Kelley (LINUX) @ 2023-07-12 21:06 UTC (permalink / raw) To: huzhi001@208suo.com, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, tglx@linutronix.de, KY Srinivasan, Haiyang Zhang, wei.liu@kernel.org, Dexuan Cui Cc: hpa@zytor.com, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org From: huzhi001@208suo.com <huzhi001@208suo.com> Sent: Wednesday, July 12, 2023 4:23 AM > > The following checkpatch warnings are removed: > WARNING: Use #include <linux/io.h> instead of <asm/io.h> The "Subject:" of the patch should probably start with "x86/hyperv", not "clocksource". Usually I look back at the commit history of a particular file and try to be consistent with the Subject: prefix that has been used in the past. "x86/hyperv" is typical for this include file. Other than that, Reviewed-by: Michael Kelley <mikelley@microsoft.com> > > Signed-off-by: ZhiHu <huzhi001@208suo.com> > --- > arch/x86/include/asm/mshyperv.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/include/asm/mshyperv.h > b/arch/x86/include/asm/mshyperv.h > index 88d9ef98e087..fa83d88e4c99 100644 > --- a/arch/x86/include/asm/mshyperv.h > +++ b/arch/x86/include/asm/mshyperv.h > @@ -5,7 +5,7 @@ > #include <linux/types.h> > #include <linux/nmi.h> > #include <linux/msi.h> > -#include <asm/io.h> > +#include <linux/io.h> > #include <asm/hyperv-tlfs.h> > #include <asm/nospec-branch.h> > #include <asm/paravirt.h> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clocksource: Fix warnings in mshyperv.h 2023-07-12 21:06 ` Michael Kelley (LINUX) @ 2023-07-23 23:15 ` Wei Liu 0 siblings, 0 replies; 3+ messages in thread From: Wei Liu @ 2023-07-23 23:15 UTC (permalink / raw) To: Michael Kelley (LINUX) Cc: huzhi001@208suo.com, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, tglx@linutronix.de, KY Srinivasan, Haiyang Zhang, wei.liu@kernel.org, Dexuan Cui, hpa@zytor.com, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, Jul 12, 2023 at 09:06:30PM +0000, Michael Kelley (LINUX) wrote: > From: huzhi001@208suo.com <huzhi001@208suo.com> Sent: Wednesday, July 12, 2023 4:23 AM > > > > The following checkpatch warnings are removed: > > WARNING: Use #include <linux/io.h> instead of <asm/io.h> > > The "Subject:" of the patch should probably start with "x86/hyperv", > not "clocksource". Usually I look back at the commit history of a > particular file and try to be consistent with the Subject: prefix that > has been used in the past. "x86/hyperv" is typical for this > include file. > > Other than that, > > Reviewed-by: Michael Kelley <mikelley@microsoft.com> There is only one warning fixed. I changed the subject line and commit message. Applied to hyperv-fixes. Thanks. > > > > Signed-off-by: ZhiHu <huzhi001@208suo.com> > > --- > > arch/x86/include/asm/mshyperv.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/x86/include/asm/mshyperv.h > > b/arch/x86/include/asm/mshyperv.h > > index 88d9ef98e087..fa83d88e4c99 100644 > > --- a/arch/x86/include/asm/mshyperv.h > > +++ b/arch/x86/include/asm/mshyperv.h > > @@ -5,7 +5,7 @@ > > #include <linux/types.h> > > #include <linux/nmi.h> > > #include <linux/msi.h> > > -#include <asm/io.h> > > +#include <linux/io.h> > > #include <asm/hyperv-tlfs.h> > > #include <asm/nospec-branch.h> > > #include <asm/paravirt.h> ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-23 23:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <tencent_7A4BAF2CDEE6AC56AB5ABBCE9CA1C2FE5205@qq.com>
2023-07-12 11:23 ` [PATCH] clocksource: Fix warnings in mshyperv.h huzhi001
2023-07-12 21:06 ` Michael Kelley (LINUX)
2023-07-23 23:15 ` Wei Liu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox