Linux-HyperV List
 help / color / mirror / Atom feed
* [PATCH 12/13] PCI: hv: Convert to pci_assign_unassigned_bus_resources()
       [not found] <20261116152403.2672-1-ilpo.jarvinen@linux.intel.com>
@ 2026-11-16 15:23 ` Ilpo Järvinen
  2026-11-18 19:07   ` Michael Kelley
  0 siblings, 1 reply; 3+ messages in thread
From: Ilpo Järvinen @ 2026-11-16 15:23 UTC (permalink / raw)
  To: linux-pci, Bjorn Helgaas, Lorenzo Pieralisi, Rob Herring,
	Krzysztof Wilczyński, Haiyang Zhang, Wei Liu, Dexuan Cui,
	Lorenzo Pieralisi, Krzysztof Wilczyński,
	Manivannan Sadhasivam, linux-hyperv, linux-kernel
  Cc: Ilpo Järvinen

The pci-hyperv driver scans the bus and assigns resources using
pci_bus_assign_resources(). That function makes bridge window sizing
disjoint from the assignment phase and is going to be removed.

Convert pci_bus_assign_resources() to
pci_assign_unassigned_bus_resources(). If no other bridges are involved,
the extra sizing should be no-op.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
 drivers/pci/controller/pci-hyperv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
index 824cf27e85e6..8eff3e9b325f 100644
--- a/drivers/pci/controller/pci-hyperv.c
+++ b/drivers/pci/controller/pci-hyperv.c
@@ -2549,7 +2549,7 @@ static int create_root_hv_pci_bus(struct hv_pcibus_device *hbus)
 
 	pci_lock_rescan_remove();
 	hv_pci_assign_numa_node(hbus);
-	pci_bus_assign_resources(bridge->bus);
+	pci_assign_unassigned_bus_resources(bridge->bus);
 	hv_pci_assign_slots(hbus);
 	pci_bus_add_devices(bridge->bus);
 	pci_unlock_rescan_remove();
-- 
2.47.3


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [PATCH 12/13] PCI: hv: Convert to pci_assign_unassigned_bus_resources()
  2026-11-16 15:23 ` [PATCH 12/13] PCI: hv: Convert to pci_assign_unassigned_bus_resources() Ilpo Järvinen
@ 2026-11-18 19:07   ` Michael Kelley
  2026-11-20 12:55     ` Ilpo Järvinen
  0 siblings, 1 reply; 3+ messages in thread
From: Michael Kelley @ 2026-11-18 19:07 UTC (permalink / raw)
  To: Ilpo Järvinen, linux-pci@vger.kernel.org, Bjorn Helgaas,
	Lorenzo Pieralisi, Rob Herring, Krzysztof Wilczyński,
	Haiyang Zhang, Wei Liu, Dexuan Cui, Lorenzo Pieralisi,
	Krzysztof Wilczyński, Manivannan Sadhasivam,
	linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org

From: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Sent: Monday, November 16, 2026 7:24 AM
> 
> The pci-hyperv driver scans the bus and assigns resources using
> pci_bus_assign_resources(). That function makes bridge window sizing
> disjoint from the assignment phase and is going to be removed.
> 
> Convert pci_bus_assign_resources() to
> pci_assign_unassigned_bus_resources(). If no other bridges are involved,
> the extra sizing should be no-op.

I tested this series on an x86 VM in the Azure public cloud that has
5 NVMe devices and a Mellanox VF NIC. All 6 devices are PCI pass-thru
devices in the VM that are initially set up using the pci-hyperv.c driver,
so each device has its own root bus and bridge. No issues were seen in
a basic smoke test.

I added some debug code to pci_assign_unassigned_bus_resources(),
and indeed the "for_each_pci_bridge()" loop found nothing as each
device was setup. So __pci_bus_assign_resources() was called with an
empty add_list, and as expected, the new execution path is equivalent
to the old pci_bus_assign_resources() call.

Question: Your cover letter says drivers that call pci_assign_resources()
directly are not covered by this series. pci-hyperv.c *does* call
pci_assign_resources() directly in hv_pci_allocate_bridge_windows().
Is that a problem? I don't understand all the details of the PCI resource
assignment well enough to judge for myself. :-(

In any case,

Tested-by: Michael Kelley <mhklinux@outlook.com>

And at least to some degree,

Reviewed-by: Michael Kelley <mhklinux@outlook.com>

> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
>  drivers/pci/controller/pci-hyperv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
> index 824cf27e85e6..8eff3e9b325f 100644
> --- a/drivers/pci/controller/pci-hyperv.c
> +++ b/drivers/pci/controller/pci-hyperv.c
> @@ -2549,7 +2549,7 @@ static int create_root_hv_pci_bus(struct hv_pcibus_device *hbus)
> 
>  	pci_lock_rescan_remove();
>  	hv_pci_assign_numa_node(hbus);
> -	pci_bus_assign_resources(bridge->bus);
> +	pci_assign_unassigned_bus_resources(bridge->bus);
>  	hv_pci_assign_slots(hbus);
>  	pci_bus_add_devices(bridge->bus);
>  	pci_unlock_rescan_remove();
> --
> 2.47.3
> 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH 12/13] PCI: hv: Convert to pci_assign_unassigned_bus_resources()
  2026-11-18 19:07   ` Michael Kelley
@ 2026-11-20 12:55     ` Ilpo Järvinen
  0 siblings, 0 replies; 3+ messages in thread
From: Ilpo Järvinen @ 2026-11-20 12:55 UTC (permalink / raw)
  To: Michael Kelley
  Cc: linux-pci@vger.kernel.org, Bjorn Helgaas, Lorenzo Pieralisi,
	Rob Herring, Krzysztof Wilczyński, Haiyang Zhang, Wei Liu,
	Dexuan Cui, Lorenzo Pieralisi, Krzysztof Wilczyński,
	Manivannan Sadhasivam, linux-hyperv@vger.kernel.org,
	linux-kernel@vger.kernel.org

[-- Attachment #1: Type: text/plain, Size: 3672 bytes --]

On Wed, 18 Nov 2026, Michael Kelley wrote:

> From: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Sent: Monday, November 16, 2026 7:24 AM
> > 
> > The pci-hyperv driver scans the bus and assigns resources using
> > pci_bus_assign_resources(). That function makes bridge window sizing
> > disjoint from the assignment phase and is going to be removed.
> > 
> > Convert pci_bus_assign_resources() to
> > pci_assign_unassigned_bus_resources(). If no other bridges are involved,
> > the extra sizing should be no-op.
> 
> I tested this series on an x86 VM in the Azure public cloud that has
> 5 NVMe devices and a Mellanox VF NIC. All 6 devices are PCI pass-thru
> devices in the VM that are initially set up using the pci-hyperv.c driver,
> so each device has its own root bus and bridge. No issues were seen in
> a basic smoke test.
> 
> I added some debug code to pci_assign_unassigned_bus_resources(),
> and indeed the "for_each_pci_bridge()" loop found nothing as each
> device was setup. So __pci_bus_assign_resources() was called with an
> empty add_list, and as expected, the new execution path is equivalent
> to the old pci_bus_assign_resources() call.
> 
> Question: Your cover letter says drivers that call pci_assign_resources()
> directly are not covered by this series. pci-hyperv.c *does* call
> pci_assign_resources() directly in hv_pci_allocate_bridge_windows().
> Is that a problem? I don't understand all the details of the PCI resource
> assignment well enough to judge for myself. :-(

There's a small name mixup here.

pci_assign_resources() is to graft a device's resource (or a window) into 
resource tree, whereas that calls pci_add_resource() adding windows to the 
root bus and that seems to occur before there is anything underneath. At 
this point, there's nothing to do for the resource fitting and assignment 
algorithm (it iterates the devices underneath).

...So I don't see a race here related to pci_assign_resources().

Most entrypoints of the fitting and assignment algorith input bus, and I 
don't think anything in kernel would as to assign resources underneath 
that root bus. Only pci_assign_unassigned_resources() looks for all root 
buses, and that is only called from arch init code so I don't think vfio 
setting up it host bridges matters with that call.

There seems to be, in general (not just hyperv), some races that are 
unrelated to resource setup in host bridge setup and scanning. I'll see 
what I can do but it'll be in a separate series and those seems to fall 
under can-shoot-oneself's-own-foot category.

Thanks for taking a look.

-- 
 i.

> In any case,
> 
> Tested-by: Michael Kelley <mhklinux@outlook.com>
> 
> And at least to some degree,
> 
> Reviewed-by: Michael Kelley <mhklinux@outlook.com>
> 
> > 
> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > ---
> >  drivers/pci/controller/pci-hyperv.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c
> > index 824cf27e85e6..8eff3e9b325f 100644
> > --- a/drivers/pci/controller/pci-hyperv.c
> > +++ b/drivers/pci/controller/pci-hyperv.c
> > @@ -2549,7 +2549,7 @@ static int create_root_hv_pci_bus(struct hv_pcibus_device *hbus)
> > 
> >  	pci_lock_rescan_remove();
> >  	hv_pci_assign_numa_node(hbus);
> > -	pci_bus_assign_resources(bridge->bus);
> > +	pci_assign_unassigned_bus_resources(bridge->bus);
> >  	hv_pci_assign_slots(hbus);
> >  	pci_bus_add_devices(bridge->bus);
> >  	pci_unlock_rescan_remove();
> > --
> > 2.47.3
> > 
> 
> 

-- 
 i.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-11-20 12:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20261116152403.2672-1-ilpo.jarvinen@linux.intel.com>
2026-11-16 15:23 ` [PATCH 12/13] PCI: hv: Convert to pci_assign_unassigned_bus_resources() Ilpo Järvinen
2026-11-18 19:07   ` Michael Kelley
2026-11-20 12:55     ` Ilpo Järvinen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox