* [PATCH V2] i2c: ocores: Make of_device_id array const
@ 2014-05-14 23:17 Jingoo Han
[not found] ` <005801cf6fca$af7fd0e0$0e7f72a0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Jingoo Han @ 2014-05-14 23:17 UTC (permalink / raw)
To: 'Wolfram Sang'
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, 'Peter Korsgaard',
'Maxime COQUELIN', 'Jingoo Han'
Make of_device_id array const, because all OF functions
handle it as const.
Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Acked-by: Peter Korsgaard <peter-+2lRwdCCLRT2eFz/2MeuCQ@public.gmane.org>
Acked-by: Maxime Coquelin <maxime.coquelin-qxv4g6HH51o@public.gmane.org>
---
Changes since v1:
- squashed all patches into a single patch
- added acked-by
drivers/i2c/busses/i2c-ocores.c | 2 +-
drivers/i2c/busses/i2c-pxa.c | 2 +-
drivers/i2c/busses/i2c-riic.c | 2 +-
drivers/i2c/busses/i2c-st.c | 2 +-
drivers/i2c/busses/i2c-wmt.c | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c
index 1f6369f..0e10cc6 100644
--- a/drivers/i2c/busses/i2c-ocores.c
+++ b/drivers/i2c/busses/i2c-ocores.c
@@ -250,7 +250,7 @@ static struct i2c_adapter ocores_adapter = {
.algo = &ocores_algorithm,
};
-static struct of_device_id ocores_i2c_match[] = {
+static const struct of_device_id ocores_i2c_match[] = {
{
.compatible = "opencores,i2c-ocores",
.data = (void *)TYPE_OCORES,
diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
index bbe6dfb..be671f7 100644
--- a/drivers/i2c/busses/i2c-pxa.c
+++ b/drivers/i2c/busses/i2c-pxa.c
@@ -1084,7 +1084,7 @@ static const struct i2c_algorithm i2c_pxa_pio_algorithm = {
.functionality = i2c_pxa_functionality,
};
-static struct of_device_id i2c_pxa_dt_ids[] = {
+static const struct of_device_id i2c_pxa_dt_ids[] = {
{ .compatible = "mrvl,pxa-i2c", .data = (void *)REGS_PXA2XX },
{ .compatible = "mrvl,pwri2c", .data = (void *)REGS_PXA3XX },
{ .compatible = "mrvl,mmp-twsi", .data = (void *)REGS_PXA2XX },
diff --git a/drivers/i2c/busses/i2c-riic.c b/drivers/i2c/busses/i2c-riic.c
index 9e1f8ba..af3b3d0 100644
--- a/drivers/i2c/busses/i2c-riic.c
+++ b/drivers/i2c/busses/i2c-riic.c
@@ -404,7 +404,7 @@ static int riic_i2c_remove(struct platform_device *pdev)
return 0;
}
-static struct of_device_id riic_i2c_dt_ids[] = {
+static const struct of_device_id riic_i2c_dt_ids[] = {
{ .compatible = "renesas,riic-rz" },
{ /* Sentinel */ },
};
diff --git a/drivers/i2c/busses/i2c-st.c b/drivers/i2c/busses/i2c-st.c
index 8720161..95b94767 100644
--- a/drivers/i2c/busses/i2c-st.c
+++ b/drivers/i2c/busses/i2c-st.c
@@ -847,7 +847,7 @@ static int st_i2c_remove(struct platform_device *pdev)
return 0;
}
-static struct of_device_id st_i2c_match[] = {
+static const struct of_device_id st_i2c_match[] = {
{ .compatible = "st,comms-ssc-i2c", },
{ .compatible = "st,comms-ssc4-i2c", },
{},
diff --git a/drivers/i2c/busses/i2c-wmt.c b/drivers/i2c/busses/i2c-wmt.c
index 2c8a3e4..924b501 100644
--- a/drivers/i2c/busses/i2c-wmt.c
+++ b/drivers/i2c/busses/i2c-wmt.c
@@ -454,7 +454,7 @@ static int wmt_i2c_remove(struct platform_device *pdev)
return 0;
}
-static struct of_device_id wmt_i2c_dt_ids[] = {
+static const struct of_device_id wmt_i2c_dt_ids[] = {
{ .compatible = "wm,wm8505-i2c" },
{ /* Sentinel */ },
};
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V2] i2c: ocores: Make of_device_id array const
[not found] ` <005801cf6fca$af7fd0e0$0e7f72a0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
@ 2014-05-15 6:35 ` Peter Korsgaard
[not found] ` <87lhu3tuq1.fsf-D6SC8u56vOOJDPpyT6T3/w@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Peter Korsgaard @ 2014-05-15 6:35 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Wolfram Sang', linux-i2c-u79uwXL29TY76Z2rM5mHXA,
'Maxime COQUELIN'
>>>>> "Jingoo" == Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> writes:
You seem to have forgotten to change subject, but I guess Wolfram can
fix that when committing (E.G. s/ocores/busses/).
> Make of_device_id array const, because all OF functions
> handle it as const.
> Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Acked-by: Peter Korsgaard <peter-+2lRwdCCLRT2eFz/2MeuCQ@public.gmane.org>
> Acked-by: Maxime Coquelin <maxime.coquelin-qxv4g6HH51o@public.gmane.org>
> ---
> Changes since v1:
> - squashed all patches into a single patch
> - added acked-by
--
By, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V2] i2c: ocores: Make of_device_id array const
[not found] ` <87lhu3tuq1.fsf-D6SC8u56vOOJDPpyT6T3/w@public.gmane.org>
@ 2014-05-15 6:43 ` Jingoo Han
0 siblings, 0 replies; 3+ messages in thread
From: Jingoo Han @ 2014-05-15 6:43 UTC (permalink / raw)
To: 'Peter Korsgaard'
Cc: 'Wolfram Sang', linux-i2c-u79uwXL29TY76Z2rM5mHXA,
'Maxime COQUELIN', 'Jingoo Han'
On Thursday, May 15, 2014 3:36 PM, Peter Korsgaard wrote:
>
> >>>>> "Jingoo" == Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> writes:
>
> You seem to have forgotten to change subject, but I guess Wolfram can
> fix that when committing (E.G. s/ocores/busses/).
Oh, it's my mistake! I will fix the subject and send
v3 patch, soon. Thank you for your notification. :-)
Best regards,
Jingoo Han
>
> > Make of_device_id array const, because all OF functions
> > handle it as const.
>
> > Signed-off-by: Jingoo Han <jg1.han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> > Acked-by: Peter Korsgaard <peter-+2lRwdCCLRT2eFz/2MeuCQ@public.gmane.org>
> > Acked-by: Maxime Coquelin <maxime.coquelin-qxv4g6HH51o@public.gmane.org>
> > ---
> > Changes since v1:
> > - squashed all patches into a single patch
> > - added acked-by
>
> --
> By, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-15 6:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-05-14 23:17 [PATCH V2] i2c: ocores: Make of_device_id array const Jingoo Han
[not found] ` <005801cf6fca$af7fd0e0$0e7f72a0$%han-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-05-15 6:35 ` Peter Korsgaard
[not found] ` <87lhu3tuq1.fsf-D6SC8u56vOOJDPpyT6T3/w@public.gmane.org>
2014-05-15 6:43 ` Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox