public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Sergey Shtylyov <s.shtylyov@omp.ru>
To: <linux-i2c@vger.kernel.org>, Ard Biesheuvel <ardb@kernel.org>
Subject: [PATCH v3 1/2] i2c: iop3xx: fix deferred probing
Date: Thu, 12 Aug 2021 23:35:09 +0300	[thread overview]
Message-ID: <006975c5-df00-de6f-c553-0b967ae23b89@omp.ru> (raw)
In-Reply-To: <07588701-4f82-2390-8781-5e6965e87eb4@omp.ru>

When adding the code to handle platform_get_irq*() errors in the commit
489447380a29 ("[PATCH] handle errors returned by platform_get_irq*()"),
the actual error code was enforced to be -ENXIO in the driver for some
strange reason.  This didn't matter much until the deferred probing was
introduced -- which requires an actual error code to be propagated
upstream from the failure site.

While fixing this, also stop overriding the errors from request_irq() to
-EIO (done since the pre-git era).

Fixes: 489447380a29 ("[PATCH] handle errors returned by platform_get_irq*()")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>

---
Changed in version 2:
- refreshed the patch.

Changed in version 2:
- added an article and a space to the patch description;
- updated domain in the OMP email addresses.

 drivers/i2c/busses/i2c-iop3xx.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Index: linux/drivers/i2c/busses/i2c-iop3xx.c
===================================================================
--- linux.orig/drivers/i2c/busses/i2c-iop3xx.c
+++ linux/drivers/i2c/busses/i2c-iop3xx.c
@@ -467,16 +467,14 @@ iop3xx_i2c_probe(struct platform_device
 
 	irq = platform_get_irq(pdev, 0);
 	if (irq < 0) {
-		ret = -ENXIO;
+		ret = irq;
 		goto unmap;
 	}
 	ret = request_irq(irq, iop3xx_i2c_irq_handler, 0,
 				pdev->name, adapter_data);
 
-	if (ret) {
-		ret = -EIO;
+	if (ret)
 		goto unmap;
-	}
 
 	memcpy(new_adapter->name, pdev->name, strlen(pdev->name));
 	new_adapter->owner = THIS_MODULE;

  parent reply	other threads:[~2021-08-12 20:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-12 20:32 [PATCH v2 0/3] Fix deferred probing in the I2C bus drivers Sergey Shtylyov
2021-08-12 20:33 ` Sergey Shtylyov
2021-08-12 20:35 ` Sergey Shtylyov [this message]
2021-08-17 19:45   ` [PATCH v3 1/2] i2c: iop3xx: fix deferred probing Wolfram Sang
2021-08-12 20:39 ` [PATCH v2 2/2] i2c: synquacer: " Sergey Shtylyov
2021-08-16  9:29   ` Ard Biesheuvel
2021-08-17 19:42   ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=006975c5-df00-de6f-c553-0b967ae23b89@omp.ru \
    --to=s.shtylyov@omp.ru \
    --cc=ardb@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox