From: Wolfram Sang <wsa@kernel.org>
To: Sergey Shtylyov <s.shtylyov@omp.ru>
Cc: linux-i2c@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH v3 1/2] i2c: iop3xx: fix deferred probing
Date: Tue, 17 Aug 2021 21:45:14 +0200 [thread overview]
Message-ID: <YRwRyiSrZtZ7Y8Yj@kunai> (raw)
In-Reply-To: <006975c5-df00-de6f-c553-0b967ae23b89@omp.ru>
[-- Attachment #1: Type: text/plain, Size: 765 bytes --]
On Thu, Aug 12, 2021 at 11:35:09PM +0300, Sergey Shtylyov wrote:
> When adding the code to handle platform_get_irq*() errors in the commit
> 489447380a29 ("[PATCH] handle errors returned by platform_get_irq*()"),
> the actual error code was enforced to be -ENXIO in the driver for some
> strange reason. This didn't matter much until the deferred probing was
> introduced -- which requires an actual error code to be propagated
> upstream from the failure site.
>
> While fixing this, also stop overriding the errors from request_irq() to
> -EIO (done since the pre-git era).
>
> Fixes: 489447380a29 ("[PATCH] handle errors returned by platform_get_irq*()")
> Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-08-17 19:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 20:32 [PATCH v2 0/3] Fix deferred probing in the I2C bus drivers Sergey Shtylyov
2021-08-12 20:33 ` Sergey Shtylyov
2021-08-12 20:35 ` [PATCH v3 1/2] i2c: iop3xx: fix deferred probing Sergey Shtylyov
2021-08-17 19:45 ` Wolfram Sang [this message]
2021-08-12 20:39 ` [PATCH v2 2/2] i2c: synquacer: " Sergey Shtylyov
2021-08-16 9:29 ` Ard Biesheuvel
2021-08-17 19:42 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YRwRyiSrZtZ7Y8Yj@kunai \
--to=wsa@kernel.org \
--cc=ardb@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox