From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jie Li <lj29312931@gmail.com>, wsa@kernel.org
Cc: linux-i2c@vger.kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, devicetree@vger.kernel.org,
linus.walleij@linaro.org, linux-kernel@vger.kernel.org,
Jie Li <jie.i.li@nokia.com>
Subject: Re: [PATCH v1 2/2] dt-bindings: i2c: add force-set-sda property
Date: Fri, 16 Jan 2026 15:14:06 +0100 [thread overview]
Message-ID: <06b1a681-4190-4552-a092-22dbdecf561c@kernel.org> (raw)
In-Reply-To: <20260114141352.103425-3-jie.i.li@nokia.com>
On 14/01/2026 15:13, Jie Li wrote:
> Document the new "force-set-sda" optional property.
> This property is used for hardware where the SDA line is open-drain
> but the standard driver-level check (like gpiod_get_direction) might
> not correctly reflect the ability to drive the line for bus recovery.
I think Linus explained well why this does not fit DT, so also formally
responding here - use proper GPIO flags, when SDA is open-drain.
>
> Signed-off-by: Jie Li <jie.i.li@nokia.com>
This does not match From address. You need to always check your patches
with checkpatch.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-16 14:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 14:13 [PATCH v1 0/2] i2c: add support for forced SDA recovery Jie Li
2026-01-14 14:13 ` [PATCH v1 1/2] i2c: core: add "force-set-sda" flag for open-drain SDA without "FLAG_IS_OUT" bit Jie Li
2026-01-14 14:13 ` [PATCH v1 2/2] dt-bindings: i2c: add force-set-sda property Jie Li
2026-01-16 14:14 ` Krzysztof Kozlowski [this message]
2026-01-15 9:27 ` [PATCH v1 0/2] i2c: add support for forced SDA recovery Linus Walleij
2026-01-15 13:12 ` 李杰
2026-01-16 13:59 ` Linus Walleij
2026-01-25 19:51 ` [PATCH v2 0/2] i2c: improve bus recovery for single-ended GPIOs Jie Li
2026-01-25 19:51 ` [PATCH v2 1/2] gpiolib: add gpiod_is_single_ended() helper Jie Li
2026-01-27 9:46 ` Linus Walleij
2026-01-25 19:51 ` [PATCH v2 2/2] i2c: core: support recovery for single-ended GPIOs Jie Li
2026-01-27 9:47 ` Linus Walleij
2026-02-01 11:18 ` [PATCH v3 0/2] i2c: improve bus " Jie Li
2026-02-01 11:18 ` [PATCH v3 1/2] gpiolib: add gpiod_is_single_ended() helper Jie Li
2026-02-01 11:18 ` [PATCH v3 2/2] i2c: core: support recovery for single-ended GPIOs Jie Li
2026-05-04 12:14 ` Wolfram Sang
2026-04-22 18:47 ` [PATCH v3 0/2] i2c: improve bus " 李杰
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06b1a681-4190-4552-a092-22dbdecf561c@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jie.i.li@nokia.com \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lj29312931@gmail.com \
--cc=robh@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox