From: Jie Li <lj29312931@gmail.com>
To: wsa@kernel.org, linusw@kernel.org
Cc: linux-i2c@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, Jie Li <jie.i.li@nokia.com>
Subject: [PATCH v3 0/2] i2c: improve bus recovery for single-ended GPIOs
Date: Sun, 1 Feb 2026 12:18:10 +0100 [thread overview]
Message-ID: <20260201111812.18945-1-jie.i.li@nokia.com> (raw)
In-Reply-To: <CAD++jLnk_5KG_q1aCtpOrTCbhtK-FxXH6BhPFSwukyt2F4uxmQ@mail.gmail.com>
Greetings,
Apologies for the delay in responding.
Thank you very much for your review and the specific guidance regarding
the return types. I really appreciate your patience and time spent
guiding me through my first contribution to the kernel.
This series (v3) updates the helper function to use the 'bool' type as
suggested and includes the Reviewed-by tags.
This series addresses a limitation in the I2C bus recovery mechanism where
certain open-drain GPIOs are incorrectly identified as input-only,
preventing the recovery logic from functioning.
Following the suggestion from Linus Walleij, this version drops the
previously proposed "force-set-sda" DT property. Instead, it
introduces a generic helper in the GPIO subsystem to identify
single-ended configurations. This allows the I2C core to reliably
enable recovery for open-drain lines regardless of the
instantaneous hardware direction reporting.
Changes in v3:
- Patch 1:
- Changed return type of gpiod_is_single_ended() from int to bool.
- Updated return values from 0/1 to false/true.
- Added Reviewed-by: Linus Walleij.
- Patch 2:
- Added Reviewed-by: Linus Walleij.
Changes in v2:
- Replaced DT-based "force-set-sda" with a gpiolib helper.
- Added gpiod_is_single_ended() to drivers/gpio/gpiolib.c.
- Updated i2c-core-base.c to use the new helper.
Jie Li (2):
gpiolib: add gpiod_is_single_ended() helper
i2c: core: support recovery for single-ended GPIOs
drivers/gpio/gpiolib.c | 22 ++++++++++++++++++++++
drivers/i2c/i2c-core-base.c | 3 ++-
include/linux/gpio/consumer.h | 5 +++++
3 files changed, 29 insertions(+), 1 deletion(-)
--
2.43.0
next prev parent reply other threads:[~2026-02-01 11:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 14:13 [PATCH v1 0/2] i2c: add support for forced SDA recovery Jie Li
2026-01-14 14:13 ` [PATCH v1 1/2] i2c: core: add "force-set-sda" flag for open-drain SDA without "FLAG_IS_OUT" bit Jie Li
2026-01-14 14:13 ` [PATCH v1 2/2] dt-bindings: i2c: add force-set-sda property Jie Li
2026-01-16 14:14 ` Krzysztof Kozlowski
2026-01-15 9:27 ` [PATCH v1 0/2] i2c: add support for forced SDA recovery Linus Walleij
2026-01-15 13:12 ` 李杰
2026-01-16 13:59 ` Linus Walleij
2026-01-25 19:51 ` [PATCH v2 0/2] i2c: improve bus recovery for single-ended GPIOs Jie Li
2026-01-25 19:51 ` [PATCH v2 1/2] gpiolib: add gpiod_is_single_ended() helper Jie Li
2026-01-27 9:46 ` Linus Walleij
2026-01-25 19:51 ` [PATCH v2 2/2] i2c: core: support recovery for single-ended GPIOs Jie Li
2026-01-27 9:47 ` Linus Walleij
2026-02-01 11:18 ` Jie Li [this message]
2026-02-01 11:18 ` [PATCH v3 1/2] gpiolib: add gpiod_is_single_ended() helper Jie Li
2026-02-01 11:18 ` [PATCH v3 2/2] i2c: core: support recovery for single-ended GPIOs Jie Li
2026-05-04 12:14 ` Wolfram Sang
2026-04-22 18:47 ` [PATCH v3 0/2] i2c: improve bus " 李杰
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260201111812.18945-1-jie.i.li@nokia.com \
--to=lj29312931@gmail.com \
--cc=jie.i.li@nokia.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox