public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Valentin Longchamp <valentin.longchamp-SkAbAL50j+5BDgjK7y7TUQ@public.gmane.org>
To: Linux I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Adrian Cox <adrian-nKrwMtk+6Wm9FHfhHBbuYA@public.gmane.org>,
	Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Cc: Valentin Longchamp
	<valentin.longchamp-SkAbAL50j+5BDgjK7y7TUQ@public.gmane.org>,
	Rainer Boschung
	<rainer.boschung-SkAbAL50j+5BDgjK7y7TUQ@public.gmane.org>
Subject: [PATCH] I2C: mpc: insert DR read in i2c_fixup()
Date: Fri, 16 May 2014 15:36:38 +0200	[thread overview]
Message-ID: <1400247398-23778-1-git-send-email-valentin.longchamp@keymile.com> (raw)

The mpc_i2c_fixup function is called when the bus is not released by a
slave. The function generates 9 pulses that should lead the slave
to release the bus.

The sequence that generates the pulses disables/enables the I2C module
that controls the blocked bus. We have found out on the P2041 SoC that
this could cause the CPU to hang (for a short delay).

To avoid this, this patch introduces a read to the I2CDR register
between the re-enablement of the I2C module in master mode and its
returning to the slave mode instead of the delay (the final delay,
between the pulses is kept), as proposed in procedure from the P2041
reference manual (16.6.2.3).

Signed-off-by: Rainer Boschung <rainer.boschung-SkAbAL50j+5BDgjK7y7TUQ@public.gmane.org>
Signed-off-by: Valentin Longchamp <valentin.longchamp-SkAbAL50j+5BDgjK7y7TUQ@public.gmane.org>

---

 drivers/i2c/busses/i2c-mpc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
index f539163..3655af7 100644
--- a/drivers/i2c/busses/i2c-mpc.c
+++ b/drivers/i2c/busses/i2c-mpc.c
@@ -107,6 +107,7 @@ static irqreturn_t mpc_i2c_isr(int irq, void *dev_id)
 static void mpc_i2c_fixup(struct mpc_i2c *i2c)
 {
 	int k;
+	u8 dr;
 	u32 delay_val = 1000000 / i2c->real_clk + 1;
 
 	if (delay_val < 2)
@@ -115,7 +116,7 @@ static void mpc_i2c_fixup(struct mpc_i2c *i2c)
 	for (k = 9; k; k--) {
 		writeccr(i2c, 0);
 		writeccr(i2c, CCR_MSTA | CCR_MTX | CCR_MEN);
-		udelay(delay_val);
+		dr = readb(i2c->base + MPC_I2C_DR);
 		writeccr(i2c, CCR_MEN);
 		udelay(delay_val << 1);
 	}
-- 
1.8.0.1

             reply	other threads:[~2014-05-16 13:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-16 13:36 Valentin Longchamp [this message]
     [not found] ` <1400247398-23778-1-git-send-email-valentin.longchamp-SkAbAL50j+5BDgjK7y7TUQ@public.gmane.org>
2014-06-02 16:27   ` [PATCH] I2C: mpc: insert DR read in i2c_fixup() Wolfram Sang
2014-06-03  6:49     ` Valentin Longchamp
     [not found]       ` <538D7017.40908-SkAbAL50j+5BDgjK7y7TUQ@public.gmane.org>
2014-06-03  7:11         ` Wolfram Sang
2014-06-03  8:45           ` Valentin Longchamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1400247398-23778-1-git-send-email-valentin.longchamp@keymile.com \
    --to=valentin.longchamp-skabal50j+5bdgjk7y7tuq@public.gmane.org \
    --cc=adrian-nKrwMtk+6Wm9FHfhHBbuYA@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=rainer.boschung-SkAbAL50j+5BDgjK7y7TUQ@public.gmane.org \
    --cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox