From: Valentin Longchamp <valentin.longchamp-SkAbAL50j+5BDgjK7y7TUQ@public.gmane.org>
To: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Cc: Linux I2C <linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Adrian Cox <adrian-nKrwMtk+6Wm9FHfhHBbuYA@public.gmane.org>,
"Boschung,
Rainer" <Rainer.Boschung-SkAbAL50j+5BDgjK7y7TUQ@public.gmane.org>
Subject: Re: [PATCH] I2C: mpc: insert DR read in i2c_fixup()
Date: Tue, 03 Jun 2014 10:45:20 +0200 [thread overview]
Message-ID: <538D8B20.3010705@keymile.com> (raw)
In-Reply-To: <20140603071114.GA2653@katana>
On 06/03/2014 09:11 AM, Wolfram Sang wrote:
>>>> --- a/drivers/i2c/busses/i2c-mpc.c
>>>> +++ b/drivers/i2c/busses/i2c-mpc.c
>>>> @@ -107,6 +107,7 @@ static irqreturn_t mpc_i2c_isr(int irq, void *dev_id)
>>>> static void mpc_i2c_fixup(struct mpc_i2c *i2c)
>>>> {
>>>> int k;
>>>> + u8 dr;
>>>
>>> Looks like we can drop this variable since the value read is not used?
>>
>> That's correct it is not used. I have added it to make sure that this is not
>> "optimized" out but I guess the readb call is enough for this purpose ?
>
> I'd think so, but it needs your test :)
>
I have just tested it and it's OK without the dr variable as well. Sending V2
right now.
Valentin
prev parent reply other threads:[~2014-06-03 8:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-16 13:36 [PATCH] I2C: mpc: insert DR read in i2c_fixup() Valentin Longchamp
[not found] ` <1400247398-23778-1-git-send-email-valentin.longchamp-SkAbAL50j+5BDgjK7y7TUQ@public.gmane.org>
2014-06-02 16:27 ` Wolfram Sang
2014-06-03 6:49 ` Valentin Longchamp
[not found] ` <538D7017.40908-SkAbAL50j+5BDgjK7y7TUQ@public.gmane.org>
2014-06-03 7:11 ` Wolfram Sang
2014-06-03 8:45 ` Valentin Longchamp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=538D8B20.3010705@keymile.com \
--to=valentin.longchamp-skabal50j+5bdgjk7y7tuq@public.gmane.org \
--cc=Rainer.Boschung-SkAbAL50j+5BDgjK7y7TUQ@public.gmane.org \
--cc=adrian-nKrwMtk+6Wm9FHfhHBbuYA@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox