* [PATCH 1/2] i2c: mux: pca954x: Export OF device ID table as module aliases
@ 2017-01-16 13:54 Javier Martinez Canillas
2017-01-16 13:54 ` [PATCH 2/2] i2c: pca9541: " Javier Martinez Canillas
2017-01-21 15:56 ` [PATCH 1/2] i2c: mux: pca954x: " Peter Rosin
0 siblings, 2 replies; 4+ messages in thread
From: Javier Martinez Canillas @ 2017-01-16 13:54 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, Peter Rosin, Wolfram Sang, linux-i2c
The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
device was registered via OF, this means that exporting the OF device ID
table device aliases in the module is not needed. But in order to change
how the core reports modaliases to user-space, it's better to export it.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/i2c/muxes/i2c-mux-pca954x.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c b/drivers/i2c/muxes/i2c-mux-pca954x.c
index dd18b9ccb1f4..a0232e079545 100644
--- a/drivers/i2c/muxes/i2c-mux-pca954x.c
+++ b/drivers/i2c/muxes/i2c-mux-pca954x.c
@@ -148,6 +148,7 @@ static const struct of_device_id pca954x_of_match[] = {
{ .compatible = "nxp,pca9548", .data = &chips[pca_9548] },
{}
};
+MODULE_DEVICE_TABLE(of, pca954x_of_match);
#endif
/* Write to mux register. Don't use i2c_transfer()/i2c_smbus_xfer()
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] i2c: pca9541: Export OF device ID table as module aliases
2017-01-16 13:54 [PATCH 1/2] i2c: mux: pca954x: Export OF device ID table as module aliases Javier Martinez Canillas
@ 2017-01-16 13:54 ` Javier Martinez Canillas
2017-01-21 15:56 ` Peter Rosin
2017-01-21 15:56 ` [PATCH 1/2] i2c: mux: pca954x: " Peter Rosin
1 sibling, 1 reply; 4+ messages in thread
From: Javier Martinez Canillas @ 2017-01-16 13:54 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, linux-i2c, Guenter Roeck, Peter Rosin,
Wolfram Sang
The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
device was registered via OF, this means that exporting the OF device ID
table device aliases in the module is not needed. But in order to change
how the core reports modaliases to user-space, it's better to export it.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/i2c/muxes/i2c-mux-pca9541.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/muxes/i2c-mux-pca9541.c b/drivers/i2c/muxes/i2c-mux-pca9541.c
index 4ea7e691afc7..77840f7845a1 100644
--- a/drivers/i2c/muxes/i2c-mux-pca9541.c
+++ b/drivers/i2c/muxes/i2c-mux-pca9541.c
@@ -90,6 +90,7 @@ static const struct of_device_id pca9541_of_match[] = {
{ .compatible = "nxp,pca9541" },
{}
};
+MODULE_DEVICE_TABLE(of, pca9541_of_match);
#endif
/*
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] i2c: pca9541: Export OF device ID table as module aliases
2017-01-16 13:54 ` [PATCH 2/2] i2c: pca9541: " Javier Martinez Canillas
@ 2017-01-21 15:56 ` Peter Rosin
0 siblings, 0 replies; 4+ messages in thread
From: Peter Rosin @ 2017-01-21 15:56 UTC (permalink / raw)
To: Javier Martinez Canillas, linux-kernel
Cc: linux-i2c, Guenter Roeck, Wolfram Sang
On 2017-01-16 14:54, Javier Martinez Canillas wrote:
> The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
> device was registered via OF, this means that exporting the OF device ID
> table device aliases in the module is not needed. But in order to change
> how the core reports modaliases to user-space, it's better to export it.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Acked-by: Peter Rosin <peda@axentia.se>
> ---
>
> drivers/i2c/muxes/i2c-mux-pca9541.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/muxes/i2c-mux-pca9541.c b/drivers/i2c/muxes/i2c-mux-pca9541.c
> index 4ea7e691afc7..77840f7845a1 100644
> --- a/drivers/i2c/muxes/i2c-mux-pca9541.c
> +++ b/drivers/i2c/muxes/i2c-mux-pca9541.c
> @@ -90,6 +90,7 @@ static const struct of_device_id pca9541_of_match[] = {
> { .compatible = "nxp,pca9541" },
> {}
> };
> +MODULE_DEVICE_TABLE(of, pca9541_of_match);
> #endif
>
> /*
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] i2c: mux: pca954x: Export OF device ID table as module aliases
2017-01-16 13:54 [PATCH 1/2] i2c: mux: pca954x: Export OF device ID table as module aliases Javier Martinez Canillas
2017-01-16 13:54 ` [PATCH 2/2] i2c: pca9541: " Javier Martinez Canillas
@ 2017-01-21 15:56 ` Peter Rosin
1 sibling, 0 replies; 4+ messages in thread
From: Peter Rosin @ 2017-01-21 15:56 UTC (permalink / raw)
To: Javier Martinez Canillas, linux-kernel; +Cc: Wolfram Sang, linux-i2c
On 2017-01-16 14:54, Javier Martinez Canillas wrote:
> The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
> device was registered via OF, this means that exporting the OF device ID
> table device aliases in the module is not needed. But in order to change
> how the core reports modaliases to user-space, it's better to export it.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Acked-by: Peter Rosin <peda@axentia.se>
> ---
>
> drivers/i2c/muxes/i2c-mux-pca954x.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/muxes/i2c-mux-pca954x.c b/drivers/i2c/muxes/i2c-mux-pca954x.c
> index dd18b9ccb1f4..a0232e079545 100644
> --- a/drivers/i2c/muxes/i2c-mux-pca954x.c
> +++ b/drivers/i2c/muxes/i2c-mux-pca954x.c
> @@ -148,6 +148,7 @@ static const struct of_device_id pca954x_of_match[] = {
> { .compatible = "nxp,pca9548", .data = &chips[pca_9548] },
> {}
> };
> +MODULE_DEVICE_TABLE(of, pca954x_of_match);
> #endif
>
> /* Write to mux register. Don't use i2c_transfer()/i2c_smbus_xfer()
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-01-21 16:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-16 13:54 [PATCH 1/2] i2c: mux: pca954x: Export OF device ID table as module aliases Javier Martinez Canillas
2017-01-16 13:54 ` [PATCH 2/2] i2c: pca9541: " Javier Martinez Canillas
2017-01-21 15:56 ` Peter Rosin
2017-01-21 15:56 ` [PATCH 1/2] i2c: mux: pca954x: " Peter Rosin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox