From: Rob Herring <robh@kernel.org>
To: "zoie.lin" <zoie.lin@mediatek.com>
Cc: Project_Global_Chrome_Upstream_Group@mediatek.com,
Conor Dooley <conor+dt@kernel.org>,
linux-i2c@vger.kernel.org, linux-mediatek@lists.infradead.org,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Matthias Brugger <matthias.bgg@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
devicetree@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 2/3] dt-bindings: eeprom: at24: Add support for at24c64
Date: Fri, 26 Apr 2024 06:41:39 -0500 [thread overview]
Message-ID: <171413169824.1152237.3973093428639305133.robh@kernel.org> (raw)
In-Reply-To: <20240426102949.23057-3-zoie.lin@mediatek.com>
On Fri, 26 Apr 2024 18:29:48 +0800, zoie.lin wrote:
> From: Zoie Lin <zoie.lin@mediatek.com>
>
> Update EEPROM bindings to include Atmel AT24C64
>
> Signed-off-by: Zoie Lin <zoie.lin@mediatek.com>
> ---
> Documentation/devicetree/bindings/eeprom/at24.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/misc/idt,89hpesx.example.dtb: idt@74: eeprom@50:compatible: More than one condition true in oneOf schema:
{'oneOf': [{'allOf': [{'items': [{'pattern': '^(atmel|catalyst|microchip|nxp|ramtron|renesas|rohm|st),(24(c|cs|lc|mac)[0-9]+|spd)$'},
{'pattern': '^atmel,(24(c|cs|mac)[0-9]+|spd)$'}],
'maxItems': 2,
'minItems': 1,
'type': 'array'},
{'oneOf': [{'items': {'pattern': 'c00$'},
'type': 'array'},
{'items': {'pattern': 'c01$'},
'type': 'array'},
{'items': {'pattern': 'cs01$'},
'type': 'array'},
{'items': {'pattern': 'c02$'},
'type': 'array'},
{'items': {'pattern': 'cs02$'},
'type': 'array'},
{'items': {'pattern': 'mac402$'},
'type': 'array'},
{'items': {'pattern': 'mac602$'},
'type': 'array'},
{'items': {'pattern': 'c04$'},
'type': 'array'},
{'items': {'pattern': 'cs04$'},
'type': 'array'},
{'items': {'pattern': 'c08$'},
'type': 'array'},
{'items': {'pattern': 'cs08$'},
'type': 'array'},
{'items': {'pattern': 'c16$'},
'type': 'array'},
{'items': {'pattern': 'cs16$'},
'type': 'array'},
{'items': {'pattern': 'c32$'},
'type': 'array'},
{'items': {'pattern': 'c32d-wl$'},
'type': 'array'},
{'items': {'pattern': 'cs32$'},
'type': 'array'},
{'items': {'pattern': 'c64$'},
'type': 'array'},
{'items': {'pattern': 'c64d-wl$'},
'type': 'array'},
{'items': {'pattern': 'cs64$'},
'type': 'array'},
{'items': {'pattern': 'c128$'},
'type': 'array'},
{'items': {'pattern': 'cs128$'},
'type': 'array'},
{'items': {'pattern': 'c256$'},
'type': 'array'},
{'items': {'pattern': 'cs256$'},
'type': 'array'},
{'items': {'pattern': 'c512$'},
'type': 'array'},
{'items': {'pattern': 'cs512$'},
'type': 'array'},
{'items': {'pattern': 'c1024$'},
'type': 'array'},
{'items': {'pattern': 'cs1024$'},
'type': 'array'},
{'items': {'pattern': 'c1025$'},
'type': 'array'},
{'items': {'pattern': 'cs1025$'},
'type': 'array'},
{'items': {'pattern': 'c2048$'},
'type': 'array'},
{'items': {'pattern': 'cs2048$'},
'type': 'array'},
{'items': {'pattern': 'spd$'},
'type': 'array'}]}]},
{'items': [{'const': 'belling,bl24c16a'},
{'const': 'atmel,24c16'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'enum': ['rohm,br24g01', 'rohm,br24t01']},
{'const': 'atmel,24c01'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'enum': ['nxp,se97b', 'renesas,r1ex24002']},
{'const': 'atmel,24c02'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'enum': ['onnn,cat24c04',
'onnn,cat24c05',
'rohm,br24g04']},
{'const': 'atmel,24c04'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'const': 'renesas,r1ex24016'},
{'const': 'atmel,24c16'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'const': 'giantec,gt24c32a'},
{'const': 'atmel,24c32'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'const': 'atmel,24c64'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{'items': [{'enum': ['renesas,r1ex24128',
'samsung,s524ad0xd1']},
{'const': 'atmel,24c128'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'}]}
from schema $id: http://devicetree.org/schemas/misc/idt,89hpesx.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/misc/idt,89hpesx.example.dtb: idt@74: eeprom@50: Unevaluated properties are not allowed ('compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/misc/idt,89hpesx.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/misc/idt,89hpesx.example.dtb: eeprom@50: compatible: More than one condition true in oneOf schema:
{'oneOf': [{'allOf': [{'items': [{'pattern': '^(atmel|catalyst|microchip|nxp|ramtron|renesas|rohm|st),(24(c|cs|lc|mac)[0-9]+|spd)$'},
{'pattern': '^atmel,(24(c|cs|mac)[0-9]+|spd)$'}],
'maxItems': 2,
'minItems': 1,
'type': 'array'},
{'oneOf': [{'items': {'pattern': 'c00$'},
'type': 'array'},
{'items': {'pattern': 'c01$'},
'type': 'array'},
{'items': {'pattern': 'cs01$'},
'type': 'array'},
{'items': {'pattern': 'c02$'},
'type': 'array'},
{'items': {'pattern': 'cs02$'},
'type': 'array'},
{'items': {'pattern': 'mac402$'},
'type': 'array'},
{'items': {'pattern': 'mac602$'},
'type': 'array'},
{'items': {'pattern': 'c04$'},
'type': 'array'},
{'items': {'pattern': 'cs04$'},
'type': 'array'},
{'items': {'pattern': 'c08$'},
'type': 'array'},
{'items': {'pattern': 'cs08$'},
'type': 'array'},
{'items': {'pattern': 'c16$'},
'type': 'array'},
{'items': {'pattern': 'cs16$'},
'type': 'array'},
{'items': {'pattern': 'c32$'},
'type': 'array'},
{'items': {'pattern': 'c32d-wl$'},
'type': 'array'},
{'items': {'pattern': 'cs32$'},
'type': 'array'},
{'items': {'pattern': 'c64$'},
'type': 'array'},
{'items': {'pattern': 'c64d-wl$'},
'type': 'array'},
{'items': {'pattern': 'cs64$'},
'type': 'array'},
{'items': {'pattern': 'c128$'},
'type': 'array'},
{'items': {'pattern': 'cs128$'},
'type': 'array'},
{'items': {'pattern': 'c256$'},
'type': 'array'},
{'items': {'pattern': 'cs256$'},
'type': 'array'},
{'items': {'pattern': 'c512$'},
'type': 'array'},
{'items': {'pattern': 'cs512$'},
'type': 'array'},
{'items': {'pattern': 'c1024$'},
'type': 'array'},
{'items': {'pattern': 'cs1024$'},
'type': 'array'},
{'items': {'pattern': 'c1025$'},
'type': 'array'},
{'items': {'pattern': 'cs1025$'},
'type': 'array'},
{'items': {'pattern': 'c2048$'},
'type': 'array'},
{'items': {'pattern': 'cs2048$'},
'type': 'array'},
{'items': {'pattern': 'spd$'},
'type': 'array'}]}]},
{'items': [{'const': 'belling,bl24c16a'},
{'const': 'atmel,24c16'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'enum': ['rohm,br24g01', 'rohm,br24t01']},
{'const': 'atmel,24c01'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'enum': ['nxp,se97b', 'renesas,r1ex24002']},
{'const': 'atmel,24c02'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'enum': ['onnn,cat24c04',
'onnn,cat24c05',
'rohm,br24g04']},
{'const': 'atmel,24c04'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'const': 'renesas,r1ex24016'},
{'const': 'atmel,24c16'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'const': 'giantec,gt24c32a'},
{'const': 'atmel,24c32'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'const': 'atmel,24c64'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{'items': [{'enum': ['renesas,r1ex24128',
'samsung,s524ad0xd1']},
{'const': 'atmel,24c128'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'}]}
from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/misc/idt,89hpesx.example.dtb: eeprom@50: Unevaluated properties are not allowed ('compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/nvmem/layouts/onie,tlv-layout.example.dtb: eeprom@56: compatible: More than one condition true in oneOf schema:
{'oneOf': [{'allOf': [{'items': [{'pattern': '^(atmel|catalyst|microchip|nxp|ramtron|renesas|rohm|st),(24(c|cs|lc|mac)[0-9]+|spd)$'},
{'pattern': '^atmel,(24(c|cs|mac)[0-9]+|spd)$'}],
'maxItems': 2,
'minItems': 1,
'type': 'array'},
{'oneOf': [{'items': {'pattern': 'c00$'},
'type': 'array'},
{'items': {'pattern': 'c01$'},
'type': 'array'},
{'items': {'pattern': 'cs01$'},
'type': 'array'},
{'items': {'pattern': 'c02$'},
'type': 'array'},
{'items': {'pattern': 'cs02$'},
'type': 'array'},
{'items': {'pattern': 'mac402$'},
'type': 'array'},
{'items': {'pattern': 'mac602$'},
'type': 'array'},
{'items': {'pattern': 'c04$'},
'type': 'array'},
{'items': {'pattern': 'cs04$'},
'type': 'array'},
{'items': {'pattern': 'c08$'},
'type': 'array'},
{'items': {'pattern': 'cs08$'},
'type': 'array'},
{'items': {'pattern': 'c16$'},
'type': 'array'},
{'items': {'pattern': 'cs16$'},
'type': 'array'},
{'items': {'pattern': 'c32$'},
'type': 'array'},
{'items': {'pattern': 'c32d-wl$'},
'type': 'array'},
{'items': {'pattern': 'cs32$'},
'type': 'array'},
{'items': {'pattern': 'c64$'},
'type': 'array'},
{'items': {'pattern': 'c64d-wl$'},
'type': 'array'},
{'items': {'pattern': 'cs64$'},
'type': 'array'},
{'items': {'pattern': 'c128$'},
'type': 'array'},
{'items': {'pattern': 'cs128$'},
'type': 'array'},
{'items': {'pattern': 'c256$'},
'type': 'array'},
{'items': {'pattern': 'cs256$'},
'type': 'array'},
{'items': {'pattern': 'c512$'},
'type': 'array'},
{'items': {'pattern': 'cs512$'},
'type': 'array'},
{'items': {'pattern': 'c1024$'},
'type': 'array'},
{'items': {'pattern': 'cs1024$'},
'type': 'array'},
{'items': {'pattern': 'c1025$'},
'type': 'array'},
{'items': {'pattern': 'cs1025$'},
'type': 'array'},
{'items': {'pattern': 'c2048$'},
'type': 'array'},
{'items': {'pattern': 'cs2048$'},
'type': 'array'},
{'items': {'pattern': 'spd$'},
'type': 'array'}]}]},
{'items': [{'const': 'belling,bl24c16a'},
{'const': 'atmel,24c16'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'enum': ['rohm,br24g01', 'rohm,br24t01']},
{'const': 'atmel,24c01'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'enum': ['nxp,se97b', 'renesas,r1ex24002']},
{'const': 'atmel,24c02'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'enum': ['onnn,cat24c04',
'onnn,cat24c05',
'rohm,br24g04']},
{'const': 'atmel,24c04'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'const': 'renesas,r1ex24016'},
{'const': 'atmel,24c16'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'const': 'giantec,gt24c32a'},
{'const': 'atmel,24c32'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'},
{'items': [{'const': 'atmel,24c64'}],
'maxItems': 1,
'minItems': 1,
'type': 'array'},
{'items': [{'enum': ['renesas,r1ex24128',
'samsung,s524ad0xd1']},
{'const': 'atmel,24c128'}],
'maxItems': 2,
'minItems': 2,
'type': 'array'}]}
from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/nvmem/layouts/onie,tlv-layout.example.dtb: eeprom@56: Unevaluated properties are not allowed ('compatible' was unexpected)
from schema $id: http://devicetree.org/schemas/eeprom/at24.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240426102949.23057-3-zoie.lin@mediatek.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2024-04-26 11:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 10:29 [PATCH 0/3] misc: eeprom: at24: add optional dovdd-supply zoie.lin
2024-04-26 10:29 ` [PATCH 1/3] " zoie.lin
2024-04-30 2:53 ` Mark Brown
2024-04-26 10:29 ` [PATCH 2/3] dt-bindings: eeprom: at24: Add support for at24c64 zoie.lin
2024-04-26 10:57 ` Krzysztof Kozlowski
2024-04-26 11:41 ` Rob Herring [this message]
2024-04-26 10:29 ` [PATCH 3/3] dt-bindings: eeprom: at24: Add property dovdd-supply zoie.lin
2024-04-26 10:59 ` Krzysztof Kozlowski
2024-04-26 19:10 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171413169824.1152237.3973093428639305133.robh@kernel.org \
--to=robh@kernel.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=zoie.lin@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox