From: zoie.lin <zoie.lin@mediatek.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
Cc: <linux-i2c@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
Zoie Lin <zoie.lin@mediatek.com>
Subject: [PATCH 1/3] misc: eeprom: at24: add optional dovdd-supply
Date: Fri, 26 Apr 2024 18:29:47 +0800 [thread overview]
Message-ID: <20240426102949.23057-2-zoie.lin@mediatek.com> (raw)
In-Reply-To: <20240426102949.23057-1-zoie.lin@mediatek.com>
From: Zoie Lin <zoie.lin@mediatek.com>
Incorporate support for the dovdd regulator, which supplies an
additional power source to the EEPROM.
Signed-off-by: Zoie Lin <zoie.lin@mediatek.com>
---
drivers/misc/eeprom/at24.c | 37 +++++++++++++++++++++++++++++++++++--
1 file changed, 35 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c
index 572333ead5fb..b96f6eda3ad2 100644
--- a/drivers/misc/eeprom/at24.c
+++ b/drivers/misc/eeprom/at24.c
@@ -86,6 +86,7 @@ struct at24_data {
struct nvmem_device *nvmem;
struct regulator *vcc_reg;
+ struct regulator *dovdd_reg;
void (*read_post)(unsigned int off, char *buf, size_t count);
/*
@@ -697,6 +698,14 @@ static int at24_probe(struct i2c_client *client)
if (IS_ERR(at24->vcc_reg))
return PTR_ERR(at24->vcc_reg);
+ at24->dovdd_reg = devm_regulator_get_optional(dev, "dovdd");
+ if (IS_ERR(at24->dovdd_reg)) {
+ if (PTR_ERR(at24->dovdd_reg) == -ENODEV)
+ at24->dovdd_reg = NULL;
+ else
+ return PTR_ERR(at24->dovdd_reg);
+ }
+
writable = !(flags & AT24_FLAG_READONLY);
if (writable) {
at24->write_max = min_t(unsigned int,
@@ -754,6 +763,14 @@ static int at24_probe(struct i2c_client *client)
return err;
}
+ if (at24->dovdd_reg != NULL) {
+ err = regulator_enable(at24->dovdd_reg);
+ if (err) {
+ dev_err(dev, "Failed to enable dovdd regulator\n");
+ return err;
+ }
+ }
+
pm_runtime_set_active(dev);
}
pm_runtime_enable(dev);
@@ -761,8 +778,11 @@ static int at24_probe(struct i2c_client *client)
at24->nvmem = devm_nvmem_register(dev, &nvmem_config);
if (IS_ERR(at24->nvmem)) {
pm_runtime_disable(dev);
- if (!pm_runtime_status_suspended(dev))
+ if (!pm_runtime_status_suspended(dev)) {
regulator_disable(at24->vcc_reg);
+ if (at24->dovdd_reg != NULL)
+ regulator_disable(at24->dovdd_reg);
+ }
return dev_err_probe(dev, PTR_ERR(at24->nvmem),
"failed to register nvmem\n");
}
@@ -804,8 +824,11 @@ static void at24_remove(struct i2c_client *client)
pm_runtime_disable(&client->dev);
if (acpi_dev_state_d0(&client->dev)) {
- if (!pm_runtime_status_suspended(&client->dev))
+ if (!pm_runtime_status_suspended(&client->dev)) {
regulator_disable(at24->vcc_reg);
+ if (at24->dovdd_reg != NULL)
+ regulator_disable(at24->dovdd_reg);
+ }
pm_runtime_set_suspended(&client->dev);
}
}
@@ -815,14 +838,24 @@ static int __maybe_unused at24_suspend(struct device *dev)
struct i2c_client *client = to_i2c_client(dev);
struct at24_data *at24 = i2c_get_clientdata(client);
+ if (at24->dovdd_reg != NULL)
+ regulator_disable(at24->dovdd_reg);
+
return regulator_disable(at24->vcc_reg);
}
static int __maybe_unused at24_resume(struct device *dev)
{
+ int err;
struct i2c_client *client = to_i2c_client(dev);
struct at24_data *at24 = i2c_get_clientdata(client);
+ if (at24->dovdd_reg != NULL) {
+ err = regulator_enable(at24->dovdd_reg);
+ if (err)
+ return err;
+ }
+
return regulator_enable(at24->vcc_reg);
}
--
2.18.0
next prev parent reply other threads:[~2024-04-26 10:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 10:29 [PATCH 0/3] misc: eeprom: at24: add optional dovdd-supply zoie.lin
2024-04-26 10:29 ` zoie.lin [this message]
2024-04-30 2:53 ` [PATCH 1/3] " Mark Brown
2024-04-26 10:29 ` [PATCH 2/3] dt-bindings: eeprom: at24: Add support for at24c64 zoie.lin
2024-04-26 10:57 ` Krzysztof Kozlowski
2024-04-26 11:41 ` Rob Herring
2024-04-26 10:29 ` [PATCH 3/3] dt-bindings: eeprom: at24: Add property dovdd-supply zoie.lin
2024-04-26 10:59 ` Krzysztof Kozlowski
2024-04-26 19:10 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240426102949.23057-2-zoie.lin@mediatek.com \
--to=zoie.lin@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox