[PATCH] dpll: Make ZL3073X invisible

[PATCH] dpll: Make ZL3073X invisible

[Geert Uytterhoeven]

Currently, the user is always asked about the Microchip Azurite
DPLL/PTP/SyncE core driver, even when I2C and SPI are disabled, and thus
the driver cannot be used at all.

Fix this by making the Kconfig symbol for the core driver invisible
(unless compile-testing), and selecting it by the bus glue sub-drivers.
Drop the modular defaults, as drivers should not default to enabled.

Fixes: 2df8e64e01c10a4b ("dpll: Add basic Microchip ZL3073x support")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/dpll/zl3073x/Kconfig | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/dpll/zl3073x/Kconfig b/drivers/dpll/zl3073x/Kconfig
index 7db262ab84582d29..9915f7423dea370c 100644
--- a/drivers/dpll/zl3073x/Kconfig
+++ b/drivers/dpll/zl3073x/Kconfig
@@ -1,7 +1,7 @@
 # SPDX-License-Identifier: GPL-2.0-only
 
 config ZL3073X
-	tristate "Microchip Azurite DPLL/PTP/SyncE devices"
+	tristate "Microchip Azurite DPLL/PTP/SyncE devices" if COMPILE_TEST
 	depends on NET
 	select DPLL
 	select NET_DEVLINK
@@ -16,9 +16,9 @@ config ZL3073X
 
 config ZL3073X_I2C
 	tristate "I2C bus implementation for Microchip Azurite devices"
-	depends on I2C && ZL3073X
+	depends on I2C
 	select REGMAP_I2C
-	default m
+	select ZL3073X
 	help
 	  This is I2C bus implementation for Microchip Azurite DPLL/PTP/SyncE
 	  devices.
@@ -28,9 +28,9 @@ config ZL3073X_I2C
 
 config ZL3073X_SPI
 	tristate "SPI bus implementation for Microchip Azurite devices"
-	depends on SPI && ZL3073X
+	depends on SPI
 	select REGMAP_SPI
-	default m
+	select ZL3073X
 	help
 	  This is SPI bus implementation for Microchip Azurite DPLL/PTP/SyncE
 	  devices.
-- 
2.43.0

Re: [PATCH] dpll: Make ZL3073X invisible

[Ivan Vecera]

On 30. 07. 25 1:23 odp., Geert Uytterhoeven wrote:
> Currently, the user is always asked about the Microchip Azurite
> DPLL/PTP/SyncE core driver, even when I2C and SPI are disabled, and thus
> the driver cannot be used at all.
> 
> Fix this by making the Kconfig symbol for the core driver invisible
> (unless compile-testing), and selecting it by the bus glue sub-drivers.
> Drop the modular defaults, as drivers should not default to enabled.
> 
> Fixes: 2df8e64e01c10a4b ("dpll: Add basic Microchip ZL3073x support")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>   drivers/dpll/zl3073x/Kconfig | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)

Please use 'PATCH net'... otherwise:

Reviewed by: Ivan Vecera <ivecera@redhat.com>

Re: [PATCH] dpll: Make ZL3073X invisible

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 30 Jul 2025 13:23:32 +0200 you wrote:
> Currently, the user is always asked about the Microchip Azurite
> DPLL/PTP/SyncE core driver, even when I2C and SPI are disabled, and thus
> the driver cannot be used at all.
> 
> Fix this by making the Kconfig symbol for the core driver invisible
> (unless compile-testing), and selecting it by the bus glue sub-drivers.
> Drop the modular defaults, as drivers should not default to enabled.
> 
> [...]

Here is the summary with links:
  - dpll: Make ZL3073X invisible
    https://git.kernel.org/netdev/net/c/a4f0866e3dbb

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html