From: "Rob Herring (Arm)" <robh@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Andi Shyti <andi.shyti@kernel.org>,
Robert Foss <rfoss@kernel.org>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org,
Manivannan Sadhasivam <mani@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Todor Tomov <todor.too@gmail.com>,
Loic Poulain <loic.poulain@oss.qualcomm.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
linux-samsung-soc@vger.kernel.org, linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org,
Dongchun Zhu <dongchun.zhu@mediatek.com>
Subject: Re: [PATCH v2 01/72] dt-bindings: media: Deprecate clock-frequency property for camera sensors
Date: Tue, 12 Aug 2025 23:44:42 -0500 [thread overview]
Message-ID: <175506028291.2605875.11473205221167147078.robh@kernel.org> (raw)
In-Reply-To: <20250812214620.30425-2-laurent.pinchart@ideasonboard.com>
On Wed, 13 Aug 2025 00:45:09 +0300, Laurent Pinchart wrote:
> Usage of the clock-frequency property for camera sensors is discouraged
> in favour of using assigned-clock-rates (and assigned-clock-parents
> where needed). Mark the property as deprecated.
>
> Update the examples accordingly. In DT examples where the sensor input
> clock appears to come from a programmable clock generator, replace
> clock-frequency by the assigned-clocks and assigned-clock-rates
> properties. Otherwise, just drop clock-frequency.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> ---
> Changes since v1:
>
> - Adapt examples in bindings that reference sensors
> ---
> Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 6 ++++--
> Documentation/devicetree/bindings/media/i2c/mipi-ccs.yaml | 7 +++++--
> .../devicetree/bindings/media/i2c/ovti,ov02a10.yaml | 3 +--
> .../devicetree/bindings/media/i2c/ovti,ov5645.yaml | 6 +++++-
> .../devicetree/bindings/media/i2c/ovti,ov7251.yaml | 6 +++++-
> .../devicetree/bindings/media/i2c/ovti,ov8856.yaml | 3 +--
> .../devicetree/bindings/media/i2c/samsung,s5k5baf.yaml | 6 +++++-
> .../devicetree/bindings/media/i2c/samsung,s5k6a3.yaml | 6 +++++-
> .../devicetree/bindings/media/i2c/sony,imx290.yaml | 5 +++--
> .../bindings/media/samsung,exynos4212-fimc-is.yaml | 4 ++--
> Documentation/devicetree/bindings/media/samsung,fimc.yaml | 3 ++-
> 11 files changed, 38 insertions(+), 17 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/samsung,exynos4212-fimc-is.example.dtb: image-sensor@10 (samsung,s5k6a3): 'clocks' is a required property
from schema $id: http://devicetree.org/schemas/media/i2c/samsung,s5k6a3.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/samsung,exynos4212-fimc-is.example.dtb: image-sensor@10 (samsung,s5k6a3): 'clocks' is a dependency of 'clock-names'
from schema $id: http://devicetree.org/schemas/clock/clock.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/samsung,exynos4212-fimc-is.example.dtb: image-sensor@10 (samsung,s5k6a3): 'anyOf' conditional failed, one must be fixed:
'clocks' is a required property
'#clock-cells' is a required property
from schema $id: http://devicetree.org/schemas/clock/clock.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250812214620.30425-2-laurent.pinchart@ideasonboard.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-08-13 4:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-12 21:45 [PATCH v2 00/72] media: i2c: Reduce cargo-cult Laurent Pinchart
2025-08-12 21:45 ` [PATCH v2 01/72] dt-bindings: media: Deprecate clock-frequency property for camera sensors Laurent Pinchart
2025-08-13 4:44 ` Rob Herring (Arm) [this message]
2025-08-13 8:41 ` Laurent Pinchart
2025-08-13 9:49 ` [PATCH v2.1 " Laurent Pinchart
2025-09-12 22:41 ` Wolfram Sang
2025-09-13 9:31 ` Laurent Pinchart
2025-09-03 13:25 ` [PATCH v2 00/72] media: i2c: Reduce cargo-cult Mehdi Djait
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=175506028291.2605875.11473205221167147078.robh@kernel.org \
--to=robh@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dongchun.zhu@mediatek.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mani@kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=rfoss@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sakari.ailus@linux.intel.com \
--cc=todor.too@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox