Re: RE: [PATCH 1/2] i2c: usbio: Add ACPI device-id for MTL-CVF devices

[Hans de Goede <hansg@kernel.org>]

Hi Israel,

On 2-Oct-25 8:05 PM, Cepeda Lopez, Israel A wrote:
> Thank you Hans,
> 
>> -----Original Message-----
>> From: Hans de Goede <hansg@kernel.org>
>> Sent: Thursday, October 2, 2025 10:49 AM
>> To: Cepeda Lopez, Israel A <israel.a.cepeda.lopez@intel.com>; Sakari Ailus
>> <sakari.ailus@linux.intel.com>
>> Cc: Andi Shyti <andi.shyti@kernel.org>; Wolfram Sang <wsa+renesas@sang-
>> engineering.com>; linux-i2c@vger.kernel.org
>> Subject: Re: [PATCH 1/2] i2c: usbio: Add ACPI device-id for MTL-CVF devices
>>
>> Hi Israel,
>>
>> On 2-Oct-25 5:52 PM, Cepeda Lopez, Israel A wrote:
>>> Hi Hans,
>>>
>>> LJCA and USBIO shouldn't be sharing HIDs.
>>
>> Yes in practice we have shipping hardware that is sharing HIDs
>> and since this is hardware out there in the field there is
>> nothing we can do about this.
> 
> There is. DELL has to provide a new FW/BIOS update to fix the HID
> of the system on fault. That is the correct solution to the issue.

Even if Dell is willing to do this (which I find unlikely)
it will still likely take at least 6 months for a BIOS update
to show up with these changes (BIOS QA takes a lot of time in
my experience).

And even then we cannot count on users to actually install BIOS
updates. So we will still need the INTC10D1, INTC10D2 and
INTC10D3 HIDs in both the ljca and usbio drivers to support
people who are still at the older BIOS.

And if I've understood Sakari correct then the INTC10D1, INTC10D2
HIDs are indeed intended for use with the USBIO driver and
the problem is that ideally they should not also be used by
the LJCA driver.

Since this patch adds the HIDs to the USBIO drivers, where they
belong the whole discussion of them not supposed to be in the LJCA
driver is sort of offtopic and this patch is correct regardless.

As such can you please give your Acked-by or Reviewed-by
for this patch and for the matching GPIO patch:

https://lore.kernel.org/linux-gpio/20251001212416.4871-1-hansg@kernel.org/

Regards,

Hans