From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Hans de Goede <hansg@kernel.org>
Cc: Israel Cepeda <israel.a.cepeda.lopez@intel.com>,
Andi Shyti <andi.shyti@kernel.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-i2c@vger.kernel.org, Lixu Zhang <lixu.zhang@intel.com>
Subject: Re: [PATCH 1/2] i2c: usbio: Add ACPI device-id for MTL-CVF devices
Date: Thu, 2 Oct 2025 01:09:15 +0300 [thread overview]
Message-ID: <aN2mi9LQln6n71_m@kekkonen.localdomain> (raw)
In-Reply-To: <aN2j7Gg2fqHCbAHi@kekkonen.localdomain>
Hi Hans, Lixu,
On Thu, Oct 02, 2025 at 12:58:07AM +0300, Sakari Ailus wrote:
> Hi Hans,
>
> On Wed, Oct 01, 2025 at 11:23:10PM +0200, Hans de Goede wrote:
> > Add "INTC10D2" ACPI device-id for MTL-CVF devices, like the Dell Latitude
> > 7450.
> >
> > Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2368506
> > Signed-off-by: Hans de Goede <hansg@kernel.org>
> > ---
> > Note this applies on top of the addition of the new i2c-usbio driver which
> > is being merged through gregkh/usb.git usb-next
> > ---
> > drivers/i2c/busses/i2c-usbio.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/i2c/busses/i2c-usbio.c b/drivers/i2c/busses/i2c-usbio.c
> > index d42f9ab6e9a5..e7799abf6787 100644
> > --- a/drivers/i2c/busses/i2c-usbio.c
> > +++ b/drivers/i2c/busses/i2c-usbio.c
> > @@ -27,6 +27,7 @@ static const struct acpi_device_id usbio_i2c_acpi_hids[] = {
> > { "INTC1008" }, /* MTL */
> > { "INTC10B3" }, /* ARL */
> > { "INTC10B6" }, /* LNL */
> > + { "INTC10D2" }, /* MTL-CVF */
>
> INTC10D2 is apparently already claimed by the LJCA I²C driver. Do you have
> an actual system that uses USBIO and this HID?
Actually it looks like i2c-ljca.c shouldn't list this HID. The same
probably goes for all 10CF--10D3.
Lixu: any idea?
I thought USBIO always came with CVS but that doesn't seem to be the case
here.
>
> > { "INTC10E3" }, /* PTL */
> > { }
> > };
>
--
Regards,
Sakari Ailus
next prev parent reply other threads:[~2025-10-01 22:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 21:23 [PATCH 1/2] i2c: usbio: Add ACPI device-id for MTL-CVF devices Hans de Goede
2025-10-01 21:58 ` Sakari Ailus
2025-10-01 22:09 ` Sakari Ailus [this message]
2025-10-02 8:56 ` Hans de Goede
2025-10-02 9:18 ` Sakari Ailus
2025-10-02 12:03 ` Hans de Goede
2025-10-02 13:04 ` Hans de Goede
2025-10-02 15:52 ` Cepeda Lopez, Israel A
2025-10-02 17:49 ` Hans de Goede
2025-10-02 18:05 ` Cepeda Lopez, Israel A
2025-10-04 14:03 ` Hans de Goede
2025-10-09 1:50 ` Cepeda Lopez, Israel A
2025-10-06 6:29 ` Sakari Ailus
2025-10-14 11:58 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aN2mi9LQln6n71_m@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=hansg@kernel.org \
--cc=israel.a.cepeda.lopez@intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=lixu.zhang@intel.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox