From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Sergei Poselenov <sposelenov-qv+LCo8X3VpBDgjK7y7TUQ@public.gmane.org>
Cc: i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: AU1550 I2C driver - why not wait for bus free?
Date: Sat, 5 Apr 2008 11:24:09 +0200 [thread overview]
Message-ID: <20080405112409.68b6c1a3@hyperion.delvare> (raw)
In-Reply-To: <47F3549E.2090500-qv+LCo8X3VpBDgjK7y7TUQ@public.gmane.org>
Hi Sergei,
On Wed, 02 Apr 2008 13:40:46 +0400, Sergei Poselenov wrote:
> I have a question about AU1550 I2C driver.
> Why the driver starts transfer regardless of the state
> of I2C bus? Shouldn't it wait for the "bus busy" bit
> in smbstat to become zero before setting the
> "master start" bit?
>
> I see, in the 2.4 version of the driver the above logic
> was present, but avoided in 2.6.
I wasn't aware that there was a 2.4 i2c-au1550 driver... I don't see it
in mainline at least.
Checking for the bus busy bit before starting a transaction sounds like
a good idea, feel free to submit a patch implementing this and we'll
review it.
--
Jean Delvare
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
prev parent reply other threads:[~2008-04-05 9:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-02 9:40 AU1550 I2C driver - why not wait for bus free? Sergei Poselenov
[not found] ` <47F3549E.2090500-qv+LCo8X3VpBDgjK7y7TUQ@public.gmane.org>
2008-04-05 9:24 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080405112409.68b6c1a3@hyperion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=sposelenov-qv+LCo8X3VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox