AU1550 I2C driver - why not wait for bus free?

AU1550 I2C driver - why not wait for bus free?

[Sergei Poselenov]

Hello all,

I have a question about AU1550 I2C driver.
Why the driver starts transfer regardless of the state
of I2C bus? Shouldn't it wait for the "bus busy" bit
in smbstat to become zero before setting the
"master start" bit?

I see, in the 2.4 version of the driver the above logic
was present, but avoided in 2.6.

Thanks a lot any help.

Regards,
Sergei

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

Re: AU1550 I2C driver - why not wait for bus free?

[Jean Delvare]

Hi Sergei,

On Wed, 02 Apr 2008 13:40:46 +0400, Sergei Poselenov wrote:
> I have a question about AU1550 I2C driver.
> Why the driver starts transfer regardless of the state
> of I2C bus? Shouldn't it wait for the "bus busy" bit
> in smbstat to become zero before setting the
> "master start" bit?
> 
> I see, in the 2.4 version of the driver the above logic
> was present, but avoided in 2.6.

I wasn't aware that there was a 2.4 i2c-au1550 driver... I don't see it
in mainline at least.

Checking for the bus busy bit before starting a transaction sounds like
a good idea, feel free to submit a patch implementing this and we'll
review it.

-- 
Jean Delvare

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c