From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: "Maciej W. Rozycki" <macro-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>
Cc: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>,
Linux I2C <i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org>
Subject: Re: [PATCH] i2c: Improve the functionality documentation
Date: Sun, 11 May 2008 11:14:52 +0200 [thread overview]
Message-ID: <20080511111452.6e76e939@hyperion.delvare> (raw)
In-Reply-To: <Pine.LNX.4.55.0805110818040.18978-j8+e0ZhYU2SU0huXySazC6sMm+1xrEX8@public.gmane.org>
On Sun, 11 May 2008 08:23:01 +0100 (BST), Maciej W. Rozycki wrote:
> On Sat, 10 May 2008, Jean Delvare wrote:
>
> > Attempt to make the documentation about the I2C/SMBus functionality
> > checking API clearer.
>
> It looks good to me. A minor nit below.
Thanks for the review.
>
> > + if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE_DATA |
> > + I2C_FUNC_SMBUS_WORD_DATA))
>
> Indentation (obviously it is the driver you are referring to that has got
> it wrong in the first place).
There's nothing wrong with indentation here. Alignment on opening
parenthesis is a common strategy, and checkpatch.pl accepts it.
--
Jean Delvare
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
next prev parent reply other threads:[~2008-05-11 9:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-10 8:39 [PATCH] i2c: Improve the functionality documentation Jean Delvare
[not found] ` <20080510103937.1c74ca8c-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-05-11 7:23 ` Maciej W. Rozycki
[not found] ` <Pine.LNX.4.55.0805110818040.18978-j8+e0ZhYU2SU0huXySazC6sMm+1xrEX8@public.gmane.org>
2008-05-11 9:14 ` Jean Delvare [this message]
[not found] ` <20080511111452.6e76e939-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-05-11 16:02 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080511111452.6e76e939@hyperion.delvare \
--to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
--cc=david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org \
--cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=macro-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox