Linux I2C development
 help / color / mirror / Atom feed
* [PATCH 3/3] i2c/eeprom: Only probe buses with DDC or SPD class
@ 2008-06-03 11:03 Jean Delvare
  0 siblings, 0 replies; only message in thread
From: Jean Delvare @ 2008-06-03 11:03 UTC (permalink / raw)
  To: Linux I2C; +Cc: David Brownell

The eeprom driver shouldn't probe i2c buses which don't want to be
probed.

Signed-off-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
---
 drivers/i2c/chips/eeprom.c |    8 ++++++++
 1 file changed, 8 insertions(+)

--- linux-2.6.26-rc4.orig/drivers/i2c/chips/eeprom.c	2008-06-03 09:57:31.000000000 +0200
+++ linux-2.6.26-rc4/drivers/i2c/chips/eeprom.c	2008-06-03 10:46:09.000000000 +0200
@@ -159,6 +159,8 @@ static struct bin_attribute eeprom_attr 
 
 static int eeprom_attach_adapter(struct i2c_adapter *adapter)
 {
+	if (!(adapter->class & (I2C_CLASS_DDC | I2C_CLASS_SPD)))
+		return 0;
 	return i2c_probe(adapter, &addr_data, eeprom_detect);
 }
 
@@ -169,6 +171,12 @@ static int eeprom_detect(struct i2c_adap
 	struct eeprom_data *data;
 	int err = 0;
 
+	/* EDID EEPROMs are often 24C00 EEPROMs, which answer to all
+	   addresses 0x50-0x57, but we only care about 0x50. So decline
+	   attaching to addresses >= 0x51 on DDC buses */
+	if (!(adapter->class & I2C_CLASS_SPD) && address >= 0x51)
+		goto exit;
+
 	/* There are three ways we can read the EEPROM data:
 	   (1) I2C block reads (faster, but unsupported by most adapters)
 	   (2) Consecutive byte reads (100% overhead)


-- 
Jean Delvare

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-06-03 11:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-03 11:03 [PATCH 3/3] i2c/eeprom: Only probe buses with DDC or SPD class Jean Delvare

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox