Linux I2C development
 help / color / mirror / Atom feed
From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: maximilian attems <max-U9r9yeDMy7A@public.gmane.org>
Cc: Paul Mackerras <paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>,
	davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
	i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
Subject: Re: [PATCH] [OF] request_module() use format string
Date: Thu, 12 Jun 2008 08:27:26 +0200	[thread overview]
Message-ID: <20080612082726.0f495687@hyperion.delvare> (raw)
In-Reply-To: <1213246926-10043-1-git-send-email-max-U9r9yeDMy7A@public.gmane.org>

Hi Maximilian,

On Thu, 12 Jun 2008 07:02:06 +0200, maximilian attems wrote:
> similar to 326f6a5c9c9e1a62aec37bdc0c3f8d53adabe77b,
> maybe writable by root thus worth fixing.

I don't think root can affect the value of the string, but the file it
is read from could be broken. So yes it seems worth fixing.

> 
> Signed-off-by: maximilian attems <max-U9r9yeDMy7A@public.gmane.org>
> ---
>  drivers/of/of_i2c.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/of/of_i2c.c b/drivers/of/of_i2c.c
> index b2ccdcb..117de8b 100644
> --- a/drivers/of/of_i2c.c
> +++ b/drivers/of/of_i2c.c
> @@ -100,7 +100,7 @@ void of_register_i2c_devices(struct i2c_adapter *adap,
>  
>  		info.addr = *addr;
>  
> -		request_module(info.type);
> +		request_module("%s", info.type);
>  
>  		result = i2c_new_device(adap, &info);
>  		if (result == NULL) {

Acked-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>

I think you want to send this fix to Jochen Friedrich and Paul
Mackerras (both Cc'd) as they are the ones working on this driver.

-- 
Jean Delvare

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c

  parent reply	other threads:[~2008-06-12  6:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-12  5:02 [PATCH] [OF] request_module() use format string maximilian attems
     [not found] ` <1213246926-10043-1-git-send-email-max-U9r9yeDMy7A@public.gmane.org>
2008-06-12  6:27   ` Jean Delvare [this message]
     [not found]     ` <20080612082726.0f495687-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-06-12  7:22       ` maximilian attems

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080612082726.0f495687@hyperion.delvare \
    --to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
    --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
    --cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
    --cc=max-U9r9yeDMy7A@public.gmane.org \
    --cc=paulus-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox