From: David Brownell <david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
To: Alessandro Zummo
<alessandro.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org>,
BARRE Sebastien <sbarre-6lXSvc0s5hDQT0dZR+AlfA@public.gmane.org>
Cc: frederic Rodo
<f.rodo-6YL8BHNr0ZqHdZQakrT3ElaPQRlvutdw@public.gmane.org>,
Rodolfo Giometti
<giometti-AVVDYK/kqiJWk0Htik3J/w@public.gmane.org>,
"i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org"
<i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org>,
"rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org"
<rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org>
Subject: Re: [PATCH 2.6.26.5] rtc-ds1307 : SMBus compatibility
Date: Thu, 16 Oct 2008 11:06:01 -0700 [thread overview]
Message-ID: <200810161106.02871.david-b@pacbell.net> (raw)
In-Reply-To: <20081014184038.6f1b5c59-1Z+4F8PJzVxlecnr3/Sf3RLwuzhV/fVh@public.gmane.org>
On Tuesday 14 October 2008, Alessandro Zummo wrote:
> On Tue, 14 Oct 2008 17:57:29 +0200
> BARRE Sebastien <sbarre-6lXSvc0s5hDQT0dZR+AlfA@public.gmane.org> wrote:
>
> > > seems almost ok. please send your latest version to me and cc to
> > > the rtc-list for the final review. if it passed Jean's tests
> > > I'm confident it's quite ready for inclusion :)
> >
> > Patch is attached to preserve tabs.
>
> bzzzt. wrong! patches must be submitted inline
Though that's not a hard-and-fast policy; when
the submitter can't get relevant mailers to avoid
mangling the patches, it's better to attach them
than otherwise. However, see
Documentation/email-clients.txt
More generally, this patch isn't much good since
it doesn't even *apply* ... on top of a pending
patch to the same driver, which has been in the
MM tree since late July or so.
My suggestion: since that patch was recently
(last night) sent to Linus for merging, wait
until it's in mainline GIT. Then refresh and
re-send the patch.
- Dave
_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c
next prev parent reply other threads:[~2008-10-16 18:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-09 6:59 [PATCH 2.6.26.5] rtc-ds1307 : SMBus compatibility BARRE Sebastien
[not found] ` <C1C62166118DFA4A8BBA01A2411F0D170E9BE59E27-iGzfJtNnmHkUlixSki3fykIJAyBIbWHDnAJcWxkt5PDR7s880joybQ@public.gmane.org>
2008-10-10 11:33 ` Jean Delvare
[not found] ` <20081010133344.653431af-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-10-10 13:46 ` BARRE Sebastien
[not found] ` <C1C62166118DFA4A8BBA01A2411F0D170E9BE5A032-iGzfJtNnmHkUlixSki3fykIJAyBIbWHDnAJcWxkt5PDR7s880joybQ@public.gmane.org>
2008-10-13 15:32 ` Jean Delvare
[not found] ` <20081013173206.6b7a5e1e-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-10-14 13:15 ` BARRE Sebastien
[not found] ` <C1C62166118DFA4A8BBA01A2411F0D170E9BE5A2DA-iGzfJtNnmHkUlixSki3fykIJAyBIbWHDnAJcWxkt5PDR7s880joybQ@public.gmane.org>
2008-10-14 13:22 ` Alessandro Zummo
[not found] ` <20081014152202.4a88920a-1Z+4F8PJzVxlecnr3/Sf3RLwuzhV/fVh@public.gmane.org>
2008-10-14 15:57 ` BARRE Sebastien
[not found] ` <C1C62166118DFA4A8BBA01A2411F0D170E9BE5A317-iGzfJtNnmHkUlixSki3fykIJAyBIbWHDnAJcWxkt5PDR7s880joybQ@public.gmane.org>
2008-10-14 16:40 ` Alessandro Zummo
[not found] ` <20081014184038.6f1b5c59-1Z+4F8PJzVxlecnr3/Sf3RLwuzhV/fVh@public.gmane.org>
2008-10-15 8:34 ` BARRE Sebastien
2008-10-16 18:06 ` David Brownell [this message]
2008-10-14 13:29 ` Jean Delvare
[not found] ` <20081014152928.6d91eefd-ig7AzVSIIG7kN2dkZ6Wm7A@public.gmane.org>
2008-10-14 15:47 ` David Brownell
[not found] ` <200810140847.18839.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-10-14 16:24 ` BARRE Sebastien
2008-10-12 4:50 ` David Brownell
[not found] ` <200810112150.21370.david-b-yBeKhBN/0LDR7s880joybQ@public.gmane.org>
2008-10-13 14:55 ` BARRE Sebastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810161106.02871.david-b@pacbell.net \
--to=david-b-ybekhbn/0ldr7s880joybq@public.gmane.org \
--cc=alessandro.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org \
--cc=f.rodo-6YL8BHNr0ZqHdZQakrT3ElaPQRlvutdw@public.gmane.org \
--cc=giometti-AVVDYK/kqiJWk0Htik3J/w@public.gmane.org \
--cc=i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org \
--cc=rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=sbarre-6lXSvc0s5hDQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox