Re: [PATCH 4/6]: i2c-pcf: Add a way for bus driver to ask for no smbus quick mode support.

[Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>]

Hi Wolfram,

On Thu, 16 Oct 2008 12:46:23 +0200, Wolfram Sang wrote:
> Hi Jean,
> 
> On Thu, Oct 16, 2008 at 12:13:15PM +0200, Jean Delvare wrote:
> 
> > > The pcf driver sets the class bit used by FAN and temperature sensors,
> > > so the I2C layer goes poking around all of the standard address
> > > locations each of those drivers list.
> > 
> > By setting this class flag in your driver, you ask for these probes.
> 
> What about making this more obvious? Something like this?
> 
> All the best,
> 
>    Wolfram
> 
> ===
> 
> i2c: Make clear what the class field of i2c_adapter is good for
> 
> Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> ---
>  include/linux/i2c.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6/include/linux/i2c.h
> ===================================================================
> --- linux-2.6.orig/include/linux/i2c.h
> +++ linux-2.6/include/linux/i2c.h
> @@ -345,7 +345,7 @@ struct i2c_algorithm {
>  struct i2c_adapter {
>  	struct module *owner;
>  	unsigned int id;
> -	unsigned int class;
> +	unsigned int class;		  /* classes to allow probing for */
>  	const struct i2c_algorithm *algo; /* the algorithm to access the bus */
>  	void *algo_data;
> 

Sure, why not. Thanks for the patch, applied.

-- 
Jean Delvare

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c