Re: [PATCH 4/6]: i2c-pcf: Add a way for bus driver to ask for no smbus quick mode support.

[Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>]

On Thu, 16 Oct 2008 12:25:42 -0700 (PDT), David Miller wrote:
> From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> Date: Thu, 16 Oct 2008 12:13:15 +0200
> 
> > Hi David,
> > 
> > On Wed, 15 Oct 2008 14:34:52 -0700 (PDT), David Miller wrote:
> > > From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> > > Date: Wed, 15 Oct 2008 14:33:21 +0200
> > > 
> > > > For another, with the introduction of I2C classes several years ago,
> > > > I2C device drivers should no longer probe random I2C adapters.  
> > > 
> > > Jean, they do, that's why I wrote this change.
> > > 
> > > > They should only probe adapters which share a class bit with them,
> > > 
> > > The pcf driver sets the class bit used by FAN and temperature sensors,
> > > so the I2C layer goes poking around all of the standard address
> > > locations each of those drivers list.
> > 
> > By setting this class flag in your driver, you ask for these probes.
> 
> The PCF driver sets this flag by default, and my patch which you're
> reviewing here allows my sparc specific backend driver (the last
> patch in the series) to turn the bit off.
> 
> So you are arguing for exactly what I'm adding support for.

Please define "PCF driver" and "flag" in your previous sentence.
Apparently we are not speaking of the same driver nor the same flag, so
this discussion isn't going anywhere.

-- 
Jean Delvare

_______________________________________________
i2c mailing list
i2c-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org
http://lists.lm-sensors.org/mailman/listinfo/i2c