Re: [PATCH 3/4] imxmmc: add MX1 support

Re: [PATCH 3/4] imxmmc: add MX1 support

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 1239 bytes --]


Regarding the I2C-driver, I will try to clean up things as I see them.

> Is there some reason why Jean or the I2C mailing list couldn't have been
> sent this driver instead of just Ben (or was it, and they didn't respond)?

It was sent to the I2C list a couple of times (although sometimes Darius
made two posts, one to alkml and one to linux-i2c; probably a forgotten
CC, but it makes things a bit hard to track). It got quite some comments
there and the latest version, from what I can see, is here:

http://article.gmane.org/gmane.linux.drivers.i2c/2962

(which is _not_ the version Darius was posting in the last two days).

As you can see, it was already reviewed and tested here at Pengutronix,
and it works for us with MX1/2/3. IMHO, it just needs one to pick it up,
preferably via an I2C-tree. Now, as Ben volunteered to be the
I2C-embedded-maintainer, we were all waiting for him to put it into his
tree (for 6 weeks now; we were nagging). As he really seems to have
disappeared I wonder if Jean can pick it up this time?

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH 3/4] imxmmc: add MX1 support

[Jean Delvare]

Hi Wolfram,

On Wed, 25 Mar 2009 12:59:29 +0100, Wolfram Sang wrote:
> 
> Regarding the I2C-driver, I will try to clean up things as I see them.
> 
> > Is there some reason why Jean or the I2C mailing list couldn't have been
> > sent this driver instead of just Ben (or was it, and they didn't respond)?
> 
> It was sent to the I2C list a couple of times (although sometimes Darius
> made two posts, one to alkml and one to linux-i2c; probably a forgotten
> CC, but it makes things a bit hard to track). It got quite some comments
> there and the latest version, from what I can see, is here:
> 
> http://article.gmane.org/gmane.linux.drivers.i2c/2962
> 
> (which is _not_ the version Darius was posting in the last two days).
> 
> As you can see, it was already reviewed and tested here at Pengutronix,
> and it works for us with MX1/2/3. IMHO, it just needs one to pick it up,
> preferably via an I2C-tree. Now, as Ben volunteered to be the
> I2C-embedded-maintainer, we were all waiting for him to put it into his
> tree (for 6 weeks now; we were nagging). As he really seems to have
> disappeared I wonder if Jean can pick it up this time?

Yes, I can do this. All I need is the latest version of the patch, in
my mailbox, with all the Signed-off-by and Acked-by.

-- 
Jean Delvare

Re: [PATCH 3/4] imxmmc: add MX1 support

[Ben Dooks]

On Wed, Mar 25, 2009 at 12:59:29PM +0100, Wolfram Sang wrote:
> 
> Regarding the I2C-driver, I will try to clean up things as I see them.
> 
> > Is there some reason why Jean or the I2C mailing list couldn't have been
> > sent this driver instead of just Ben (or was it, and they didn't respond)?
> 
> It was sent to the I2C list a couple of times (although sometimes Darius
> made two posts, one to alkml and one to linux-i2c; probably a forgotten
> CC, but it makes things a bit hard to track). It got quite some comments
> there and the latest version, from what I can see, is here:
> 
> http://article.gmane.org/gmane.linux.drivers.i2c/2962
> 
> (which is _not_ the version Darius was posting in the last two days).
> 
> As you can see, it was already reviewed and tested here at Pengutronix,
> and it works for us with MX1/2/3. IMHO, it just needs one to pick it up,
> preferably via an I2C-tree. Now, as Ben volunteered to be the
> I2C-embedded-maintainer, we were all waiting for him to put it into his
> tree (for 6 weeks now; we were nagging). As he really seems to have
> disappeared I wonder if Jean can pick it up this time?

If that is really the patch you want, i'll add it to my tree and push
it.
 
> Regards,
> 
>    Wolfram
> 
> -- 
> Pengutronix e.K.                           | Wolfram Sang                |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |



-- 
Ben (ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'

Re: [PATCH 3/4] imxmmc: add MX1 support

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

> If that is really the patch you want, i'll add it to my tree and push
> it.

\o/ Yes, please push this one. It still applies to 2.6.29 flawlessly here.
Thanks!

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH 3/4] imxmmc: add MX1 support

[Ben Dooks]

On Wed, Mar 25, 2009 at 08:35:46PM +0100, Wolfram Sang wrote:
> > If that is really the patch you want, i'll add it to my tree and push
> > it.
> 
> \o/ Yes, please push this one. It still applies to 2.6.29 flawlessly here.
> Thanks!

Ok, I'm giving people until tommorow evening to raise any other
issues.


-- 
Ben (ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'