Re: [PATCH] i2c pca954x: support channel selection in sysfs.

Re: [PATCH] i2c pca954x: support channel selection in sysfs.

[Rodolfo Giometti]

On Sat, Aug 15, 2009 at 01:10:19AM +0200, Christian Herzig wrote:
> I'm a newbie in kernel hacking, and also in programming. All beginnings are difficult, so let's go ;-)
> 
> As groundwork i'll take the patches from Rodolfo Giometti (git://git.enneenne.com/linux-i2c-mux).
> 
> My patch doesn't contains the last one from Rodolfo (http://gitweb.enneenne.com/?p=linux-i2c-mux;a=commit;h=c597d7a621f705e6d2a3db7a551655346872e46c). With Rodolfos patch, my kernel doesn't compile anymore. In all probability, it's a mistake by my side.

I have to update my patches to the latest kernel as weel. :)

> I've added a channel attribute to pca954x driver, because i'd like getting and setting the channel from userspace by the use of sysfs.

Why do you need it?

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail: giometti-AVVDYK/kqiJWk0Htik3J/w@public.gmane.org
Linux Device Driver                          giometti-k2GhghHVRtY@public.gmane.org
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it

RE: [PATCH] i2c pca954x: support channel selection in sysfs.

[Herzig, Christian]

Hi Rodolfo,

Do I have problems with subscribing linux-i2c mailing list if my
messages are not published?

The need of setting and getting the channel out of the shell is for
debugging use only. Ok, if everything works properly, this is an
unessential attribute. I thought, maybe someone else is also interested,
so I _tried_ to publish this patch to Linux-i2c. Another reason, why
I've published this patch is, getting feedback from Linux community -
what is good, what is amiss, how implementation is better...

My plan is, loading adapters and devices on the basis of a flattened
device tree (Documentation/powerpc/booting-without-of.txt). At the time,
I don't know where to tackle this problem. Any hints for me?

Christian

-----Original Message-----
From: giometti-AVVDYK/kqiJWk0Htik3J/w@public.gmane.org [mailto:giometti-AVVDYK/kqiJWk0Htik3J/w@public.gmane.org] 
Sent: Saturday, August 15, 2009 9:37 AM
To: Herzig, Christian
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; chris-jmrfutXsf6TiB9QmIjCX8w@public.gmane.org
Subject: Re: [PATCH] i2c pca954x: support channel selection in sysfs.

On Sat, Aug 15, 2009 at 01:10:19AM +0200, Christian Herzig wrote:
> I'm a newbie in kernel hacking, and also in programming. All
beginnings are difficult, so let's go ;-)
> 
> As groundwork i'll take the patches from Rodolfo Giometti
(git://git.enneenne.com/linux-i2c-mux).
> 
> My patch doesn't contains the last one from Rodolfo
(http://gitweb.enneenne.com/?p=linux-i2c-mux;a=commit;h=c597d7a621f705e6
d2a3db7a551655346872e46c). With Rodolfos patch, my kernel doesn't
compile anymore. In all probability, it's a mistake by my side.


I have to update my patches to the latest kernel as weel. :)

> I've added a channel attribute to pca954x driver, because i'd like
getting and setting the channel from userspace by the use of sysfs.

Why do you need it?

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail: giometti-AVVDYK/kqiJWk0Htik3J/w@public.gmane.org
Linux Device Driver                          giometti-k2GhghHVRtY@public.gmane.org
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it

RE: [PATCH] i2c pca954x: support channel selection in sysfs.

[Herzig, Christian]

> Please, send patches to the latest i2c-mux support released, or better
> fixup i2c-mux to the latest kernel release and then post your patches
> against that kernel. ;)

I'll pull _your_ git-repo and generate patches against your latest
commit ;-) That should be done within a few hours. I can publish the
patches in a few days, actually I have a lot on one's plate. :-(
Let's talk about updating the patches for the latest Linux kernel mid of
September ;-) What do you think, are the patches going into the main
line? If yes, do you know the timetable?

Christian

Re: [PATCH] i2c pca954x: support channel selection in sysfs.

[Rodolfo Giometti]

On Mon, Aug 24, 2009 at 01:22:25PM +0200, Herzig, Christian wrote:
> > Please, send patches to the latest i2c-mux support released, or better
> > fixup i2c-mux to the latest kernel release and then post your patches
> > against that kernel. ;)
> 
> I'll pull _your_ git-repo and generate patches against your latest
> commit ;-) That should be done within a few hours. I can publish the
> patches in a few days, actually I have a lot on one's plate. :-(
> Let's talk about updating the patches for the latest Linux kernel mid of
> September ;-) What do you think, are the patches going into the main
> line? If yes, do you know the timetable?

Actually I have no idea about it. :'(

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail: giometti-AVVDYK/kqiJWk0Htik3J/w@public.gmane.org
Linux Device Driver                          giometti-k2GhghHVRtY@public.gmane.org
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it