public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Ben Dooks <ben-i2c-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>
To: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Cc: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	Yegor Yefremov
	<yegor_sub1-ZJVcf1zZPRSebONBosFW4Q@public.gmane.org>,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] fix PCA waitforcompletion() return value
Date: Wed, 29 Sep 2010 00:08:45 +0100	[thread overview]
Message-ID: <20100928230845.GN21564@trinity.fluff.org> (raw)
In-Reply-To: <20100922120848.6a43c5c2-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>

On Wed, Sep 22, 2010 at 12:08:48PM +0200, Jean Delvare wrote:
> Hi Wolfram,
> 
> On Wed, 22 Sep 2010 11:31:23 +0200, Wolfram Sang wrote:
> > On Wed, Sep 22, 2010 at 11:20:48AM +0200, Yegor Yefremov wrote:
> > > ret is still -1, if during the polling read_byte() returns at once
> > > with I2C_PCA_CON_SI set. So ret > 0 would lead *_waitforcompletion()
> > > to return 0, in spite of the proper behavior.
> > > 
> > > The routine was rewritten, so that ret has always a proper value,
> > > before returning.
> > > 
> > > Signed-off-by: Yegor Yefremov <yegorslists-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
> > > Reviewed-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> > 
> > Great! Jean, I think this is .36-relevant. Do you plan another
> > pull-request (hmm, there is still my clientdata-patch ;))? Should
> > probably go to stable, too.
> 
> Yes, I have a few i2c patches scheduled for 2.6.36 and plan to send
> Linus a pull request soon. I'm a little busy this week at work, and also
> due to a complete workstastion update so I must setup a number of
> things again and this temporarily hinders my efficiency.

Want me to push it, i've a few fixes too.

-- 
Ben

Q:      What's a light-year?
A:      One-third less calories than a regular year.

  parent reply	other threads:[~2010-09-28 23:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-22  9:20 [PATCH] fix PCA waitforcompletion() return value Yegor Yefremov
     [not found] ` <4C99CA70.2070109-ZJVcf1zZPRSebONBosFW4Q@public.gmane.org>
2010-09-22  9:31   ` Wolfram Sang
     [not found]     ` <20100922093123.GE2693-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-09-22 10:08       ` Jean Delvare
     [not found]         ` <20100922120848.6a43c5c2-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2010-09-28 23:08           ` Ben Dooks [this message]
     [not found]             ` <20100928230845.GN21564-SMNkleLxa3Z6Wcw2j4pizdi2O/JbrIOy@public.gmane.org>
2010-09-29  7:11               ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100928230845.GN21564@trinity.fluff.org \
    --to=ben-i2c-elnmno+kys3ytjvyw6ydsg@public.gmane.org \
    --cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    --cc=yegor_sub1-ZJVcf1zZPRSebONBosFW4Q@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox