From: Jesse Barnes <jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>
To: Seth Heasley <seth.heasley-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2.6.35.4] irq: irq and pci_ids patch for Intel Patsburg
Date: Fri, 15 Oct 2010 12:54:28 -0700 [thread overview]
Message-ID: <20101015125428.01120a8d@jbarnes-desktop> (raw)
In-Reply-To: <201010041327.15170.seth.heasley-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
On Mon, 4 Oct 2010 13:27:14 -0700
Seth Heasley <seth.heasley-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
> >> --- linux-2.6.35.4/drivers/i2c/busses/Kconfig.orig 2010-09-24
> >14:59:23.000000000 -0700
> >> +++ linux-2.6.35.4/drivers/i2c/busses/Kconfig 2010-09-24
> >14:59:42.000000000 -0700
> >> @@ -95,7 +95,7 @@
> >> ESB2
> >> ICH8
> >> ICH9
> >> - Tolapai
> >> + EP80579
> >> ICH10
> >> 3400/5 Series (PCH)
> >
> >How did this become "5_3400_SERIES" in the symbol names? Shouldn't it
> >be 3400_5_SERIES instead?
>
> The approved branding in pci.ids is 5/3400 Series, so I wanted to reflect that here. I've changed it in Kconfig as well as i2c-i801.c to be consistent.
>
> >> --- linux-2.6.35.4/drivers/i2c/busses/i2c-i801.c.orig 2010-09-24
> >14:57:55.000000000 -0700
> >> +++ linux-2.6.35.4/drivers/i2c/busses/i2c-i801.c 2010-09-24
> >14:59:13.000000000 -0700
> >> @@ -38,7 +38,7 @@
> >> 82801G (ICH7) 0x27da 32 hard yes yes
> >yes
> >> 82801H (ICH8) 0x283e 32 hard yes yes
> >yes
> >> 82801I (ICH9) 0x2930 32 hard yes yes
> >yes
> >> - Tolapai 0x5032 32 hard yes yes
> >yes
> >> + EP80579 0x5032 32 hard yes yes
> >yes
> >
> >Maybe keep "Tolapai" inside parentheses, as people may know the
> >platform by that name by now?
>
> Agreed. I've updated that in both places it's referenced. Final (hopefully) patch below:
>
> This patch updates the defines for Intel devices in include/linux/pci_ids.h, referenced in arch/x86/pci/irq.c and drivers/i2c/busses/i2c-i801.c, reflecting approved legal branding, and using fuller code-names for products under development.
>
> Signed-off-by: Seth Heasley <seth.heasley-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Applied this update, thanks.
Note that going forward I don't expect (or want!) patches to convert
the development names into marketing names. We should just add new
stuff with the development names (before the product ships) and leave
them that way to avoid unnecessary churn.
Thanks,
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2010-10-15 19:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-24 23:06 [PATCH 2.6.35.4] irq: irq and pci_ids patch for Intel Seth Heasley
[not found] ` <201009241606.11840.seth.heasley-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2010-09-25 11:30 ` Jean Delvare
[not found] ` <20100925133039.75e9ac71-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2010-09-25 15:13 ` Heasley, Seth
2010-10-04 20:27 ` [PATCH 2.6.35.4] irq: irq and pci_ids patch for Intel Patsburg Seth Heasley
2010-10-05 6:57 ` Jean Delvare
[not found] ` <201010041327.15170.seth.heasley-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2010-10-15 19:54 ` Jesse Barnes [this message]
2010-10-16 6:40 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101015125428.01120a8d@jbarnes-desktop \
--to=jbarnes-y1mf5jbuw70benjcbmcuuq@public.gmane.org \
--cc=khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=seth.heasley-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox