[PATCH] i2c: i2c-pca-platform: Change device name of request_irq

[PATCH] i2c: i2c-pca-platform: Change device name of request_irq

[Nobuhiro Iwamatsu]

i2c->adap.name shouldn't be used in request_irq.
Instead the driver name "i2c-pca-platform" should be used.

Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
CC: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
CC: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
---
 drivers/i2c/busses/i2c-pca-platform.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/i2c/busses/i2c-pca-platform.c b/drivers/i2c/busses/i2c-pca-platform.c
index ef5c784..38a6654 100644
--- a/drivers/i2c/busses/i2c-pca-platform.c
+++ b/drivers/i2c/busses/i2c-pca-platform.c
@@ -221,7 +221,7 @@ static int __devinit i2c_pca_pf_probe(struct platform_device *pdev)
 
 	if (irq) {
 		ret = request_irq(irq, i2c_pca_pf_handler,
-			IRQF_TRIGGER_FALLING, i2c->adap.name, i2c);
+			IRQF_TRIGGER_FALLING, pdev->name, i2c);
 		if (ret)
 			goto e_reqirq;
 	}
-- 
1.7.1

Re: [PATCH] i2c: i2c-pca-platform: Change device name of request_irq

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 666 bytes --]

Hi Nobuhiro (long time no see :))!

On Tue, Oct 19, 2010 at 11:45:31AM +0900, Nobuhiro Iwamatsu wrote:
> i2c->adap.name shouldn't be used in request_irq.
> Instead the driver name "i2c-pca-platform" should be used.
> 
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>

Looks good to me, thanks for fixing it (and to Jean for the guidance)

Acked-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

Back to holiday ;)

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH] i2c: i2c-pca-platform: Change device name of request_irq

[Jean Delvare]

On Tue, 19 Oct 2010 04:54:06 +0200, Wolfram Sang wrote:
> Hi Nobuhiro (long time no see :))!
> 
> On Tue, Oct 19, 2010 at 11:45:31AM +0900, Nobuhiro Iwamatsu wrote:
> > i2c->adap.name shouldn't be used in request_irq.
> > Instead the driver name "i2c-pca-platform" should be used.
> > 
> > Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>
> 
> Looks good to me, thanks for fixing it (and to Jean for the guidance)
> 
> Acked-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

Applied, thanks.

-- 
Jean Delvare