* Registering i2c devices with Device Tree
@ 2012-03-25 17:29 jonsmirl-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <CAKON4Oy5hSpDS4mpJHL-Nk95+9MMSwUqE6TXnvH2wn2XaNA68Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: jonsmirl-Re5JQEeQqe8AvxtiuMwx3w @ 2012-03-25 17:29 UTC (permalink / raw)
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA
All of the OF aware i2c bus drivers need to do:
of_i2c_register_devices(&alg_data->adapter);
Can this be moved to the common core code?
--
Jon Smirl
jonsmirl-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Registering i2c devices with Device Tree
[not found] ` <CAKON4Oy5hSpDS4mpJHL-Nk95+9MMSwUqE6TXnvH2wn2XaNA68Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2012-03-25 18:41 ` Jean Delvare
[not found] ` <20120325204150.20d3dcdb-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Jean Delvare @ 2012-03-25 18:41 UTC (permalink / raw)
To: jonsmirl-Re5JQEeQqe8AvxtiuMwx3w; +Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA
On Sun, 25 Mar 2012 13:29:51 -0400, jonsmirl-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> All of the OF aware i2c bus drivers need to do:
> of_i2c_register_devices(&alg_data->adapter);
>
> Can this be moved to the common core code?
I seem to recall that someone once proposed to move the call to
i2c-core, but the dependencies and #ifdef mess that resulted made me
reject it. That doesn't mean it can't be done, but just moving the call
is not the way.
--
Jean Delvare
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Registering i2c devices with Device Tree
[not found] ` <20120325204150.20d3dcdb-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
@ 2012-03-25 18:49 ` jonsmirl-Re5JQEeQqe8AvxtiuMwx3w
0 siblings, 0 replies; 3+ messages in thread
From: jonsmirl-Re5JQEeQqe8AvxtiuMwx3w @ 2012-03-25 18:49 UTC (permalink / raw)
To: Jean Delvare; +Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA
On Sun, Mar 25, 2012 at 2:41 PM, Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org> wrote:
> On Sun, 25 Mar 2012 13:29:51 -0400, jonsmirl-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
>> All of the OF aware i2c bus drivers need to do:
>> of_i2c_register_devices(&alg_data->adapter);
>>
>> Can this be moved to the common core code?
>
> I seem to recall that someone once proposed to move the call to
> i2c-core, but the dependencies and #ifdef mess that resulted made me
> reject it. That doesn't mean it can't be done, but just moving the call
> is not the way.
You could make the #ifdef go away by putting an #ifdef into
<linux/of_i2c.h> to stub out the call when CONFIG_OF is not defined.
I don't think the dependencies are as much of a problem anymore. I'm
bringing up a new ARM platform and didn't have any problem adding it.
I just noticed that is was duplicated in a dozen bus drivers.
>
> --
> Jean Delvare
--
Jon Smirl
jonsmirl-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-03-25 18:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-25 17:29 Registering i2c devices with Device Tree jonsmirl-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <CAKON4Oy5hSpDS4mpJHL-Nk95+9MMSwUqE6TXnvH2wn2XaNA68Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-03-25 18:41 ` Jean Delvare
[not found] ` <20120325204150.20d3dcdb-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-03-25 18:49 ` jonsmirl-Re5JQEeQqe8AvxtiuMwx3w
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox