[PATCH 1/1] i2c: exynos5: Use reinit_completion instead of INIT_COMPLETION

[PATCH 1/1] i2c: exynos5: Use reinit_completion instead of INIT_COMPLETION

[Sachin Kamat]

INIT_COMPLETION was replaced by reinit_completion vide commit 2c9627cca471
("tree-wide: use reinit_completion instead of INIT_COMPLETION"). Use it to
avoid the following build error:
drivers/i2c/busses/i2c-exynos5.c:538:9: error:
undefined identifier 'INIT_COMPLETION'

Signed-off-by: Sachin Kamat <sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Naveen Krishna Chatradhi <ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
 drivers/i2c/busses/i2c-exynos5.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/i2c/busses/i2c-exynos5.c b/drivers/i2c/busses/i2c-exynos5.c
index aca3991b7636..d4193000643d 100644
--- a/drivers/i2c/busses/i2c-exynos5.c
+++ b/drivers/i2c/busses/i2c-exynos5.c
@@ -535,7 +535,7 @@ static int exynos5_i2c_xfer_msg(struct exynos5_i2c *i2c,
 	i2c->msg_ptr = 0;
 	i2c->trans_done = 0;
 
-	INIT_COMPLETION(i2c->msg_complete);
+	reinit_completion(&i2c->msg_complete);
 
 	exynos5_i2c_message_start(i2c, stop);
 
-- 
1.7.9.5

Re: [PATCH 1/1] i2c: exynos5: Use reinit_completion instead of INIT_COMPLETION

[Naveen Krishna Ch]

On 5 November 2013 14:57, Sachin Kamat <sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> INIT_COMPLETION was replaced by reinit_completion vide commit 2c9627cca471
> ("tree-wide: use reinit_completion instead of INIT_COMPLETION"). Use it to
> avoid the following build error:
> drivers/i2c/busses/i2c-exynos5.c:538:9: error:
> undefined identifier 'INIT_COMPLETION'
>
> Signed-off-by: Sachin Kamat <sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Thanks for figuring this out pretty soon.

> Cc: Naveen Krishna Chatradhi <ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Acked-by: Naveen Krishna Chatradhi <ch.naveen-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>


> ---
>  drivers/i2c/busses/i2c-exynos5.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-exynos5.c b/drivers/i2c/busses/i2c-exynos5.c
> index aca3991b7636..d4193000643d 100644
> --- a/drivers/i2c/busses/i2c-exynos5.c
> +++ b/drivers/i2c/busses/i2c-exynos5.c
> @@ -535,7 +535,7 @@ static int exynos5_i2c_xfer_msg(struct exynos5_i2c *i2c,
>         i2c->msg_ptr = 0;
>         i2c->trans_done = 0;
>
> -       INIT_COMPLETION(i2c->msg_complete);
> +       reinit_completion(&i2c->msg_complete);
>
>         exynos5_i2c_message_start(i2c, stop);
>
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



-- 
Shine bright,
(: Nav :)

Re: [PATCH 1/1] i2c: exynos5: Use reinit_completion instead of INIT_COMPLETION

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

On Tue, Nov 05, 2013 at 02:57:10PM +0530, Sachin Kamat wrote:
> INIT_COMPLETION was replaced by reinit_completion vide commit 2c9627cca471
> ("tree-wide: use reinit_completion instead of INIT_COMPLETION"). Use it to
> avoid the following build error:
> drivers/i2c/busses/i2c-exynos5.c:538:9: error:
> undefined identifier 'INIT_COMPLETION'
> 
> Signed-off-by: Sachin Kamat <sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

You can ignore this topic. akpm (who has the change in his tree) usually
takes care of this.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 1/1] i2c: exynos5: Use reinit_completion instead of INIT_COMPLETION

[Sachin Kamat]

On 5 November 2013 15:40, Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> wrote:
> On Tue, Nov 05, 2013 at 02:57:10PM +0530, Sachin Kamat wrote:
>> INIT_COMPLETION was replaced by reinit_completion vide commit 2c9627cca471
>> ("tree-wide: use reinit_completion instead of INIT_COMPLETION"). Use it to
>> avoid the following build error:
>> drivers/i2c/busses/i2c-exynos5.c:538:9: error:
>> undefined identifier 'INIT_COMPLETION'
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>
> You can ignore this topic. akpm (who has the change in his tree) usually
> takes care of this.
>

This option does not show up with allyesconfig. Unless one uses
exynos_defconfig and specifically
enables this option, this error will not show up.

-- 
With warm regards,
Sachin

Re: [PATCH 1/1] i2c: exynos5: Use reinit_completion instead of INIT_COMPLETION

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 922 bytes --]

On Tue, Nov 05, 2013 at 03:51:58PM +0530, Sachin Kamat wrote:
> On 5 November 2013 15:40, Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> wrote:
> > On Tue, Nov 05, 2013 at 02:57:10PM +0530, Sachin Kamat wrote:
> >> INIT_COMPLETION was replaced by reinit_completion vide commit 2c9627cca471
> >> ("tree-wide: use reinit_completion instead of INIT_COMPLETION"). Use it to
> >> avoid the following build error:
> >> drivers/i2c/busses/i2c-exynos5.c:538:9: error:
> >> undefined identifier 'INIT_COMPLETION'
> >>
> >> Signed-off-by: Sachin Kamat <sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> >
> > You can ignore this topic. akpm (who has the change in his tree) usually
> > takes care of this.
> >
> 
> This option does not show up with allyesconfig. Unless one uses
> exynos_defconfig and specifically
> enables this option, this error will not show up.

sed will find them all.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 1/1] i2c: exynos5: Use reinit_completion instead of INIT_COMPLETION

[Sachin Kamat]

On 5 November 2013 16:26, Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> wrote:
> On Tue, Nov 05, 2013 at 03:51:58PM +0530, Sachin Kamat wrote:
>> On 5 November 2013 15:40, Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> wrote:
>> > On Tue, Nov 05, 2013 at 02:57:10PM +0530, Sachin Kamat wrote:
>> >> INIT_COMPLETION was replaced by reinit_completion vide commit 2c9627cca471
>> >> ("tree-wide: use reinit_completion instead of INIT_COMPLETION"). Use it to
>> >> avoid the following build error:
>> >> drivers/i2c/busses/i2c-exynos5.c:538:9: error:
>> >> undefined identifier 'INIT_COMPLETION'
>> >>
>> >> Signed-off-by: Sachin Kamat <sachin.kamat-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>> >
>> > You can ignore this topic. akpm (who has the change in his tree) usually
>> > takes care of this.
>> >
>>
>> This option does not show up with allyesconfig. Unless one uses
>> exynos_defconfig and specifically
>> enables this option, this error will not show up.
>
> sed will find them all.

Yes, that would do. However, since I have already found and fixed
this, wouldn't it save
some time and effort for Andrew if he simply applies this?

-- 
With warm regards,
Sachin

Re: [PATCH 1/1] i2c: exynos5: Use reinit_completion instead of INIT_COMPLETION

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 339 bytes --]


> > sed will find them all.
> 
> Yes, that would do. However, since I have already found and fixed
> this, wouldn't it save
> some time and effort for Andrew if he simply applies this?

Nope, running sed with git commit -a is the same effort regardless how
many hits it produces. And it is much cleaner to just have one patch.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH 1/1] i2c: exynos5: Use reinit_completion instead of INIT_COMPLETION

[Sachin Kamat]

On 5 November 2013 16:54, Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> wrote:
>
>> > sed will find them all.
>>
>> Yes, that would do. However, since I have already found and fixed
>> this, wouldn't it save
>> some time and effort for Andrew if he simply applies this?
>
> Nope, running sed with git commit -a is the same effort regardless how
> many hits it produces. And it is much cleaner to just have one patch.

Oh OK. I wasn't aware of this. Thanks :)

-- 
With warm regards,
Sachin