* [PATCH] i2c: nomadik: Silence compiler warning
@ 2014-02-23 16:42 Ulf Hansson
[not found] ` <1393173726-29479-1-git-send-email-ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Ulf Hansson @ 2014-02-23 16:42 UTC (permalink / raw)
To: Wolfram Sang, linux-i2c-u79uwXL29TY76Z2rM5mHXA
Cc: Linus Walleij, Alessandro Rubini,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Ulf Hansson
Commit "i2c: nomadik: Fixup deployment of runtime PM" introduced a
compiler warning for !CONFIG_PM. Let's fix it here.
Signed-off-by: Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
---
Wolfram, currently one of the queued patches for i2c nomadik introduced a
compiler warning. I decided to add a fixup patch on top of these instead of
you dropping them and me resending new versions of the already applied patches.
If you think it's better to drop the queued patches and to resend new verions,
please tell me.
---
drivers/i2c/busses/i2c-nomadik.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c
index 8082f5c..5f47454 100644
--- a/drivers/i2c/busses/i2c-nomadik.c
+++ b/drivers/i2c/busses/i2c-nomadik.c
@@ -895,7 +895,7 @@ static int nmk_i2c_resume_early(struct device *dev)
}
#endif
-#if CONFIG_PM
+#ifdef CONFIG_PM
static int nmk_i2c_runtime_suspend(struct device *dev)
{
struct amba_device *adev = to_amba_device(dev);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i2c: nomadik: Silence compiler warning
[not found] ` <1393173726-29479-1-git-send-email-ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
@ 2014-02-24 9:14 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2014-02-24 9:14 UTC (permalink / raw)
To: Ulf Hansson
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, Linus Walleij,
Alessandro Rubini,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
[-- Attachment #1: Type: text/plain, Size: 764 bytes --]
On Sun, Feb 23, 2014 at 05:42:06PM +0100, Ulf Hansson wrote:
> Commit "i2c: nomadik: Fixup deployment of runtime PM" introduced a
> compiler warning for !CONFIG_PM. Let's fix it here.
>
> Signed-off-by: Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
>
> Wolfram, currently one of the queued patches for i2c nomadik introduced a
> compiler warning. I decided to add a fixup patch on top of these instead of
> you dropping them and me resending new versions of the already applied patches.
>
> If you think it's better to drop the queued patches and to resend new verions,
> please tell me.
I'll fold it into the causing patch since I haven't pushed out yet. I
was waiting for Linus response to the bus speed question.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-24 9:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-23 16:42 [PATCH] i2c: nomadik: Silence compiler warning Ulf Hansson
[not found] ` <1393173726-29479-1-git-send-email-ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2014-02-24 9:14 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox