* Re: [PATCH 22/33] ARM: shmobile: Use r8a7740 suffix for i2c, mmcif, fsi2 compat strings [not found] ` <5c53f50c50badff499568a703467c3c9f23f9bfd.1398216022.git.horms+renesas@verge.net.au> @ 2014-04-23 7:09 ` Geert Uytterhoeven [not found] ` <CAMuHMdUA+wJmgn0P_q38ri7_TAq7zha-ekSUrvdpntG5gFv56Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Geert Uytterhoeven @ 2014-04-23 7:09 UTC (permalink / raw) To: Simon Horman Cc: Linux-sh list, Magnus Damm, Ulrich Hecht, linux-arm-kernel@lists.infradead.org, Wolfram Sang, Linux I2C On Wed, Apr 23, 2014 at 3:25 AM, Simon Horman <horms+renesas@verge.net.au> wrote: > From: Ulrich Hecht <ulrich.hecht@gmail.com> > > Add "renesas,*-r8a7740" to the compatible strings for consistency with other > devices. > diff --git a/arch/arm/boot/dts/r8a7740.dtsi b/arch/arm/boot/dts/r8a7740.dtsi > index 8280884..9f65986 100644 > --- a/arch/arm/boot/dts/r8a7740.dtsi > +++ b/arch/arm/boot/dts/r8a7740.dtsi > @@ -126,7 +126,7 @@ > - compatible = "renesas,rmobile-iic"; > + compatible = "renesas,iic-r8a7740", "renesas,rmobile-iic"; I see an opportunity for improvement here: this driver doesn't seem to have any bindings documented under Documentation/devicetree/bindings/? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <CAMuHMdUA+wJmgn0P_q38ri7_TAq7zha-ekSUrvdpntG5gFv56Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>]
* Re: [PATCH 22/33] ARM: shmobile: Use r8a7740 suffix for i2c, mmcif, fsi2 compat strings [not found] ` <CAMuHMdUA+wJmgn0P_q38ri7_TAq7zha-ekSUrvdpntG5gFv56Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> @ 2014-04-23 7:18 ` Wolfram Sang 2014-04-23 7:26 ` Geert Uytterhoeven 0 siblings, 1 reply; 3+ messages in thread From: Wolfram Sang @ 2014-04-23 7:18 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Simon Horman, Linux-sh list, Magnus Damm, Ulrich Hecht, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Linux I2C [-- Attachment #1: Type: text/plain, Size: 1036 bytes --] On Wed, Apr 23, 2014 at 09:09:49AM +0200, Geert Uytterhoeven wrote: > On Wed, Apr 23, 2014 at 3:25 AM, Simon Horman > <horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org> wrote: > > From: Ulrich Hecht <ulrich.hecht-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> > > > > Add "renesas,*-r8a7740" to the compatible strings for consistency with other > > devices. > > > diff --git a/arch/arm/boot/dts/r8a7740.dtsi b/arch/arm/boot/dts/r8a7740.dtsi > > index 8280884..9f65986 100644 > > --- a/arch/arm/boot/dts/r8a7740.dtsi > > +++ b/arch/arm/boot/dts/r8a7740.dtsi > > @@ -126,7 +126,7 @@ > > > - compatible = "renesas,rmobile-iic"; > > + compatible = "renesas,iic-r8a7740", "renesas,rmobile-iic"; > > I see an opportunity for improvement here: this driver doesn't seem to have > any bindings documented under Documentation/devicetree/bindings/? I am brushing up this driver currently, so consider it done. Just waiting for a minor email issue to be solved before I can send out patches. [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 836 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 22/33] ARM: shmobile: Use r8a7740 suffix for i2c, mmcif, fsi2 compat strings 2014-04-23 7:18 ` Wolfram Sang @ 2014-04-23 7:26 ` Geert Uytterhoeven 0 siblings, 0 replies; 3+ messages in thread From: Geert Uytterhoeven @ 2014-04-23 7:26 UTC (permalink / raw) To: Wolfram Sang Cc: Simon Horman, Linux-sh list, Magnus Damm, Ulrich Hecht, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Linux I2C Hi Wolfram, On Wed, Apr 23, 2014 at 9:18 AM, Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org> wrote: >> > - compatible = "renesas,rmobile-iic"; >> > + compatible = "renesas,iic-r8a7740", "renesas,rmobile-iic"; >> >> I see an opportunity for improvement here: this driver doesn't seem to have >> any bindings documented under Documentation/devicetree/bindings/? > > I am brushing up this driver currently, so consider it done. Just That's great to hear, thanks! > waiting for a minor email issue to be solved before I can send out > patches. Good luck! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-23 7:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1398216022.git.horms+renesas@verge.net.au>
[not found] ` <5c53f50c50badff499568a703467c3c9f23f9bfd.1398216022.git.horms+renesas@verge.net.au>
2014-04-23 7:09 ` [PATCH 22/33] ARM: shmobile: Use r8a7740 suffix for i2c, mmcif, fsi2 compat strings Geert Uytterhoeven
[not found] ` <CAMuHMdUA+wJmgn0P_q38ri7_TAq7zha-ekSUrvdpntG5gFv56Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-04-23 7:18 ` Wolfram Sang
2014-04-23 7:26 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox