From: Jean Delvare <jdelvare@suse.de>
To: linux-watchdog@vger.kernel.org
Cc: Linux I2C <linux-i2c@vger.kernel.org>,
Jim Davis <jim.epost@gmail.com>,
Matt Fleming <matt.fleming@intel.com>,
Guenter Roeck <linux@roeck-us.net>,
Lee Jones <lee.jones@linaro.org>,
Wim Van Sebroeck <wim@iguana.be>
Subject: [PATCH] watchdog: iTCO_wdt: Fix unmet dependency in select
Date: Fri, 25 Sep 2015 10:10:45 +0200 [thread overview]
Message-ID: <20150925101045.06062b59@endymion.delvare> (raw)
ITCO_WDT selects I2C_I801 but does not select its dependencies (I2C.)
This can result in link-time failures:
drivers/built-in.o: In function `i801_remove':
i2c-i801.c:(.text+0x1a6126): undefined reference to `i2c_del_adapter'
drivers/built-in.o: In function `dmi_check_onboard_devices':
i2c-i801.c:(.text+0x1a7531): undefined reference to `i2c_new_device'
drivers/built-in.o: In function `i801_probe':
i2c-i801.c:(.text+0x1a7aa8): undefined reference to `i2c_add_adapter'
i2c-i801.c:(.text+0x1a7e14): undefined reference to `i2c_new_device'
So we must select I2C as well.
Reported-by: Jim Davis <jim.epost@gmail.com>
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Fixes: 2a7a0e9bf7 ("watchdog: iTCO_wdt: Add support for TCO on Intel Sunrisepoint")
Cc: Matt Fleming <matt.fleming@intel.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Wim Van Sebroeck <wim@iguana.be>
---
drivers/watchdog/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-4.3-rc2.orig/drivers/watchdog/Kconfig 2015-09-24 11:43:29.959432358 +0200
+++ linux-4.3-rc2/drivers/watchdog/Kconfig 2015-09-25 09:56:20.518840112 +0200
@@ -818,6 +818,7 @@ config ITCO_WDT
depends on (X86 || IA64) && PCI
select WATCHDOG_CORE
select LPC_ICH if !EXPERT
+ select I2C if !EXPERT
select I2C_I801 if !EXPERT
---help---
Hardware driver for the intel TCO timer based watchdog devices.
--
Jean Delvare
SUSE L3 Support
next reply other threads:[~2015-09-25 8:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 8:10 Jean Delvare [this message]
2015-09-25 13:29 ` [PATCH] watchdog: iTCO_wdt: Fix unmet dependency in select Guenter Roeck
[not found] ` <56054C2E.9010703-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2015-09-25 14:02 ` Jean Delvare
[not found] ` <1443189749.4919.2.camel-H7Kp9ZFCxt/N0uC3ymp8PA@public.gmane.org>
2015-09-25 14:45 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150925101045.06062b59@endymion.delvare \
--to=jdelvare@suse.de \
--cc=jim.epost@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matt.fleming@intel.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox