[PATCH] MAINTAINERS: i2c: mark also subdirectories as maintained

[PATCH] MAINTAINERS: i2c: mark also subdirectories as maintained

[Wolfram Sang]

Otherwise get_maintainer.pl will fall back to git history and CC
more people than needed.

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Acked-by: Lee Jones <lee.jones@linaro.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 2f23aab10398bb..c3f01dc36b26b4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5090,6 +5090,7 @@ S:	Maintained
 F:	Documentation/devicetree/bindings/i2c/
 F:	Documentation/i2c/
 F:	drivers/i2c/
+F:	drivers/i2c/*/
 F:	include/linux/i2c.h
 F:	include/linux/i2c-*.h
 F:	include/uapi/linux/i2c.h
-- 
2.1.4

Re: [PATCH] MAINTAINERS: i2c: mark also subdirectories as maintained

[Joe Perches]

On Thu, 2015-10-29 at 08:25 +0100, Wolfram Sang wrote:
> Otherwise get_maintainer.pl will fall back to git history and CC
> more people than needed.
> 
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> Acked-by: Lee Jones <lee.jones@linaro.org>
> ---
>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2f23aab10398bb..c3f01dc36b26b4 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5090,6 +5090,7 @@ S:	Maintained
>  F:	Documentation/devicetree/bindings/i2c/
>  F:	Documentation/i2c/
>  F:	drivers/i2c/
> +F:	drivers/i2c/*/
>  F:	include/linux/i2c.h
>  F:	include/linux/i2c-*.h
>  F:	include/uapi/linux/i2c.h

Maybe something like this too:

diff --git a/MAINTAINERS b/MAINTAINERS
index a2d50fe..ff0ca88 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -93,6 +93,14 @@ Descriptions of section entries:
 	   F:	drivers/net/*	all files in drivers/net, but not below
 	   F:	*/net/*		all files in "any top level directory"/net
 	   One pattern per line.  Multiple F: lines acceptable.
+	   The scripts/get_maintainer.pl tool has a quirk about subdirectories.
+	   If the file pattern is for a directory, then any subdirectories of
+	   the parent directory should also be specified.  For instance:
+		F:	drivers/i2c/
+		F:	drivers/i2c/*/
+	   Otherwise, the scripts/get_maintainer.pl tool by default will use
+	   git history to add additional people that have "Signed-off-by:"
+	   style signatures on commits to files in those subdirectories.
 	N: Files and directories with regex patterns.
 	   N:	[^a-z]tegra	all files whose path contains the word tegra
 	   One pattern per line.  Multiple N: lines acceptable.

Re: [PATCH] MAINTAINERS: i2c: mark also subdirectories as maintained

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 588 bytes --]

> +	   The scripts/get_maintainer.pl tool has a quirk about subdirectories.
> +	   If the file pattern is for a directory, then any subdirectories of
> +	   the parent directory should also be specified.  For instance:
> +		F:	drivers/i2c/
> +		F:	drivers/i2c/*/
> +	   Otherwise, the scripts/get_maintainer.pl tool by default will use
> +	   git history to add additional people that have "Signed-off-by:"
> +	   style signatures on commits to files in those subdirectories.

I'd be fine with the change. The patch description should probably state
why fixing the tool is not worth it.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] MAINTAINERS: i2c: mark also subdirectories as maintained

[Joe Perches]

On Thu, 2015-10-29 at 16:52 +0100, Wolfram Sang wrote:
> > +	   The scripts/get_maintainer.pl tool has a quirk about subdirectories.
> > +	   If the file pattern is for a directory, then any subdirectories of
> > +	   the parent directory should also be specified.  For instance:
> > +		F:	drivers/i2c/
> > +		F:	drivers/i2c/*/
> > +	   Otherwise, the scripts/get_maintainer.pl tool by default will use
> > +	   git history to add additional people that have "Signed-off-by:"
> > +	   style signatures on commits to files in those subdirectories.
> 
> I'd be fine with the change. The patch description should probably state
> why fixing the tool is not worth it.

Not worth it vs inappropriate (arch/arm, etc...)

Maybe the wording around "quirk" could be improved or expanded.

Any suggestions?

Re: [PATCH] MAINTAINERS: i2c: mark also subdirectories as maintained

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 294 bytes --]

On Thu, Oct 29, 2015 at 08:25:48AM +0100, Wolfram Sang wrote:
> Otherwise get_maintainer.pl will fall back to git history and CC
> more people than needed.
> 
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> Acked-by: Lee Jones <lee.jones@linaro.org>

Applied to for-next, thanks!


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]