* [PATCH] i2c: rk3x: populate correct variable for sda_falling_time
@ 2015-11-25 15:58 Wolfram Sang
2015-11-25 16:08 ` Doug Anderson
2015-11-30 13:27 ` Wolfram Sang
0 siblings, 2 replies; 3+ messages in thread
From: Wolfram Sang @ 2015-11-25 15:58 UTC (permalink / raw)
To: linux-i2c; +Cc: linux-rockchip, Wolfram Sang
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/i2c/busses/i2c-rk3x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
index c1935ebd6a9c38..9096d17beb5bb0 100644
--- a/drivers/i2c/busses/i2c-rk3x.c
+++ b/drivers/i2c/busses/i2c-rk3x.c
@@ -908,7 +908,7 @@ static int rk3x_i2c_probe(struct platform_device *pdev)
&i2c->scl_fall_ns))
i2c->scl_fall_ns = 300;
if (of_property_read_u32(pdev->dev.of_node, "i2c-sda-falling-time-ns",
- &i2c->scl_fall_ns))
+ &i2c->sda_fall_ns))
i2c->sda_fall_ns = i2c->scl_fall_ns;
strlcpy(i2c->adap.name, "rk3x-i2c", sizeof(i2c->adap.name));
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: rk3x: populate correct variable for sda_falling_time
2015-11-25 15:58 [PATCH] i2c: rk3x: populate correct variable for sda_falling_time Wolfram Sang
@ 2015-11-25 16:08 ` Doug Anderson
2015-11-30 13:27 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Doug Anderson @ 2015-11-25 16:08 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-i2c@vger.kernel.org, open list:ARM/Rockchip SoC...
Wolfram,
On Wed, Nov 25, 2015 at 7:58 AM, Wolfram Sang <wsa@the-dreams.de> wrote:
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
> drivers/i2c/busses/i2c-rk3x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c
> index c1935ebd6a9c38..9096d17beb5bb0 100644
> --- a/drivers/i2c/busses/i2c-rk3x.c
> +++ b/drivers/i2c/busses/i2c-rk3x.c
> @@ -908,7 +908,7 @@ static int rk3x_i2c_probe(struct platform_device *pdev)
> &i2c->scl_fall_ns))
> i2c->scl_fall_ns = 300;
> if (of_property_read_u32(pdev->dev.of_node, "i2c-sda-falling-time-ns",
> - &i2c->scl_fall_ns))
> + &i2c->sda_fall_ns))
> i2c->sda_fall_ns = i2c->scl_fall_ns;
>
> strlcpy(i2c->adap.name, "rk3x-i2c", sizeof(i2c->adap.name));
Thanks for the fix! In my dts files I never specified
"i2c-sda-falling-time-ns" (since realistically SDA and SCL nearly
always fall with the same rate) so I never saw the issue. ...but it's
definitely a good idea to fix.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: rk3x: populate correct variable for sda_falling_time
2015-11-25 15:58 [PATCH] i2c: rk3x: populate correct variable for sda_falling_time Wolfram Sang
2015-11-25 16:08 ` Doug Anderson
@ 2015-11-30 13:27 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2015-11-30 13:27 UTC (permalink / raw)
To: linux-i2c; +Cc: linux-rockchip
[-- Attachment #1: Type: text/plain, Size: 146 bytes --]
On Wed, Nov 25, 2015 at 04:58:18PM +0100, Wolfram Sang wrote:
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Applied to for-current, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-11-30 13:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-25 15:58 [PATCH] i2c: rk3x: populate correct variable for sda_falling_time Wolfram Sang
2015-11-25 16:08 ` Doug Anderson
2015-11-30 13:27 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox