public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	linux-i2c@vger.kernel.org
Subject: Re: [PATCH v2 0/3] i2c: designware-pci: refactor and add Merrifield support
Date: Sun, 19 Jun 2016 20:17:43 +0200	[thread overview]
Message-ID: <20160619181742.GK2933@tetsubishi> (raw)
In-Reply-To: <1466359691.30123.171.camel@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 904 bytes --]

> -        * On Intel Merrifield the i2c busses are enumerated [1..7]. So,
> we add
> -        * 1 to shift the default range. Besides that the first PCI slot
> -        * provides 4 functions, that's why we have to add 0 to the head
> slot
> -        * and 4 to the tail one.
> +        * On Intel Merrifield the user visible i2c busses are
> enumerated
> +        * [1..7]. So, we add 1 to shift the default range. Besides that
> the
> +        * first PCI slot provides 4 functions, that's why we have to
> add 0 to
> +        * the fisrt slot and 4 to the next one.
>          */
>         switch (PCI_SLOT(pdev->devfn)) {
>         case 8:
> 
> Should I send a new patch or you can fold it?

I already pushed out. Also, this patch has line break problems.

So, send an incremental one.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      reply	other threads:[~2016-06-19 19:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-15 15:05 [PATCH v2 0/3] i2c: designware-pci: refactor and add Merrifield support Andy Shevchenko
2016-06-15 15:05 ` [PATCH v2 1/3] i2c: designware-pci: Make bus number allocation robust Andy Shevchenko
2016-06-15 15:05 ` [PATCH v2 2/3] i2c: designware-pci: Introduce Merrifield support Andy Shevchenko
2016-06-15 15:05 ` [PATCH v2 3/3] i2c: designware-pci: Sort header block alphabetically Andy Shevchenko
2016-06-16  7:44 ` [PATCH v2 0/3] i2c: designware-pci: refactor and add Merrifield support Jarkko Nikula
2016-06-19 17:42 ` Wolfram Sang
2016-06-19 18:08   ` Andy Shevchenko
2016-06-19 18:17     ` Wolfram Sang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160619181742.GK2933@tetsubishi \
    --to=wsa@the-dreams.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox