* [PATCH -next] i2c: mux: mlxcpld: remove unused including <linux/version.h>
@ 2017-01-12 14:29 Wei Yongjun
2017-01-12 14:36 ` Peter Rosin
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Wei Yongjun @ 2017-01-12 14:29 UTC (permalink / raw)
To: Vadim Pasternak, Michael Shych, Wolfram Sang, Peter Rosin
Cc: Wei Yongjun, linux-i2c
From: Wei Yongjun <weiyongjun1@huawei.com>
Remove including <linux/version.h> that don't need it.
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/i2c/muxes/i2c-mux-mlxcpld.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/i2c/muxes/i2c-mux-mlxcpld.c b/drivers/i2c/muxes/i2c-mux-mlxcpld.c
index b7ca249..e53f2ab 100644
--- a/drivers/i2c/muxes/i2c-mux-mlxcpld.c
+++ b/drivers/i2c/muxes/i2c-mux-mlxcpld.c
@@ -40,7 +40,6 @@
#include <linux/module.h>
#include <linux/platform_device.h>
#include <linux/slab.h>
-#include <linux/version.h>
#include <linux/i2c/mlxcpld.h>
#define CPLD_MUX_MAX_NCHANS 8
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] i2c: mux: mlxcpld: remove unused including <linux/version.h>
2017-01-12 14:29 [PATCH -next] i2c: mux: mlxcpld: remove unused including <linux/version.h> Wei Yongjun
@ 2017-01-12 14:36 ` Peter Rosin
2017-01-12 15:40 ` Vadim Pasternak
2017-02-09 16:29 ` Wolfram Sang
2 siblings, 0 replies; 4+ messages in thread
From: Peter Rosin @ 2017-01-12 14:36 UTC (permalink / raw)
To: Wei Yongjun, Vadim Pasternak, Michael Shych, Wolfram Sang
Cc: Wei Yongjun, linux-i2c
On 2017-01-12 15:29, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Remove including <linux/version.h> that don't need it.
s/don't need it/is not needed/
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/i2c/muxes/i2c-mux-mlxcpld.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/i2c/muxes/i2c-mux-mlxcpld.c b/drivers/i2c/muxes/i2c-mux-mlxcpld.c
> index b7ca249..e53f2ab 100644
> --- a/drivers/i2c/muxes/i2c-mux-mlxcpld.c
> +++ b/drivers/i2c/muxes/i2c-mux-mlxcpld.c
> @@ -40,7 +40,6 @@
> #include <linux/module.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
I don't see a reason to keep slab.h either?
Cheers,
peda
> -#include <linux/version.h>
> #include <linux/i2c/mlxcpld.h>
>
> #define CPLD_MUX_MAX_NCHANS 8
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH -next] i2c: mux: mlxcpld: remove unused including <linux/version.h>
2017-01-12 14:29 [PATCH -next] i2c: mux: mlxcpld: remove unused including <linux/version.h> Wei Yongjun
2017-01-12 14:36 ` Peter Rosin
@ 2017-01-12 15:40 ` Vadim Pasternak
2017-02-09 16:29 ` Wolfram Sang
2 siblings, 0 replies; 4+ messages in thread
From: Vadim Pasternak @ 2017-01-12 15:40 UTC (permalink / raw)
To: Wei Yongjun, Michael Shych, Wolfram Sang, Peter Rosin
Cc: Wei Yongjun, linux-i2c@vger.kernel.org
> -----Original Message-----
> From: Wei Yongjun [mailto:weiyj.lk@gmail.com]
> Sent: Thursday, January 12, 2017 4:29 PM
> To: Vadim Pasternak <vadimp@mellanox.com>; Michael Shych
> <michaelsh@mellanox.com>; Wolfram Sang <wsa@the-dreams.de>; Peter
> Rosin <peda@axentia.se>
> Cc: Wei Yongjun <weiyongjun1@huawei.com>; linux-i2c@vger.kernel.org
> Subject: [PATCH -next] i2c: mux: mlxcpld: remove unused including
> <linux/version.h>
>
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Remove including <linux/version.h> that don't need it.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
Acked-by: Vadim Pasternak <vadimp@mellanox.com>
> drivers/i2c/muxes/i2c-mux-mlxcpld.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/i2c/muxes/i2c-mux-mlxcpld.c b/drivers/i2c/muxes/i2c-
> mux-mlxcpld.c
> index b7ca249..e53f2ab 100644
> --- a/drivers/i2c/muxes/i2c-mux-mlxcpld.c
> +++ b/drivers/i2c/muxes/i2c-mux-mlxcpld.c
> @@ -40,7 +40,6 @@
> #include <linux/module.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> -#include <linux/version.h>
> #include <linux/i2c/mlxcpld.h>
>
> #define CPLD_MUX_MAX_NCHANS 8
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] i2c: mux: mlxcpld: remove unused including <linux/version.h>
2017-01-12 14:29 [PATCH -next] i2c: mux: mlxcpld: remove unused including <linux/version.h> Wei Yongjun
2017-01-12 14:36 ` Peter Rosin
2017-01-12 15:40 ` Vadim Pasternak
@ 2017-02-09 16:29 ` Wolfram Sang
2 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2017-02-09 16:29 UTC (permalink / raw)
To: Wei Yongjun
Cc: Vadim Pasternak, Michael Shych, Peter Rosin, Wei Yongjun,
linux-i2c
[-- Attachment #1: Type: text/plain, Size: 263 bytes --]
On Thu, Jan 12, 2017 at 02:29:04PM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Remove including <linux/version.h> that don't need it.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-09 16:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-12 14:29 [PATCH -next] i2c: mux: mlxcpld: remove unused including <linux/version.h> Wei Yongjun
2017-01-12 14:36 ` Peter Rosin
2017-01-12 15:40 ` Vadim Pasternak
2017-02-09 16:29 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox