From: Wolfram Sang <wsa@the-dreams.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Hoan Tran <hotran@apm.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Tin Huynh <tnhuynh@apm.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: xgene-slimpro: include linux/io.h for memremap
Date: Sun, 18 Jun 2017 15:02:23 +0200 [thread overview]
Message-ID: <20170618130223.p2nysktwi3fqlvj2@ninjato> (raw)
In-Reply-To: <20170615135740.fa2g5wbdwx7psn2w@ninjato>
[-- Attachment #1: Type: text/plain, Size: 1102 bytes --]
On Thu, Jun 15, 2017 at 03:57:40PM +0200, Wolfram Sang wrote:
> On Fri, Jun 09, 2017 at 12:29:12PM +0200, Arnd Bergmann wrote:
> > The newly added support for the pcc mailbox fails to build
> > in some configurations:
> >
> > drivers/i2c/busses/i2c-xgene-slimpro.c: In function 'xgene_slimpro_i2c_probe':
> > drivers/i2c/busses/i2c-xgene-slimpro.c:516:25: error: implicit declaration of function 'memremap'; did you mean 'memcmp'? [-Werror=implicit-function-declaration]
> > drivers/i2c/busses/i2c-xgene-slimpro.c:518:13: error: 'MEMREMAP_WB' undeclared (first use in this function)
> > drivers/i2c/busses/i2c-xgene-slimpro.c:518:13: note: each undeclared identifier is reported only once for each function it appears in
> >
> > This includes the missing header file.
> >
> > Fixes: df5da47fe722 ("i2c: xgene-slimpro: Add ACPI support by using PCC mailbox")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Applied to for-current, thanks!
Oops, the offending commit is only in for-next. So, reconsidered and
moved this patch to for-next as well.
Regards,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-06-18 13:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-09 10:29 [PATCH] i2c: xgene-slimpro: include linux/io.h for memremap Arnd Bergmann
2017-06-09 17:27 ` Hoan Tran
2017-06-15 13:57 ` Wolfram Sang
2017-06-18 13:02 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170618130223.p2nysktwi3fqlvj2@ninjato \
--to=wsa@the-dreams.de \
--cc=arnd@arndb.de \
--cc=hotran@apm.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=tnhuynh@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox