From: Jean Delvare <jdelvare@suse.de>
To: maxin.john@gmail.com
Cc: linux-i2c@vger.kernel.org, "Maxin B. John" <maxin.john@intel.com>
Subject: Re: [PATCH] i2c-tools: eeprog/Module.mk: Add missing dependency
Date: Tue, 19 Dec 2017 13:53:24 +0100 [thread overview]
Message-ID: <20171219135324.20dd6e12@endymion> (raw)
In-Reply-To: <1513606297-5072-1-git-send-email-maxin.john@gmail.com>
On Mon, 18 Dec 2017 16:11:37 +0200, maxin.john@gmail.com wrote:
> From: "Maxin B. John" <maxin.john@intel.com>
>
> Absence of this dependency caused parallel build to run into a race
> and break.
>
> Signed-off-by: Maxin B. John <maxin.john@intel.com>
> ---
> eeprog/Module.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/eeprog/Module.mk b/eeprog/Module.mk
> index 9d36869..d215855 100644
> --- a/eeprog/Module.mk
> +++ b/eeprog/Module.mk
> @@ -20,7 +20,7 @@ EEPROG_TARGETS := eeprog
> # Programs
> #
>
> -$(EEPROG_DIR)/eeprog: $(EEPROG_DIR)/eeprog.o $(EEPROG_DIR)/24cXX.o
> +$(EEPROG_DIR)/eeprog: $(EEPROG_DIR)/eeprog.o $(EEPROG_DIR)/24cXX.o $(LIB_DEPS)
> $(CC) $(LDFLAGS) -o $@ $^ $(EEPROG_LDFLAGS)
>
> #
Good catch, sorry for missing that one. Applied, thanks.
--
Jean Delvare
SUSE L3 Support
prev parent reply other threads:[~2017-12-19 12:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 14:11 [PATCH] i2c-tools: eeprog/Module.mk: Add missing dependency maxin.john
2017-12-19 12:53 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171219135324.20dd6e12@endymion \
--to=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=maxin.john@gmail.com \
--cc=maxin.john@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox