public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <jdelvare@suse.de>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-i2c@vger.kernel.org
Subject: Re: [PATCH i2c-tools] CHANGES: add i2ctransfer
Date: Fri, 19 Jan 2018 09:22:52 +0100	[thread overview]
Message-ID: <20180119092252.6eaa32c6@endymion> (raw)
In-Reply-To: <20180115173644.12342-1-wsa+renesas@sang-engineering.com>

Hi Wolfram,

On Mon, 15 Jan 2018 18:36:44 +0100, Wolfram Sang wrote:
> So people know from CHANGES when it has been added.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>  CHANGES | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/CHANGES b/CHANGES
> index 1ddaa9c..7ad9e21 100644
> --- a/CHANGES
> +++ b/CHANGES
> @@ -63,6 +63,7 @@ master
>              Marked as deprecated
>    i2cdetect: Do a best effort detection if functionality is missing
>               Clarify the SMBus commands used for probing by default
> +  i2ctransfer: new tool to send user-defined I2C messages in one transfer
>    i2c-dev.h: Minimize differences with kernel flavor
>               Move SMBus helper functions to include/i2c/smbus.h
>    i2c-stub-from-dump: Be more tolerant on input dump format

Good idea. A leading capital would be appreciated for consistency.

Speaking of i2ctransfer, would you agree to remove it from the
i2c-tools-3.1 branch? As I recall, the only reason why it was added
there in the first place is because the release of i2c-tools 4.0 was
late, but this has happened meanwhile. I don't think it makes sense to
add a new tool to branch in maintenance state which is supposed to
receive only bug fixes. As a packager, I would not expect to have to
change anything to my packaging if I follow such a branch.

-- 
Jean Delvare
SUSE L3 Support

  reply	other threads:[~2018-01-19  8:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-15 17:36 [PATCH i2c-tools] CHANGES: add i2ctransfer Wolfram Sang
2018-01-19  8:22 ` Jean Delvare [this message]
2018-01-19  9:19   ` Wolfram Sang
2018-01-20 19:35     ` Jean Delvare
2018-01-20 19:38       ` Wolfram Sang
2018-01-24  6:07         ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180119092252.6eaa32c6@endymion \
    --to=jdelvare@suse.de \
    --cc=linux-i2c@vger.kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox