* [PATCH i2c-tools] CHANGES: add i2ctransfer
@ 2018-01-15 17:36 Wolfram Sang
2018-01-19 8:22 ` Jean Delvare
0 siblings, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2018-01-15 17:36 UTC (permalink / raw)
To: linux-i2c; +Cc: Jean Delvare, Wolfram Sang
So people know from CHANGES when it has been added.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
CHANGES | 1 +
1 file changed, 1 insertion(+)
diff --git a/CHANGES b/CHANGES
index 1ddaa9c..7ad9e21 100644
--- a/CHANGES
+++ b/CHANGES
@@ -63,6 +63,7 @@ master
Marked as deprecated
i2cdetect: Do a best effort detection if functionality is missing
Clarify the SMBus commands used for probing by default
+ i2ctransfer: new tool to send user-defined I2C messages in one transfer
i2c-dev.h: Minimize differences with kernel flavor
Move SMBus helper functions to include/i2c/smbus.h
i2c-stub-from-dump: Be more tolerant on input dump format
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH i2c-tools] CHANGES: add i2ctransfer
2018-01-15 17:36 [PATCH i2c-tools] CHANGES: add i2ctransfer Wolfram Sang
@ 2018-01-19 8:22 ` Jean Delvare
2018-01-19 9:19 ` Wolfram Sang
0 siblings, 1 reply; 6+ messages in thread
From: Jean Delvare @ 2018-01-19 8:22 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-i2c
Hi Wolfram,
On Mon, 15 Jan 2018 18:36:44 +0100, Wolfram Sang wrote:
> So people know from CHANGES when it has been added.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> CHANGES | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/CHANGES b/CHANGES
> index 1ddaa9c..7ad9e21 100644
> --- a/CHANGES
> +++ b/CHANGES
> @@ -63,6 +63,7 @@ master
> Marked as deprecated
> i2cdetect: Do a best effort detection if functionality is missing
> Clarify the SMBus commands used for probing by default
> + i2ctransfer: new tool to send user-defined I2C messages in one transfer
> i2c-dev.h: Minimize differences with kernel flavor
> Move SMBus helper functions to include/i2c/smbus.h
> i2c-stub-from-dump: Be more tolerant on input dump format
Good idea. A leading capital would be appreciated for consistency.
Speaking of i2ctransfer, would you agree to remove it from the
i2c-tools-3.1 branch? As I recall, the only reason why it was added
there in the first place is because the release of i2c-tools 4.0 was
late, but this has happened meanwhile. I don't think it makes sense to
add a new tool to branch in maintenance state which is supposed to
receive only bug fixes. As a packager, I would not expect to have to
change anything to my packaging if I follow such a branch.
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH i2c-tools] CHANGES: add i2ctransfer
2018-01-19 8:22 ` Jean Delvare
@ 2018-01-19 9:19 ` Wolfram Sang
2018-01-20 19:35 ` Jean Delvare
0 siblings, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2018-01-19 9:19 UTC (permalink / raw)
To: Jean Delvare; +Cc: Wolfram Sang, linux-i2c
[-- Attachment #1: Type: text/plain, Size: 390 bytes --]
> > + i2ctransfer: new tool to send user-defined I2C messages in one transfer
>
> Good idea. A leading capital would be appreciated for consistency.
Ack. Shall I resend or could you fix locally?
> Speaking of i2ctransfer, would you agree to remove it from the
> i2c-tools-3.1 branch? As I recall, the only reason why it was added
Acked-by: Wolfram Sang <wsa@the-dreams.de>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH i2c-tools] CHANGES: add i2ctransfer
2018-01-19 9:19 ` Wolfram Sang
@ 2018-01-20 19:35 ` Jean Delvare
2018-01-20 19:38 ` Wolfram Sang
0 siblings, 1 reply; 6+ messages in thread
From: Jean Delvare @ 2018-01-20 19:35 UTC (permalink / raw)
To: Wolfram Sang; +Cc: Wolfram Sang, linux-i2c
On Fri, 19 Jan 2018 10:19:29 +0100, Wolfram Sang wrote:
> > > + i2ctransfer: new tool to send user-defined I2C messages in one transfer
> >
> > Good idea. A leading capital would be appreciated for consistency.
>
> Ack. Shall I resend or could you fix locally?
Why me? You have write access to the repository, you might as well do
it yourself, with my:
Acked-by: Jean Delvare <jdelvare@suse.de>
> > Speaking of i2ctransfer, would you agree to remove it from the
> > i2c-tools-3.1 branch? As I recall, the only reason why it was added
>
> Acked-by: Wolfram Sang <wsa@the-dreams.de>
Done, thanks.
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH i2c-tools] CHANGES: add i2ctransfer
2018-01-20 19:35 ` Jean Delvare
@ 2018-01-20 19:38 ` Wolfram Sang
2018-01-24 6:07 ` Wolfram Sang
0 siblings, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2018-01-20 19:38 UTC (permalink / raw)
To: Jean Delvare; +Cc: Wolfram Sang, linux-i2c
[-- Attachment #1: Type: text/plain, Size: 170 bytes --]
> > Ack. Shall I resend or could you fix locally?
>
> Why me? You have write access to the repository, you might as well do
I keep forgetting that :) Will do!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH i2c-tools] CHANGES: add i2ctransfer
2018-01-20 19:38 ` Wolfram Sang
@ 2018-01-24 6:07 ` Wolfram Sang
0 siblings, 0 replies; 6+ messages in thread
From: Wolfram Sang @ 2018-01-24 6:07 UTC (permalink / raw)
To: Jean Delvare; +Cc: Wolfram Sang, linux-i2c
[-- Attachment #1: Type: text/plain, Size: 258 bytes --]
On Sat, Jan 20, 2018 at 08:38:17PM +0100, Wolfram Sang wrote:
>
> > > Ack. Shall I resend or could you fix locally?
> >
> > Why me? You have write access to the repository, you might as well do
>
> I keep forgetting that :) Will do!
Done now.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-01-24 6:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-15 17:36 [PATCH i2c-tools] CHANGES: add i2ctransfer Wolfram Sang
2018-01-19 8:22 ` Jean Delvare
2018-01-19 9:19 ` Wolfram Sang
2018-01-20 19:35 ` Jean Delvare
2018-01-20 19:38 ` Wolfram Sang
2018-01-24 6:07 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox